From patchwork Mon Sep 18 19:50:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 141538 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp2914545vqi; Mon, 18 Sep 2023 12:54:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IErn4t0bD87eT+K3CmvQ42rXBSdwKmdwpShonEs4W+MpgsVBFIwMKGJrkb7WO4ETVPkY3PM X-Received: by 2002:a17:90a:d18c:b0:273:e090:6096 with SMTP id fu12-20020a17090ad18c00b00273e0906096mr667097pjb.11.1695066887807; Mon, 18 Sep 2023 12:54:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695066887; cv=none; d=google.com; s=arc-20160816; b=XVXyhUXQaA+U1rQCwsTOclZ35rCdBg7uBva3NI4CcJU2A7Ln2fm+TPpwOLVG3PyPpu bLpJjTwBbUhVuxX7Oaofb30ysSD1YwGsCVj7IEDwaMitp/bnDeQtudX7w8/wGMK6Q/yN gKZjk9W/5QDv+ysV6fyaexgycMzFXz7fRexNMrJVMLnggzgV3z2zaRIGMJ+bY79Usa+A ZE8VU2Zg0dlHdgMkJ71hddqE+4oic9/iz0Vqksp3df1DgF5jG7u/4V0fG+7uyeyKMxhL zrSzW36oSa00g4hMADloLaw7XNBt3dhD/ZFhLOJUk7blMKJo7sn8omKKT5SkRVKj1FoF KOwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=O9Nv2m3SWZ65AGRWaX2RZ2mlbD0UQSb99pt5xE4dnUc=; fh=2LoUldgIftbCGGYNlIKiEffIWCdRcQL9EB8MUfMGcWk=; b=fmz/RsYTfFhhO2hySleBP1GufHumpQQYHQFtEeq4kHNy4yfoUDUR6+Y5RltQ1H2eLV /6no0mty9nhV8BTJdr+F6q+BQ+OduKl0VZCren4nJ2Cm6Y5rugLJ0Yr3TxBHIMTWgp3L 310T/qVmQuLwwFc2bGf3cOgn9ZfrstW4XVboiMY0C1GQmKgIxGGSfCocUn0tURgT9fMQ z2TKkDOBQSroTSF1o5Rc1tMbZhayNXcpThR/hUQ6b5BYwLgQNMNbGqwjF9iJcgXnN24S L3LUEkF9sKbQ7v9Y6JUcYX83ihjrHFP0XioU2ibJCTv0tBk5wG+QpXj9eclSdl9SSUKu ovig== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id i20-20020a17090a7e1400b0026b74f6aaa8si10413489pjl.63.2023.09.18.12.54.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 12:54:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 7833E810AF7E; Mon, 18 Sep 2023 12:51:59 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229627AbjIRTvm (ORCPT + 25 others); Mon, 18 Sep 2023 15:51:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbjIRTvf (ORCPT ); Mon, 18 Sep 2023 15:51:35 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CC76109 for ; Mon, 18 Sep 2023 12:51:29 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qiKH9-0003lJ-LJ; Mon, 18 Sep 2023 21:51:19 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qiKH9-007I8t-7G; Mon, 18 Sep 2023 21:51:19 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qiKH8-002mCY-U9; Mon, 18 Sep 2023 21:51:18 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Andrew Lunn , Heiner Kallweit Cc: Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 09/19] net: mdio: mscc-miim: Convert to platform remove callback returning void Date: Mon, 18 Sep 2023 21:50:52 +0200 Message-Id: <20230918195102.1302746-10-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230918195102.1302746-1-u.kleine-koenig@pengutronix.de> References: <20230918195102.1302746-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1832; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=041TtYXxE7dnRKGf01E0nKWqzpFWJPRnpGRIyKv8VLg=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlCKoKsaAjqfD4HL51xNTtF1K7xknpVDy1TRBo5 xjWiIf1Yu2JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZQiqCgAKCRCPgPtYfRL+ Tr/KCACYwA5Axo2xV8jZiqHtAim2rPaK47qldTD4vu/bNJo/SSEIRt+qv8oUvzi6XWr+6NkEOMU KOS/v4UDnM8V0gdPCDDbwoZkyBCR66yCN0xCYMkxaHGUjSNKjyKFpj6cZgaQh390SQfbs4h0XSB aM++rseZQdmkpsdOaU2/K2Hm4U1e9u78jY5UUIiU1dLGYGYK/WTU0md8n59F9n8JHhZSftQl68J ESuSnayftPl/WAgak6cq8Aksjc+HcsToh/VPE1e07PQiA78Qi1C0TluDojxJI4n0ZSRJ363EoPT M3/K0majEtAzi8k9Vj/i/xJ21emdKJ/jnkYJpr6w+tkKLKEk X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 18 Sep 2023 12:51:59 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777406457141118484 X-GMAIL-MSGID: 1777406457141118484 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() is renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/net/mdio/mdio-mscc-miim.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/mdio/mdio-mscc-miim.c b/drivers/net/mdio/mdio-mscc-miim.c index 1a1b95ae95fa..c29377c85307 100644 --- a/drivers/net/mdio/mdio-mscc-miim.c +++ b/drivers/net/mdio/mdio-mscc-miim.c @@ -335,15 +335,13 @@ static int mscc_miim_probe(struct platform_device *pdev) return ret; } -static int mscc_miim_remove(struct platform_device *pdev) +static void mscc_miim_remove(struct platform_device *pdev) { struct mii_bus *bus = platform_get_drvdata(pdev); struct mscc_miim_dev *miim = bus->priv; clk_disable_unprepare(miim->clk); mdiobus_unregister(bus); - - return 0; } static const struct mscc_miim_info mscc_ocelot_miim_info = { @@ -371,7 +369,7 @@ MODULE_DEVICE_TABLE(of, mscc_miim_match); static struct platform_driver mscc_miim_driver = { .probe = mscc_miim_probe, - .remove = mscc_miim_remove, + .remove_new = mscc_miim_remove, .driver = { .name = "mscc-miim", .of_match_table = mscc_miim_match,