From patchwork Mon Sep 18 14:40:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Durrant X-Patchwork-Id: 141601 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp2990397vqi; Mon, 18 Sep 2023 15:24:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGV2rxjHXdx6ZmzA0QgX6E9NPQ7/Of1Pwlj+X83/NktwPZRhuIUnL00sSfAD0Q5NJ1n4+2c X-Received: by 2002:a05:6a21:498a:b0:159:ee0f:b9e9 with SMTP id ax10-20020a056a21498a00b00159ee0fb9e9mr10634664pzc.53.1695075863967; Mon, 18 Sep 2023 15:24:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695075863; cv=none; d=google.com; s=arc-20160816; b=PRqQLxSj/2pr/hWn+4Ll4vnbtieZrut+0PTFwOadW2ZJN+Iw+fVNEizuPg++qJZKMH WOsD8OxajuaD/hi5RzF/xmdQVNovapNn3ljXQ/yjoQTbbchLVv5k51iUM8iAdvKwoTc4 VzbKbLM6rKle5ng/G/oQrIKlVVFfiiZbszyoBNN99ZDdAJ4ivcTeD34hYCUY/fSGXx7o CXVmpweDvGyynQfQwU2UyXI4nPQSR+OA+l1Q7ouK/bNICKJL7srYkdhqy6bMvfQP2POQ PSFVcXgxNa+9odTllBFX5lifbhziVj/YQ1Ox4JH79oOoCjv1ClQaG8JO6KTUil3b47j0 v4uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=jvOmcsLACoe+aYwCOVTUhhHhMDjob15u+BiUav871xs=; fh=YQxcWeFtTLB3mMceSRxC2i/1m4lEYnAvVMXZ98qp9Z4=; b=ImRdDCEnbAy79uBzIoVwY5pDkHjscb1i47tMKjUnehBBeH2OCySfZuz/MWyJMVY/eq j6WKQ3dXR1tolPBcCZX3lLJBHoKMq/sbdF9iE/l1AhwjK7daHnFBGPEOTv25NLmWkSyz GiRH+k/j8UANMslu3chz8He1gW3KnQ80HHrl+zZ0ZdEXMtvgC/BnpSefxwwIZfH4ssrn dlY4qJ64UkleD+UpQgVo9GrjJlUd+Zo8JSj4Pvyn9HaWdXbnTUUXkuL/G5cdsV1YZy1i FvX7NtaSbDOEkEAKWjsEQ5VVyyRpPx+3mXnVBnzP85+EVfC9/UmPeOCDD1bAHQIoCTOw mKgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@xen.org header.s=20200302mail header.b=GRCxX4YT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id ga19-20020a17090b039300b00267ba1c43adsi4722336pjb.101.2023.09.18.15.24.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 15:24:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@xen.org header.s=20200302mail header.b=GRCxX4YT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 87357808725E; Mon, 18 Sep 2023 09:10:33 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230039AbjIRQKF (ORCPT + 25 others); Mon, 18 Sep 2023 12:10:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230021AbjIRQJP (ORCPT ); Mon, 18 Sep 2023 12:09:15 -0400 Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8B31A2; Mon, 18 Sep 2023 09:07:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=jvOmcsLACoe+aYwCOVTUhhHhMDjob15u+BiUav871xs=; b=GRCxX4YTF4slf9SBndQGZFfQcN LQ8ySwl28vuiIhH2mdN7b+bXi5FS9PaxfWombgQQEosy+roH2Y6pqDoc8ovf6s7Cvi4loxIHalDpu aP8sEF43iKkpMqH+5OFotPxkcYshf7alMxOA02KLW7p/L+71UF9K4AnRePCehusCPCEw=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qiFR6-0003Q4-R0; Mon, 18 Sep 2023 14:41:16 +0000 Received: from ec2-63-33-11-17.eu-west-1.compute.amazonaws.com ([63.33.11.17] helo=REM-PW02S00X.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qiFR6-0006IJ-JI; Mon, 18 Sep 2023 14:41:16 +0000 From: Paul Durrant To: kvm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Paul Durrant , David Woodhouse , David Woodhouse , Paolo Bonzini Subject: [PATCH v3 01/13] KVM: pfncache: add a map helper function Date: Mon, 18 Sep 2023 14:40:59 +0000 Message-Id: <20230918144111.641369-2-paul@xen.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230918144111.641369-1-paul@xen.org> References: <20230918144111.641369-1-paul@xen.org> MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 18 Sep 2023 09:10:34 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777415868953519102 X-GMAIL-MSGID: 1777415868953519102 From: Paul Durrant We have an unmap helper but mapping is open-coded. Arguably this is fine because mapping is done in only one place, hva_to_pfn_retry(), but adding the helper does make that function more readable. No functional change intended. Signed-off-by: Paul Durrant Reviewed-by: David Woodhouse --- Cc: David Woodhouse Cc: Paolo Bonzini --- virt/kvm/pfncache.c | 43 +++++++++++++++++++++++++------------------ 1 file changed, 25 insertions(+), 18 deletions(-) diff --git a/virt/kvm/pfncache.c b/virt/kvm/pfncache.c index 2d6aba677830..0f36acdf577f 100644 --- a/virt/kvm/pfncache.c +++ b/virt/kvm/pfncache.c @@ -96,17 +96,28 @@ bool kvm_gpc_check(struct gfn_to_pfn_cache *gpc, unsigned long len) } EXPORT_SYMBOL_GPL(kvm_gpc_check); -static void gpc_unmap_khva(kvm_pfn_t pfn, void *khva) +static void *gpc_map(kvm_pfn_t pfn) +{ + if (pfn_valid(pfn)) + return kmap(pfn_to_page(pfn)); +#ifdef CONFIG_HAS_IOMEM + else + return memremap(pfn_to_hpa(pfn), PAGE_SIZE, MEMREMAP_WB); +#endif +} + +static void gpc_unmap(kvm_pfn_t pfn, void *khva) { /* Unmap the old pfn/page if it was mapped before. */ - if (!is_error_noslot_pfn(pfn) && khva) { - if (pfn_valid(pfn)) - kunmap(pfn_to_page(pfn)); + if (is_error_noslot_pfn(pfn) || !khva) + return; + + if (pfn_valid(pfn)) + kunmap(pfn_to_page(pfn)); #ifdef CONFIG_HAS_IOMEM - else - memunmap(khva); + else + memunmap(khva); #endif - } } static inline bool mmu_notifier_retry_cache(struct kvm *kvm, unsigned long mmu_seq) @@ -175,7 +186,7 @@ static kvm_pfn_t hva_to_pfn_retry(struct gfn_to_pfn_cache *gpc) * the existing mapping and didn't create a new one. */ if (new_khva != old_khva) - gpc_unmap_khva(new_pfn, new_khva); + gpc_unmap(new_pfn, new_khva); kvm_release_pfn_clean(new_pfn); @@ -193,15 +204,11 @@ static kvm_pfn_t hva_to_pfn_retry(struct gfn_to_pfn_cache *gpc) * too must be done outside of gpc->lock! */ if (gpc->usage & KVM_HOST_USES_PFN) { - if (new_pfn == gpc->pfn) { + if (new_pfn == gpc->pfn) new_khva = old_khva; - } else if (pfn_valid(new_pfn)) { - new_khva = kmap(pfn_to_page(new_pfn)); -#ifdef CONFIG_HAS_IOMEM - } else { - new_khva = memremap(pfn_to_hpa(new_pfn), PAGE_SIZE, MEMREMAP_WB); -#endif - } + else + new_khva = gpc_map(new_pfn); + if (!new_khva) { kvm_release_pfn_clean(new_pfn); goto out_error; @@ -326,7 +333,7 @@ static int __kvm_gpc_refresh(struct gfn_to_pfn_cache *gpc, gpa_t gpa, mutex_unlock(&gpc->refresh_lock); if (unmap_old) - gpc_unmap_khva(old_pfn, old_khva); + gpc_unmap(old_pfn, old_khva); return ret; } @@ -412,7 +419,7 @@ void kvm_gpc_deactivate(struct gfn_to_pfn_cache *gpc) list_del(&gpc->list); spin_unlock(&kvm->gpc_lock); - gpc_unmap_khva(old_pfn, old_khva); + gpc_unmap(old_pfn, old_khva); } } EXPORT_SYMBOL_GPL(kvm_gpc_deactivate);