From patchwork Mon Sep 18 12:24:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Biju Das X-Patchwork-Id: 141403 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp2623008vqi; Mon, 18 Sep 2023 05:36:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE/7QDubi7aO7yjFPG7H/PtyTmNgoKRh1dcE4arvMflmNPLPa8SyiNS+MTRZ4MaKdmXM3ud X-Received: by 2002:a17:90a:17cb:b0:274:8041:94c with SMTP id q69-20020a17090a17cb00b002748041094cmr5999113pja.13.1695040603687; Mon, 18 Sep 2023 05:36:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695040603; cv=none; d=google.com; s=arc-20160816; b=P3KmUSVRKzcCqOe/eSWbYkpc6NwmSlR6tpSOKip0RWjQmmKpBWQA3sSt6t+YY4D7jr aYbR+VdhQUizjc2ao5tS5fCSiBpdskgtwaeJRHfgIFrbK93MVDNzvUnzCbprrCLawZPW WNbujmrSBYMbfBBmp8V7cB9kCS1vVq2xV4kDGkm/+i9gKl76Au4V1Kcwtw6wOqYjyyz7 IAz10V/LZ+cwbIpse43g8lf7b56Tf/RRKugg9gqCQx0zEVAj9+prWW3mkrdr0Gv97kzk mbuE4ohmwQT1DmK3qRBiyjEEoyD1As64pUzKr4sfk8n/R3KsKEA8PE6Uxj///FPKrUWd rqLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=A8oW/LuF1hUY3LGSfcPptaQqpzk2mJwUOL6iBz7fW1s=; fh=sWH11FnHMfCkHSU9kXlYjtdyZVAjuuR7mMUGHavtm3Q=; b=eQzEo6tLzUQx7uPQ8laQavsj7086spvQ+5M2qqKtkh4IFqVSSfNI+BEyarWiG2eUcI RrEGCT/Ci+fNBwWB+B9Af2Zd6Cmcd/HbgE+U4uPxJH2RrLmb/nNwdvFCUV8IkAnx8iGL sBz/QJbdTRin6/+SWB0KI/pMcRYqWgmU3QzctuHhrcgMlDxQ7uy25bqICmSh4So2iql5 Vmu95sYRQKgvZgWiQVQpZwS8nifRhM92hsQcW+8ssiIaoA7sWSUfWGlDiBqhO+jMsKgp ZcSR+s/63FtKaFuVzL8SDQvrmPctXmC2FhZvZgSFIMMG5GBsJn+TTePN90qXRfaSjlYQ VEYg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=renesas.com Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id mq9-20020a17090b380900b00274df27f882si3167801pjb.35.2023.09.18.05.36.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 05:36:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=renesas.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id C0AB98227929; Mon, 18 Sep 2023 05:25:22 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241950AbjIRMYt (ORCPT + 27 others); Mon, 18 Sep 2023 08:24:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241986AbjIRMYc (ORCPT ); Mon, 18 Sep 2023 08:24:32 -0400 Received: from relmlie5.idc.renesas.com (relmlor1.renesas.com [210.160.252.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 063239F; Mon, 18 Sep 2023 05:24:21 -0700 (PDT) X-IronPort-AV: E=Sophos;i="6.02,156,1688396400"; d="scan'208";a="176397777" Received: from unknown (HELO relmlir6.idc.renesas.com) ([10.200.68.152]) by relmlie5.idc.renesas.com with ESMTP; 18 Sep 2023 21:24:21 +0900 Received: from localhost.localdomain (unknown [10.226.92.107]) by relmlir6.idc.renesas.com (Postfix) with ESMTP id 96B8141F6ACF; Mon, 18 Sep 2023 21:24:18 +0900 (JST) From: Biju Das To: Thomas Gleixner , Marc Zyngier Cc: Biju Das , Lad Prabhakar , Claudiu Beznea , Geert Uytterhoeven , Biju Das , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: [PATCH 1/3] irqchip: renesas-rzg2l: Fix logic to clear TINT interrupt source Date: Mon, 18 Sep 2023 13:24:09 +0100 Message-Id: <20230918122411.237635-2-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230918122411.237635-1-biju.das.jz@bp.renesas.com> References: <20230918122411.237635-1-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 18 Sep 2023 05:25:22 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777378896118107068 X-GMAIL-MSGID: 1777378896118107068 The logic to clear the TINT interrupt source in rzg2l_irqc_irq_disable() is wrong as the mask is correct only for LSB on the TSSR register. This issue is found when testing with two TINT interrupt sources. So fix the logic for all TINTs by using the macro TSSEL_SHIFT() to multiply tssr_offset with 8. Fixes: 3fed09559cd8 ("irqchip: Add RZ/G2L IA55 Interrupt Controller driver") Signed-off-by: Biju Das Tested-by: Claudiu Beznea Reviewed-by: Geert Uytterhoeven Reviewed-by: Claudiu Beznea --- drivers/irqchip/irq-renesas-rzg2l.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-renesas-rzg2l.c b/drivers/irqchip/irq-renesas-rzg2l.c index 4bbfa2b0a4df..2cee5477be6b 100644 --- a/drivers/irqchip/irq-renesas-rzg2l.c +++ b/drivers/irqchip/irq-renesas-rzg2l.c @@ -118,7 +118,7 @@ static void rzg2l_irqc_irq_disable(struct irq_data *d) raw_spin_lock(&priv->lock); reg = readl_relaxed(priv->base + TSSR(tssr_index)); - reg &= ~(TSSEL_MASK << tssr_offset); + reg &= ~(TSSEL_MASK << TSSEL_SHIFT(tssr_offset)); writel_relaxed(reg, priv->base + TSSR(tssr_index)); raw_spin_unlock(&priv->lock); }