From patchwork Mon Sep 18 09:03:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Zimmermann X-Patchwork-Id: 141394 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp2613301vqi; Mon, 18 Sep 2023 05:21:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHDv6785V1vazNL8SvZxavx9QcR16/WlLl+N6LVd6tWUsd5aGbsXrGcxFqZkaoLGtl4wcuP X-Received: by 2002:a05:6a20:dd82:b0:14c:c393:402d with SMTP id kw2-20020a056a20dd8200b0014cc393402dmr7164454pzb.34.1695039667517; Mon, 18 Sep 2023 05:21:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695039667; cv=none; d=google.com; s=arc-20160816; b=Zlw5Q0MwPG/1VGpPw3mJVO0xNq1LLHW+2lhBMwIldx0upFlfbaNHxYsUHIxWklTs6q y0wPgv2VI1fVAsbbixZq6jek94m1/BpjerVZb3UnTjJAj3Iw9CGbJCvEOdJhjWBhHPHY sht+SOgFxxpqWewp7CejMxZa8McNhNTDKj8rI5JAoH1fDyNQy1fFQbUg7HNVXwxaxJz3 ZYTxlJhSGIHcXA7yEZplID+xcZJI0yhyIxLPoqjprxhMcusHCxK8V9n9RbG0okxvvsUe YeSqluDw6dnTUvfoOFtAcjKSAOwLnyPXGLjJ7hhGrY4wEPMf+1lHlY9qznF8oom3z9NJ gcQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature:dkim-signature; bh=y8ulxZTAU8ZHRSVUlnFEqeNxmI2g5k3RdNfkDBzDyL4=; fh=eeyi0dxGfOnjowHNBJauFe5RwmJCiRBBNgee5gQh9rA=; b=w4O/YPNqjsTmF7jCQ0n0nsPGytL5i81fwzeK/VBU5enH21IvmO6LRrdWnO3ME4dinY TbUumeeRwCF2arVTDhMWt3NPEuZUGEodhvGszAkRNta79JYnz9nPB1CX0C3tcKvpyolf gD5qUZusMKj7/1z52Akhaw0L6sjiicD/s1sHTtNGzTWdAsN2mdQUkZcV96uvoSgvu07T KwJAU6RfDqG3sKJQPpb0sg1Wny8XPPYzByh4mDERWJKR533CU9E7PmVxwyC/1b9CRrUM aRzU6n+MvmwRDIJO01TUBP2pIVp8ljSKDRHOOX61kBxLqJyykyv/JIRkMtuoXYMx8iXJ S8wA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=QanKoGQD; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id l10-20020a654c4a000000b00565d88203c8si7680647pgr.535.2023.09.18.05.21.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 05:21:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=QanKoGQD; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 2AE7D807CEE0; Mon, 18 Sep 2023 02:05:30 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239106AbjIRJEi (ORCPT + 27 others); Mon, 18 Sep 2023 05:04:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239072AbjIRJEL (ORCPT ); Mon, 18 Sep 2023 05:04:11 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBA3FD1; Mon, 18 Sep 2023 02:04:03 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 626931FD92; Mon, 18 Sep 2023 09:04:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1695027842; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=y8ulxZTAU8ZHRSVUlnFEqeNxmI2g5k3RdNfkDBzDyL4=; b=QanKoGQDn+l/JZ21hEKb+AMs28Dq5uMeR9Nld3yJhyelrsKXD+fQWu0yhKkOvf8o/eL133 TUbfm5z033M+P24F1F3RBppZXJh4LsRzwrrJGrL8cjO6I5BLv8Sw6AhQKhRdo6xpJiWFsZ ZizWAnL1AcrKj2kqj12ABhoiGUwA5vs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1695027842; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=y8ulxZTAU8ZHRSVUlnFEqeNxmI2g5k3RdNfkDBzDyL4=; b=54tZC2yWZS+MbxdWdVOcFqsWohg5jRmfAqQ3t+wOtGjMKL6HtRuU2g8FpClwaYuF+9q6TC gprw7VKHpq/QNhBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2A5CA13480; Mon, 18 Sep 2023 09:04:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id tgl1CYISCGX7CgAAMHmgww (envelope-from ); Mon, 18 Sep 2023 09:04:02 +0000 From: Thomas Zimmermann To: deller@gmx.de, sam@ravnborg.org, arnd@arndb.de, javierm@redhat.com, rdunlap@infradead.org, glaubitz@physik.fu-berlin.de Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, oe-kbuild-all@lists.linux.dev, Thomas Zimmermann , kernel test robot Subject: [PATCH] fbdev/sh7760fb: Depend on FB=y Date: Mon, 18 Sep 2023 11:03:49 +0200 Message-ID: <20230918090400.13264-1-tzimmermann@suse.de> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 18 Sep 2023 02:05:30 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777377914603990253 X-GMAIL-MSGID: 1777377914603990253 Fix linker error if FB=m about missing fb_io_read and fb_io_write. The linker's error message suggests that this config setting has already been broken for other symbols. All errors (new ones prefixed by >>): sh4-linux-ld: drivers/video/fbdev/sh7760fb.o: in function `sh7760fb_probe': sh7760fb.c:(.text+0x374): undefined reference to `framebuffer_alloc' sh4-linux-ld: sh7760fb.c:(.text+0x394): undefined reference to `fb_videomode_to_var' sh4-linux-ld: sh7760fb.c:(.text+0x39c): undefined reference to `fb_alloc_cmap' sh4-linux-ld: sh7760fb.c:(.text+0x3a4): undefined reference to `register_framebuffer' sh4-linux-ld: sh7760fb.c:(.text+0x3ac): undefined reference to `fb_dealloc_cmap' sh4-linux-ld: sh7760fb.c:(.text+0x434): undefined reference to `framebuffer_release' sh4-linux-ld: drivers/video/fbdev/sh7760fb.o: in function `sh7760fb_remove': sh7760fb.c:(.text+0x800): undefined reference to `unregister_framebuffer' sh4-linux-ld: sh7760fb.c:(.text+0x804): undefined reference to `fb_dealloc_cmap' sh4-linux-ld: sh7760fb.c:(.text+0x814): undefined reference to `framebuffer_release' >> sh4-linux-ld: drivers/video/fbdev/sh7760fb.o:(.rodata+0xc): undefined reference to `fb_io_read' >> sh4-linux-ld: drivers/video/fbdev/sh7760fb.o:(.rodata+0x10): undefined reference to `fb_io_write' sh4-linux-ld: drivers/video/fbdev/sh7760fb.o:(.rodata+0x2c): undefined reference to `cfb_fillrect' sh4-linux-ld: drivers/video/fbdev/sh7760fb.o:(.rodata+0x30): undefined reference to `cfb_copyarea' sh4-linux-ld: drivers/video/fbdev/sh7760fb.o:(.rodata+0x34): undefined reference to `cfb_imageblit' Suggested-by: Randy Dunlap Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202309130632.LS04CPWu-lkp@intel.com/ Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas Acked-by: John Paul Adrian Glaubitz Acked-by: John Paul Adrian Glaubitz --- drivers/video/fbdev/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig index 4455bfd57f0ec..64ccb34d882dd 100644 --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig @@ -1756,7 +1756,7 @@ config FB_COBALT config FB_SH7760 bool "SH7760/SH7763/SH7720/SH7721 LCDC support" - depends on FB && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \ + depends on FB=y && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \ || CPU_SUBTYPE_SH7720 || CPU_SUBTYPE_SH7721) select FB_IOMEM_HELPERS help