Message ID | 20230918-vf610-gpio-v3-2-ada82a17adc5@nxp.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp2513941vqi; Mon, 18 Sep 2023 01:51:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFcfY1SXI1PuGpTa4fl27vlato/kq25EUvouny+K6+nFHXcYoZMAOrvGoV2VgklZtbCflWY X-Received: by 2002:a17:90a:49c8:b0:268:4c01:eb56 with SMTP id l8-20020a17090a49c800b002684c01eb56mr5968706pjm.2.1695027095423; Mon, 18 Sep 2023 01:51:35 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1695027095; cv=pass; d=google.com; s=arc-20160816; b=R8A1XDQXqc3iiBI8d7yZxDSD1cIou4VcpY559XySSWIiITJCCItNVamoxzjAgz9A8j XOhI6gRBRQPKMTL7d3QJ0lm6xBg7FtsVA24jy6CkDH3hH03nMSpokT42linzWuLzJQ4l SNsgps50JXwXtpLMvoiViFpfuujSk2z07SDd92hvtE/RXVoKuYRP4RGIrUQUOSeR/bSE 5hrhjlag31tF0aPb5IOoFwRORl++9ORQUGiMyxsPktLnP3aqYU3J7R4eRkUEnt81Kimb A7G8S+USHcyFIVU9mRExGmCVaW/QKOBUOsG70fBPSunRRuJI5gvwwr+ViqDqF3QNTuQX ihug== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:cc:to:in-reply-to:references :message-id:content-transfer-encoding:subject:date:from :dkim-signature; bh=fm+o1IvBBi6qd6oTPQe1raZgW+ZkPhPwH0d7cyrLe6Y=; fh=COwI5EyG1DB6D28RaDWbFhDRTTyfVICzJ11TjDY7TVE=; b=XSJ9SxXPSpsr2xDewhNlj+t6tDL1iazEDnOkSOxOBQTmzW1c5UgmQgfWYF+Wi7aY+c XqE7yej41Wme0ayrK3shS6YpkOh5035HRjOSO6EmYF3gIjlKR7VOHIKQ/m5qY1mUKEwr b//N1HneZE+tODDqVxwoGqR2ix4MLzcCEa5PBnRVbz4vhPNKkplNtOupx35Y6Hf+Rhu7 bMqOCprGrIlTnXt9GAyir3+YxPimiH5RS6ScQJXhSqSwcvMgT5ee4z4aI50a2nBbrBlm KdRTjp/vPVWqKGj281MGQYTtXq/qSC2PNh33jjslzDAKdKJr5aNDJi3oZB84MywZwS2o 4ZFw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@NXP1.onmicrosoft.com header.s=selector2-NXP1-onmicrosoft-com header.b=g7VZj573; arc=pass (i=1 spf=pass spfdomain=oss.nxp.com dkim=pass dkdomain=oss.nxp.com dmarc=pass fromdomain=oss.nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id nl14-20020a17090b384e00b00276804791a2si415733pjb.62.2023.09.18.01.51.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 01:51:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@NXP1.onmicrosoft.com header.s=selector2-NXP1-onmicrosoft-com header.b=g7VZj573; arc=pass (i=1 spf=pass spfdomain=oss.nxp.com dkim=pass dkdomain=oss.nxp.com dmarc=pass fromdomain=oss.nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id EB1BF812A609; Mon, 18 Sep 2023 01:15:13 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240789AbjIRIOa (ORCPT <rfc822;kernel.ruili@gmail.com> + 27 others); Mon, 18 Sep 2023 04:14:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240829AbjIRIOJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 18 Sep 2023 04:14:09 -0400 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2087.outbound.protection.outlook.com [40.107.6.87]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDBF7191; Mon, 18 Sep 2023 01:12:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WvoeQGCkuOeong3JG9KMJwAXINthyyg8rBexaAO+wLuANsezhh/VPwQGOZbftlXuzae0EyD4yx+DiF+eOXy+uWuhKHCWGky9gQMOEwdCg831ZlILgD3OzrWeC0HElF8b2oawD8jM2rteH2e28+a2fd/LndzLmrgkI0B8qXuRH3xq/O0BCmLJUoQwMIiWusw4SQH+5zM6cTk3/+MO8deFx5IjEc38DQSrZMeMTJTV5HEcxgjebxW7q7ax9CwCjIRp+MLkxtW9LiB5atfoL65+YQQyX9qkSuBr+aBXaql1vqWJTeuPBGVlSEP9cBHqJ4jexNrOQl32dENnQi8WuMiKvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fm+o1IvBBi6qd6oTPQe1raZgW+ZkPhPwH0d7cyrLe6Y=; b=PuANLrLsJBRCDBr1RFnFObz4YsyCHBHtDwbnkWQwJMu0eiEasizx7GHVyHIsIhtgSZadzErhmI7RrgjPnu4iOMkqtLiC++OaBbR+zhjaV1RjRz1mkjufEY+Dj8hJXM80nzKIxttvtAM8QagwOpdqOQHAWMBU+sU8yM6wqV+/lhUYNsKiO5QCqmcy8suCGPW+6Yc9pK/JZAAOvLPf8/4pfLhoyf3U03qL8cWINpGSDp9B7+d0Ssc5dEeOyy98nasp6T6sGHJrncA1DjvBTQRDNh8zPgM532I7Wy/3N2/fjCsteYQVcavFaI/a4LMjxUgkdbrhDSU0bdUa31m6dMFp3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fm+o1IvBBi6qd6oTPQe1raZgW+ZkPhPwH0d7cyrLe6Y=; b=g7VZj573VkH1T+V4d5a+Q/ElzBVUHRykiryclEk9goTi0Qk6RoABOA+y68iYn0zlRSGkGGgN5Yga/GSvyMwUa8UoZk1Y57vM+EcA39fjX8ShWeXVVugXqcKQ71ERLJ8vy0KoEl6y1o6iyR4V7OvsncOYrurrfirUXbOwS4G3Cho= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AS8PR04MB8706.eurprd04.prod.outlook.com (2603:10a6:20b:429::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.26; Mon, 18 Sep 2023 08:11:53 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::2b3:d8de:95c8:b28b]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::2b3:d8de:95c8:b28b%3]) with mapi id 15.20.6792.026; Mon, 18 Sep 2023 08:11:53 +0000 From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com> Date: Mon, 18 Sep 2023 16:16:06 +0800 Subject: [PATCH v3 2/6] dt-bindings: gpio: vf610: correct i.MX8ULP and i.MX93 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230918-vf610-gpio-v3-2-ada82a17adc5@nxp.com> References: <20230918-vf610-gpio-v3-0-ada82a17adc5@nxp.com> In-Reply-To: <20230918-vf610-gpio-v3-0-ada82a17adc5@nxp.com> To: Linus Walleij <linus.walleij@linaro.org>, Bartosz Golaszewski <brgl@bgdev.pl>, Andy Shevchenko <andy@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Stefan Agner <stefan@agner.ch>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com> Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peng Fan <peng.fan@nxp.com> X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1695024993; l=2533; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=jRTdkgbDeDxjONBLC+VbNYyEaH9i/EzkpCPJbf7+S50=; b=j2ZfI4UWbt3bbwJQXuegM08823tKbn57xYDK1ANMw6k3MFMjyKaRS60wc+qMQbxzXjQ7WwgxN vHRF36R840HDxEC54imyQll03RZhBrW3m+2mKwXqaozujGr4Qj5+1o6 X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG3P274CA0010.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:be::22) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AS8PR04MB8706:EE_ X-MS-Office365-Filtering-Correlation-Id: 60433705-e794-48f2-2139-08dbb81eeb24 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ayuIzBNeiTcxTA8ayvWg3+bHkGyCwoh3/b8qqvSiZeiZCh0JxA+FN9N2ZFgVzGCE7x82lbCapOgOzLJOu0f/gK+j3QVqT2goi3OLapg/efDHJAUnrAVWIp9vYhG5+EqoxWqp6bmrHJZ15T71su7HePYbP1dEnuMIlh5IBqldKojT/I2cmJtuPqvXJBlvGRvADN+OG/EBIRI5KetEKwMveU9JaXi/yFbl1KTKrcg0cIw0r3gQ6cZwWEC/pdmMnT5qaE913hYhJ9wqX6oXo+Og7Ga7aPscCx6v9tWfVm5KvIERgQjJSSykWaF1MIcUivXjYa0JnbS8XYnTIkGji99FF0CML5qypOTZERw1J1kaSwgO0J4sxJjpplkaGQ/WPI2Q/XZIIM0Y+ha+n7Qd+iXaQF3oqmKE2XQRhg597PpifDFQexnRYI8FQFFNxp6YZommqA11A6v53sLW8AnraAmHCC4st1Lj3kDEiC8ItAdU3nvjSBPFsLXhGvASczNoA0Vrf67WkW7/dk3WkXXCNHRDF62GmGS6HIWwgST9bO38FnOgDKS69EDhH5Pq2CJwhT08YJ0jdOLelfNc6H4OwY6juaBDo0YyvlTHggXiySz/+hlsM26PFvscGdidHw2VwLvNkSyPDiANx2TRSaQOXNMjbQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(39860400002)(346002)(376002)(366004)(136003)(1800799009)(186009)(451199024)(6666004)(6486002)(6506007)(478600001)(8936002)(8676002)(4326008)(921005)(86362001)(26005)(38100700002)(7416002)(38350700002)(5660300002)(66556008)(66946007)(66476007)(83380400001)(110136005)(2906002)(316002)(6512007)(9686003)(41300700001)(52116002)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?RpGpMxojHSVTC+u5YD3zHaHOd5Et?= =?utf-8?q?w7hAi85ZOT47UsRyx0Pv0e4/+UdgPVofPJf7wH19JgelgEs/DxcKRnJUX9OUBssrc?= =?utf-8?q?cCAKAKz9PsMx0u+8C+mqIOMTUU2FMm/BdRahdN5lIEL/tzJD7Um0oj0Rq6JTDpexl?= =?utf-8?q?W8U7oCBD7jp1LosZKg53Iin0Ys8gLIgoIuuTFuglTcZDi4BqcBXaWno+j59pL7aD5?= =?utf-8?q?jqvEVwWlwULJ6jBygR5Qmhd6bLv+4mxU0WZXEGyNZv/ZVlKxKlMXfqK1gXs8hQ9Ni?= =?utf-8?q?2ITWL/qfAhai2zbzUkwonIYZILmyjZmxkxKeM5XZPDhRspzqaDmCLz3J6+gjFlG3q?= =?utf-8?q?jCmI9pLggySbCnrmE7s+Srzmv6u7sq50MFsd5w7yygWMt0dzWgur2iPkMQ3xSZYO7?= =?utf-8?q?hXTs7ETq7bsN/6XwwL8S1M2gQnrk4zcn+aDL5MxfbQTZ0PGLIKiRSBDOux8JMCO50?= =?utf-8?q?qnnTYpr+XnM0NMOuU8SJXUr7eYObltKeRsoH/Jr8paRTa8WJZzoT3MwkugW1YLlXW?= =?utf-8?q?+21pf6JtoSISBiTrAlFqY2U60GeVbdtjyy+Y/MiN2wGZ6Wt1zgIV6Q5Iw3FrA3Tvy?= =?utf-8?q?uwCShHuvTiyh7H6qMkaIxVdqTmieXl5PZGB+i+0osMUbq/73SNefXACQELbmedWwq?= =?utf-8?q?8KHg2nwcoJ+rZHRil3L/y3J0JBCxVsyM9DovyTCHYKcgFcq+eW1RChxfRoxf36UmN?= =?utf-8?q?OQ5ezb0xjIuAM8NUIkqvAxrXyDN1rnE2suF0LOuO0T8Vz5EeD6MN6hZ2bCo5c5FPx?= =?utf-8?q?kyne65j82ShgwCAsgOgq7KWN8aQmTWZ51DNxAj4GHzb9NUUp0+w5zJf6rCHycs64Z?= =?utf-8?q?YxIglf6OAaie62vgpSONYRu78CVIvojfQWsBDEWtWmFR5q0NNJ+OTD35o8/lUj7Vi?= =?utf-8?q?RYg7XNKSa21thesWYMLbw46hM6nYxmExDqzhJHNrtnRbgaLtA+BvkBRdoly2FqBS2?= =?utf-8?q?ZIa01iEq1Xi2xf+48RwgfoM75td+6CZi2PmWz+3cFiV5LX4tgehLqlf93tISeLEWr?= =?utf-8?q?7vjhVCIYDzyquHdAwwPqIWySJujm8jHuxGXRTHrKi2drE28jtcBvl7MGZSfXSOgbR?= =?utf-8?q?P5Qw1+7Cw3tb+1kpHU0YO6TWoClKzTJ0KLzOWQfJV2mrBFBbSVXHOstdS15ae5GI2?= =?utf-8?q?dEkDRtqlsVezoHPyYt6cvHryQii31umLcY1f6pu4XHKYp4Qn+Qwv44ehi7U7iv1jn?= =?utf-8?q?56BPlvNwktdSu0Nz4YwbR7q796E1QBCBMv7MnyuwiWRfbXCdSbCgIaKdJD/lHW7xn?= =?utf-8?q?1xEE3lBgUzsLPofqCSWHtOAHm2ZDN+DhAS+vsE1V9oRyhOK2UOTAvzve7v7mxh4to?= =?utf-8?q?990dEErcPiN2xswRu99MRVdBYwKnhohfQqzOy5m72cJQwRktLw9soJhwkwXmbypbE?= =?utf-8?q?nvHK/Ju1B6WjcHXc4uprq7T+nb0N5VOftbd0GG+8V51C6qAjv4Dlso4lUcpNR3kzz?= =?utf-8?q?LjnFJAZBvP89jDE46jOadPnUu5TcAz4BK/DxYRbXVXdafotVy6cPypNcPSFCy1U4U?= =?utf-8?q?InsejlvLLGz7?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60433705-e794-48f2-2139-08dbb81eeb24 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2023 08:11:53.7554 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7gGt87grLukGjo4r1pdtqR5fhF26Ifnijn2S1OpfpEgiOrTNrogHM4f1hLFomlEfohJP81tllA/GNlI+f98Ndg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8706 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 18 Sep 2023 01:15:14 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777364731566504387 X-GMAIL-MSGID: 1777364731566504387 |
Series |
gpio: update i.MX93/8ULP and support i.MX95
|
|
Commit Message
Peng Fan (OSS)
Sept. 18, 2023, 8:16 a.m. UTC
From: Peng Fan <peng.fan@nxp.com> i.MX8ULP and i.MX93 actually has two interrupts for each gpio controller, one for Trustzone non-secure world, one for secure world. And they has one register based, not two as i.MX7ULP or VF610. Although the Linux Kernel driver gpio-vf610.c could work with fsl,imx7ulp-gpio compatible, it is based on some tricks did in device tree with some offset added to base address. So actually i.MX8ULP/i.MX93 is not compatible with i.MX7ULP. Last, i.MX93 is directly derived from i.MX8ULP, so make i.MX93 GPIO compatible with i.MX8ULP Signed-off-by: Peng Fan <peng.fan@nxp.com> --- .../devicetree/bindings/gpio/gpio-vf610.yaml | 36 +++++++++++++++++++--- 1 file changed, 31 insertions(+), 5 deletions(-)
Comments
On Mon, Sep 18, 2023 at 04:16:06PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > i.MX8ULP and i.MX93 actually has two interrupts for each gpio > controller, one for Trustzone non-secure world, one for secure world. > > And they has one register based, not two as i.MX7ULP or VF610. > > Although the Linux Kernel driver gpio-vf610.c could work with > fsl,imx7ulp-gpio compatible, it is based on some tricks did in > device tree with some offset added to base address. > > So actually i.MX8ULP/i.MX93 is not compatible with i.MX7ULP. > > Last, i.MX93 is directly derived from i.MX8ULP, so make i.MX93 GPIO > compatible with i.MX8ULP > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > .../devicetree/bindings/gpio/gpio-vf610.yaml | 36 +++++++++++++++++++--- > 1 file changed, 31 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml b/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml > index 59427d97adf5..5243b4cf1235 100644 > --- a/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml > +++ b/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml > @@ -20,6 +20,7 @@ description: | > properties: > compatible: > oneOf: > + - const: fsl,imx8ulp-gpio > - const: fsl,vf610-gpio > - items: > - const: fsl,imx7ulp-gpio > @@ -27,16 +28,17 @@ properties: > - items: > - enum: > - fsl,imx93-gpio > - - fsl,imx8ulp-gpio > - - const: fsl,imx7ulp-gpio > + - const: fsl,imx8ulp-gpio > > reg: > - description: The first reg tuple represents the PORT module, the second tuple > - represents the GPIO module. > + minItems: 1 > maxItems: 2 > > interrupts: > - maxItems: 1 > + items: > + - description: GPIO Trustzone non-secure interrupt number > + - description: GPIO Trustzone secure interrupt number > + minItems: 1 > > interrupt-controller: true > > @@ -78,6 +80,30 @@ required: > - "#gpio-cells" > - gpio-controller > > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - fsl,vf610-gpio > + - fsl,imx7ulp-gpio > + then: > + properties: > + interrupts: > + maxItems: 1 > + reg: > + items: > + - description: PORT register base address > + - description: GPIO register base address > + else: > + properties: > + interrupts: > + maxItems: 2 Doesn't this default to 2 because there are 2 items in your list of interrupts as things stand? Otherwise, this seems fine to me, provided the existing platforms are going to be broken as you implement the software side of this change. Thanks, Conor. > + reg: > + items: > + - description: GPIO register base address > + > additionalProperties: false > > examples: > > -- > 2.37.1 >
> Subject: Re: [PATCH v3 2/6] dt-bindings: gpio: vf610: correct i.MX8ULP and > i.MX93 > > On Mon, Sep 18, 2023 at 04:16:06PM +0800, Peng Fan (OSS) wrote: > > From: Peng Fan <peng.fan@nxp.com> > > > > i.MX8ULP and i.MX93 actually has two interrupts for each gpio > > controller, one for Trustzone non-secure world, one for secure world. > > > > And they has one register based, not two as i.MX7ULP or VF610. > > > > Although the Linux Kernel driver gpio-vf610.c could work with > > fsl,imx7ulp-gpio compatible, it is based on some tricks did in device > > tree with some offset added to base address. > > > > So actually i.MX8ULP/i.MX93 is not compatible with i.MX7ULP. > > > > Last, i.MX93 is directly derived from i.MX8ULP, so make i.MX93 GPIO > > compatible with i.MX8ULP > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > --- > > .../devicetree/bindings/gpio/gpio-vf610.yaml | 36 > +++++++++++++++++++--- > > 1 file changed, 31 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml > > b/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml > > index 59427d97adf5..5243b4cf1235 100644 > > --- a/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml > > +++ b/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml > > @@ -20,6 +20,7 @@ description: | > > properties: > > compatible: > > oneOf: > > + - const: fsl,imx8ulp-gpio > > - const: fsl,vf610-gpio > > - items: > > - const: fsl,imx7ulp-gpio > > @@ -27,16 +28,17 @@ properties: > > - items: > > - enum: > > - fsl,imx93-gpio > > - - fsl,imx8ulp-gpio > > - - const: fsl,imx7ulp-gpio > > + - const: fsl,imx8ulp-gpio > > > > reg: > > - description: The first reg tuple represents the PORT module, the second > tuple > > - represents the GPIO module. > > + minItems: 1 > > maxItems: 2 > > > > interrupts: > > - maxItems: 1 > > + items: > > + - description: GPIO Trustzone non-secure interrupt number > > + - description: GPIO Trustzone secure interrupt number > > + minItems: 1 > > > > interrupt-controller: true > > > > @@ -78,6 +80,30 @@ required: > > - "#gpio-cells" > > - gpio-controller > > > > +allOf: > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - fsl,vf610-gpio > > + - fsl,imx7ulp-gpio > > + then: > > + properties: > > + interrupts: > > + maxItems: 1 > > + reg: > > + items: > > + - description: PORT register base address > > + - description: GPIO register base address > > + else: > > + properties: > > + interrupts: > > + maxItems: 2 > > Doesn't this default to 2 because there are 2 items in your list of interrupts as > things stand? Oh, I should set this as minItems: 2. There are two interrupts. Thanks, Peng. > Otherwise, this seems fine to me, provided the existing platforms are going to > be broken as you implement the software side of this change. > > Thanks, > Conor. > > > + reg: > > + items: > > + - description: GPIO register base address > > + > > additionalProperties: false > > > > examples: > > > > -- > > 2.37.1 > >
diff --git a/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml b/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml index 59427d97adf5..5243b4cf1235 100644 --- a/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml +++ b/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml @@ -20,6 +20,7 @@ description: | properties: compatible: oneOf: + - const: fsl,imx8ulp-gpio - const: fsl,vf610-gpio - items: - const: fsl,imx7ulp-gpio @@ -27,16 +28,17 @@ properties: - items: - enum: - fsl,imx93-gpio - - fsl,imx8ulp-gpio - - const: fsl,imx7ulp-gpio + - const: fsl,imx8ulp-gpio reg: - description: The first reg tuple represents the PORT module, the second tuple - represents the GPIO module. + minItems: 1 maxItems: 2 interrupts: - maxItems: 1 + items: + - description: GPIO Trustzone non-secure interrupt number + - description: GPIO Trustzone secure interrupt number + minItems: 1 interrupt-controller: true @@ -78,6 +80,30 @@ required: - "#gpio-cells" - gpio-controller +allOf: + - if: + properties: + compatible: + contains: + enum: + - fsl,vf610-gpio + - fsl,imx7ulp-gpio + then: + properties: + interrupts: + maxItems: 1 + reg: + items: + - description: PORT register base address + - description: GPIO register base address + else: + properties: + interrupts: + maxItems: 2 + reg: + items: + - description: GPIO register base address + additionalProperties: false examples: