From patchwork Fri Sep 15 13:17:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Shavit X-Patchwork-Id: 140800 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp1396443vqi; Fri, 15 Sep 2023 17:15:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGcRcRK9a/arO6u5nmZjIzo6qMzkWcUVQwZwVPQGZu7pu1+xabhsp1ZFlTk1+1I/QrgtK6l X-Received: by 2002:a05:6a21:8193:b0:148:487e:3e6 with SMTP id pd19-20020a056a21819300b00148487e03e6mr3044737pzb.52.1694823307197; Fri, 15 Sep 2023 17:15:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694823307; cv=none; d=google.com; s=arc-20160816; b=bgvKnPPq1bSjKYYHRKYiqOGbuOONpFXVpYyC5vfq6jbZFQzAoMsEFhqyWFlRjmZqEm XzkoqYmOzOp7tq4Gx9NJZTjufmaQHPNLoqL660Lk3QJLtPeZxcgfovn8QJ3ZRz/huVCN FH3c/iypz61TkbZkiSdJepjIwdWvvNaEEZzT0bEBUCePjkOE39LiMzo0/t22VxgUEWRr x3ZiblgJI2ZAfJGIyrchDkLi7gVRu7Dkl90ymPMKt92j1QYrJIkLyP1SdR1dFcedjlg4 Sd7qSh/NdGudFMrpaxD7Cnl5KUf6cI+HLeELwsMxI7VnFfWbJpnBQSxvgpIjBXzXYhB+ zEHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:dkim-signature; bh=HnObA/kZmhyC99jO+R9W14le1Eiuc2fMp54pXjmpHL4=; fh=yLUVUCpwXxa7JvtfFJiLr61NZJXkXSzdUYJStTN7VZ4=; b=YMybRqBDyJuooElCOtC8bg/vZz35E+In9r+YkfZmmKAo1nd7f9J/cvEqyu9c5mt4VW Jo4XLBt3rOmmEXNjygdqtZQble8p5inO9z3Q81T00nhOQIHcMtUe20re/Sajx3LTnXKE 8pI4V36kp8BM+mX8wHK99PM9tzjlzC71npDI7HuiSOfQoqEzbTCvrmsc5RkqTK7WQhHU fzV+cvmSZtgvDhVcRGEjqfCwA1WCIuc9iEcXbhQaaBgBk12WHGBzLxuqWpuKF7+zwOV2 mMsEl7zARi3bakWjlQu0+ykKTcyFNwNzl4Mhsye7Kvfh9JXl+ZOQ3bNXUxeDDHLMmmtc WNEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=AnDhXPCm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id y3-20020a17090a86c300b00268b5d65afcsi6157522pjv.58.2023.09.15.17.15.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 17:15:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=AnDhXPCm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id A5A6E837080D; Fri, 15 Sep 2023 06:22:13 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235272AbjIONWE (ORCPT + 31 others); Fri, 15 Sep 2023 09:22:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235281AbjIONWD (ORCPT ); Fri, 15 Sep 2023 09:22:03 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DD212729 for ; Fri, 15 Sep 2023 06:21:35 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-d8153284d6eso2590786276.3 for ; Fri, 15 Sep 2023 06:21:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1694784094; x=1695388894; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=HnObA/kZmhyC99jO+R9W14le1Eiuc2fMp54pXjmpHL4=; b=AnDhXPCmr8wwhBU+uUt/0IRBv/P9goCEfChRnROO0HJs2vpUsHQ/z/m7G2GZcPSJTe m9/In2YkLUk7nkzW1m9w24Iq2MgV/5VWG80TwvEGmSXk9UybXDo9cqokwu/M3LitLvik nh9QRnvtUxnAkBR5m4IOO8K9PfalCd1KRoszjmTw1YfiuvACOG/xrRmpk39wmAWE8fFe c3wbmTTdRkCISaFrBmSihlMPP9exE/Wim1rAOdmP3a76P697xQRNZEGPh8kHUmC9YcBk HFzqmtCvtjeGQTAFUNMgZO4UoLBMK0YxLF22+vcFldGYyHx34V3BQxlWK3c1ziRNlNdJ 0Tbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694784094; x=1695388894; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HnObA/kZmhyC99jO+R9W14le1Eiuc2fMp54pXjmpHL4=; b=vtKoydfJa0T7CdhTH+s+MtzWufDDeIq8gUxuzZ4U9cyyqTr5LCY0s3S3trCjSnrcJQ YslOnB3X+zfJMW9zu88wthAIfqldqrsjE4GCGKKmYlAHoknBMGqk45xtkjRtrJguw8YP 8dWQwkBaRTytyDBaZwcouW3EfmejDuYIjCl5gb0xxkaT4NkoH4IcmU6XVjjLLx6r69ju P0b/aLOVWsBqKCib+ZjvrLFbs2V1w5/2hqVzSx/zt4/07gk8ILjr1P5RQma7rVxW+awW jUTM2SWwDsBHGhTBtmHuTbJsrRBSmCfek4CUSwAhAX0QnIGuF6eSJM97bT6lQi/0sXXf CRtg== X-Gm-Message-State: AOJu0Yyd5o1lOzXQPnYyDqftTb2SnltIV4S2BtlAXfX94Wwjy/AxARmM aC8rEqtX7DyFT9GIkmuID/miZE6W9Frc X-Received: from mshavit.ntc.corp.google.com ([2401:fa00:95:20c:47bc:d53f:1c50:a3f2]) (user=mshavit job=sendgmr) by 2002:a25:ab0d:0:b0:d7e:8dee:7813 with SMTP id u13-20020a25ab0d000000b00d7e8dee7813mr34021ybi.8.1694784094306; Fri, 15 Sep 2023 06:21:34 -0700 (PDT) Date: Fri, 15 Sep 2023 21:17:39 +0800 In-Reply-To: <20230915132051.2646055-1-mshavit@google.com> Mime-Version: 1.0 References: <20230915132051.2646055-1-mshavit@google.com> X-Mailer: git-send-email 2.42.0.459.ge4e396fd5e-goog Message-ID: <20230915211705.v8.8.I7a8beb615e2520ad395d96df94b9ab9708ee0d9c@changeid> Subject: [PATCH v8 8/9] iommu/arm-smmu-v3: Update comment about STE liveness From: Michael Shavit To: iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: nicolinc@nvidia.com, jgg@nvidia.com, jean-philippe@linaro.org, robin.murphy@arm.com, will@kernel.org, Michael Shavit , Alistair Popple , Dawei Li , Jacob Pan , Jason Gunthorpe , Joerg Roedel , Kevin Tian , "Kirill A. Shutemov" , Lu Baolu , Tomas Krcka X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 15 Sep 2023 06:22:13 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777151043801749986 X-GMAIL-MSGID: 1777151043801749986 Update the comment to reflect the fact that the STE is not always installed. arm_smmu_domain_finalise_s1 intentionnaly calls arm_smmu_write_ctx_desc while the STE is not installed. Reviewed-by: Nicolin Chen Reviewed-by: Jason Gunthorpe Signed-off-by: Michael Shavit --- (no changes since v6) Changes in v6: - New commit drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c index f9bfa2c8ab1e3..86e4e2df9e2fa 100644 --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c @@ -1091,7 +1091,7 @@ int arm_smmu_write_ctx_desc(struct arm_smmu_master *master, int ssid, cdptr[3] = cpu_to_le64(cd->mair); /* - * STE is live, and the SMMU might read dwords of this CD in any + * STE may be live, and the SMMU might read dwords of this CD in any * order. Ensure that it observes valid values before reading * V=1. */