From patchwork Fri Sep 15 20:11:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 140662 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp1295264vqi; Fri, 15 Sep 2023 13:14:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHh2xzBda7SRDMrDB+C9Dek0XG/ZU+qgOWDIaDDUp13tn+tcBsFKxes/x7cdm2r5xDk1vSb X-Received: by 2002:a05:6a21:819b:b0:11d:4c79:90ee with SMTP id pd27-20020a056a21819b00b0011d4c7990eemr2781228pzb.25.1694808843375; Fri, 15 Sep 2023 13:14:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694808843; cv=none; d=google.com; s=arc-20160816; b=Fd/rrL9QMM4l9lafXGBnY14c/wJ+BH3UahtOfGS+0hnWLRxolz5JbNhbM3Ixqu5/pr 6wXIP3GdsLLPm9cjBt4j7AkaJkbjcZ0L6H0KCL8hPaFuGeQDck0JvqG8kpAiYK8kOC0b xS9Bl5J7B+kE8jsY/615/bD+67xEQC4b1c2Hc+MDamZbrF3KwxefQyQzpzLmlGDbFzwJ Esn00lecuTLbsFRag3bnFg/PcMA5UnYyBqXQ8V1FXK/GcCWviOfASReGZlYYX64NeXRN omPoN1zkiS8niG95aZM0GSB4on2L7Gjtx4K14LByJh5KV8go2QoINUQR/pfnBJ78yxnl DG5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=yYyTWZUt+7ZftFyaVwIF3q4JJIqEmWXzwxBTEgPiLsM=; fh=7ok4PiT281gRg3aoUkWYbSGTl4fG6CYkN8/hyKEUtXU=; b=YW8RIHDW8yTL+i1pCBrVVTzMnJlSaT9PvenZs4Ehrbz9fLJtY/KyNoDw+z74xNfQTt vUFixV6ebvh4TCydvqg1U/7fw9ReuvaFmJC06U99N7rOzLAkY9kDVnAc1u2JGKFCTiTz ulUWv0BYW0VWe/S3Gv95kKoX9JkuyPzNOc+2ubyKELYstn8LdbLAy4zz5Reu2Rq1CUn6 iLbYdKG7qaM3LwtPLUf3iMH8Ea1COJtcwoNkQAgeVDf/J6vhbvGsSk1JQOcvEweAI2Wq POkCsOcCoAaFopFfL9/qk3/Ftkf1Ih+hUSnnRQiQsXUw5IxV+nP4985PuZ9E8Mjdea0k HVRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="Gm/7DNWc"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id y15-20020a056a00180f00b0068a65b26fc6si3974566pfa.43.2023.09.15.13.14.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 13:14:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="Gm/7DNWc"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 3AD11812E002; Fri, 15 Sep 2023 13:12:02 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237221AbjIOULb (ORCPT + 29 others); Fri, 15 Sep 2023 16:11:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237341AbjIOULL (ORCPT ); Fri, 15 Sep 2023 16:11:11 -0400 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82E32C6 for ; Fri, 15 Sep 2023 13:11:02 -0700 (PDT) Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-68fbd5cd0ceso2214545b3a.1 for ; Fri, 15 Sep 2023 13:11:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1694808662; x=1695413462; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=yYyTWZUt+7ZftFyaVwIF3q4JJIqEmWXzwxBTEgPiLsM=; b=Gm/7DNWcj2/iW6rrFbUVD8gHSQ/6HehzILas/KNxRpgl/aL6Iu3R7CMSfcC5fDXIJc H9soduPIXge+ZBNXN5A5mkdIuM/ob4653YU3EQax+ki1lMOEgHmMhSOlOyExPuauxkBr mbgTf323gqvl8qkDPwdpzQGXB0Ct+XxevoE8o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694808662; x=1695413462; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yYyTWZUt+7ZftFyaVwIF3q4JJIqEmWXzwxBTEgPiLsM=; b=Ovjz5dahBGOHkpyQRaNZcIRhhDh++ppIWhfGYmMURSinAGc6RlqHEp+Bxdni3YPoCa s4xS5VI0y2uSx2v0ie4vk5s4RS+zHH9OrZGWjjPI3dNuJlqodfakn/H5teLs77TwNK2d jVTTs+FbO1VdMHiQWJqUZddB6VveeCUhtNs23Mg6B7LYt9QJclAdPXJHIGH2vBvYAA7D CMBPT0fRepSb4l64EFwpsC1KPLbUIEt/XLUBMK0c6gMjSh0TRsCXAgvac0+A8KvJrdm7 1JtmKIJ8d8gCwt0lLDqZqpEJtaZ1PrkWjWV/DyzU3ra6hDdvSb4xc2kg01VRvcy5sf3y nm+w== X-Gm-Message-State: AOJu0YxLK6usN1gnXbFexNKHFHlFSfB511v2rWLln1rsoXFYSqMNWbiH 4rmMZ5aSt374n513MDHPcyowBQ== X-Received: by 2002:a05:6a00:1490:b0:68f:bb02:fdf with SMTP id v16-20020a056a00149000b0068fbb020fdfmr2977913pfu.27.1694808662059; Fri, 15 Sep 2023 13:11:02 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id j7-20020a62e907000000b0068a2d78890csm3314062pfh.68.2023.09.15.13.11.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 13:11:01 -0700 (PDT) From: Kees Cook To: Pavel Machek Cc: Kees Cook , Lee Jones , Bjorn Andersson , =?utf-8?q?Uwe_Kleine-K=C3=B6ni?= =?utf-8?q?g?= , Douglas Anderson , Anjelique Melendez , linux-leds@vger.kernel.org, Nathan Chancellor , Nick Desaulniers , Tom Rix , Neil Armstrong , Luca Weiss , Lu Hongfei , Dmitry Baryshkov , linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org Subject: [PATCH] leds: qcom-lpg: Annotate struct lpg_led with __counted_by Date: Fri, 15 Sep 2023 13:11:00 -0700 Message-Id: <20230915201059.never.086-kees@kernel.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1354; i=keescook@chromium.org; h=from:subject:message-id; bh=Y0/PlP/xLr7YzJo0Pem42u6ey7XJQhlxkmcmoeZ54PU=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBlBLpURuSmxHS+rma4Nt21+50VRplgQeWjMVGy4 5Ert+RNpSKJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCZQS6VAAKCRCJcvTf3G3A JoNOEACPpcWy+gFj1WvLs/yXGVwm+2Gvq0+xBvcHPgh27lwiuRDzyaSDcOH1HyLeRU6CRfj8JfC L8VastoTJD+lFPvY0bcTP7iDYufp7IIIoESFNM9gVcxhi5ePAsPDfWJyrLCRmN/ze8CNV/pLoGt ttmSzhIMWbdUf7h4kr9TxXFKbAZn/67+SINDuTEzNavBEzPV1UQY0+uSz3r+42I9UDJRncQ41SC TRi/+T5EYMMc8Q/kMD6OZDjRg4Wxy15h7MLf3TViTVD3tbcoQKXlLdZOeOp6syYfmxr+CNz2GQC CYoWHi55rW2yxWhHsowo8Qr195hK2GljTdUKfHRpDxK40cwOeKr0Xvrh45ekbZrT7PbOCRuTOfr 4kZ7hXrvwKgSvsaKHqIkfm+CfsN9LKHzZSPByCqVj0tG6sPXaVS5lmKaO6H8n8SRcGvgTKO9HEq x+qfKZUE9fZyJMygR4FDtfUHF0y/ie2TNLTt26thPSkUv/4X3zJBuwXpuKGQaqTq14Mx0etTHRs FE2f5mCgSlugSsepQP+TieqbYz82s0VH6k4XktE9HwXnJAWE81Z74RCWTXwebm/kypoG+63Pb4M 3Mp2+QClrMKmPRax+Vh5UQy6NSAxTWVreR5CG0iBDxV5wJunbLbl2FXVpkwOwATiTDwF3QcASUl JxFT9AM 5o2cLIWA== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 15 Sep 2023 13:12:02 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777135877957695967 X-GMAIL-MSGID: 1777135877957695967 Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family functions). As found with Coccinelle[1], add __counted_by for struct lpg_led. [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci Cc: Pavel Machek Cc: Lee Jones Cc: Bjorn Andersson Cc: "Uwe Kleine-König" Cc: Douglas Anderson Cc: Anjelique Melendez Cc: linux-leds@vger.kernel.org Signed-off-by: Kees Cook Reviewed-by: Gustavo A. R. Silva --- drivers/leds/rgb/leds-qcom-lpg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/leds/rgb/leds-qcom-lpg.c b/drivers/leds/rgb/leds-qcom-lpg.c index df469aaa7e6e..7d93e02a030a 100644 --- a/drivers/leds/rgb/leds-qcom-lpg.c +++ b/drivers/leds/rgb/leds-qcom-lpg.c @@ -173,7 +173,7 @@ struct lpg_led { struct led_classdev_mc mcdev; unsigned int num_channels; - struct lpg_channel *channels[]; + struct lpg_channel *channels[] __counted_by(num_channels); }; /**