Message ID | 20230915201010.never.399-kees@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp1422805vqi; Fri, 15 Sep 2023 18:33:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF7VFPF32II2x1Qu9B7nFRNW+/uYFyRLHCh/9tzabISy/l5JULkLAPFU572Y971gFBYPiO4 X-Received: by 2002:a05:6870:5606:b0:1ba:1998:1d23 with SMTP id m6-20020a056870560600b001ba19981d23mr3516690oao.35.1694828003978; Fri, 15 Sep 2023 18:33:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694828003; cv=none; d=google.com; s=arc-20160816; b=T6KroAf4Ygbu2CTnpuNHyR2gtXBDW05v9GFtL6fNFyXewYiiDSvVeMuE754kfQ7yTN AwfGygn9l/hY+tMWshDar381Fo3QGX7x0idx4QMV7rCAAQ9BdcOjNVHIxiI2aD4nBYQr nyhV9MS3VIvfvw5DRnx7M7j24OyS8C2H+ogB1TOtSQSNO4JBASUPanl2+fFmqgVD3pZN VbM9/Gzsayi0kb0To6NeUWylK3qOTp40zmm+ITMD5yqeV+5tfVyKmyva9RTTcsztm6Sw rHNqVaFv4temqFwemCVmuA5ISJdcBwNqCI6QkZgVU/P2KIg8UT23ZEX4tGsFyLE4H14F qYeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=xnN3gHkGLtoNA2QTGtMAmFrJjm3lWByeM/YOF1ick6M=; fh=r+hzNCJNjZBhBnwT56Rr+FsW7xZvUmXrASgy00ukr78=; b=WQKtY19xYsAgbij4id/9noXaw0aZkg62S3eVmxkolwscsDRtfykjC7oyabZopwPmSY IkfCkoRzjkqoSwRyN1XG5Y+KDst8gXJA+e12R5rYsiA/i5hSUPvygaBhskF02XpYRxoA e1JzBeuSnPnIQcBw4AfnlHs/WSjXXEJnk4QyMYzPaXtJViYdkGk1BXIU81TBqZ8fQeJk e5Z96v111Este1lhuvw8Zi5+cdedGwR5G4VTjJJ8qPoJ97dLxOBsKqFtcT1hE1ZjxoJI yaVoRfsqSXi/OkPXPw4pF+NfHe1PSO785t8gSI2RKhEKOkER5ZPtX8x4KxUn2z6XOLoK kaTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=mxE74pom; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id g25-20020a633759000000b005775e2a7951si4072676pgn.345.2023.09.15.18.33.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 18:33:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=mxE74pom; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 4462A80E6C78; Fri, 15 Sep 2023 13:11:32 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237141AbjIOUKu (ORCPT <rfc822;realc9580@gmail.com> + 29 others); Fri, 15 Sep 2023 16:10:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237133AbjIOUKT (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 15 Sep 2023 16:10:19 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06C6BF9 for <linux-kernel@vger.kernel.org>; Fri, 15 Sep 2023 13:10:13 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id 98e67ed59e1d1-26fc9e49859so2066373a91.0 for <linux-kernel@vger.kernel.org>; Fri, 15 Sep 2023 13:10:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1694808612; x=1695413412; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=xnN3gHkGLtoNA2QTGtMAmFrJjm3lWByeM/YOF1ick6M=; b=mxE74pomv1v1sYJxR9mmyug+RE7jUOCOGYAsO5l2r/1fkUWBuZ+/lfmuInnOh8rMNZ Szxye0kVNj0Q6Pz4iUz9OCcVPJdJMhlAHhrZ2X0kseXgf3/3LQlKjhOLotPS19mSF1i6 Bc47b7UxnHVx73w939+X9nWsWBlmKlCj09oSw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694808612; x=1695413412; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xnN3gHkGLtoNA2QTGtMAmFrJjm3lWByeM/YOF1ick6M=; b=vUr8qzc9mWkYWkTXNgRllcoLLw6fkc/Yld4y0j6Lmwj+bIX0xidwu1T+5hSTMeRaQi nDYlak2P0eoy2mOL185qhnub0QGjFsJb3uPhWr6XUPnqHNc44AUrmlAbN39R8IjNMDCt 7+qMjk50PWs6Gmaa9d3DGmzi2wtpIz6WikGCH31UaMZKtNM+y0DdKq9k4LGVwiuNRXEC dunCcQyyBTXq/xtl0cy0loXqP3Wl2VmtDalGmbSYsO1afGkunKB9KLOdaucrtqmwpO8X F8ukcw1/KoLC6cMIap8UxIOTpJuDoW709oy1Z7pDDVEsGE8uHENGuAbHCYsNWTxDPRAk bKDQ== X-Gm-Message-State: AOJu0YylPa3X3LJXh18adPi4jdm9KqUX+Pw/JTtW+r8ybI+7+al9kzn7 iMV/GHB0esSSKVhY7cLuT/P82Q== X-Received: by 2002:a17:90b:4a11:b0:26b:49de:13bd with SMTP id kk17-20020a17090b4a1100b0026b49de13bdmr2581678pjb.36.1694808612530; Fri, 15 Sep 2023 13:10:12 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id 28-20020a17090a195c00b0026f90d7947csm3649999pjh.34.2023.09.15.13.10.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 13:10:12 -0700 (PDT) From: Kees Cook <keescook@chromium.org> To: Pavel Machek <pavel@ucw.cz> Cc: Kees Cook <keescook@chromium.org>, Lee Jones <lee@kernel.org>, linux-leds@vger.kernel.org, Nathan Chancellor <nathan@kernel.org>, Nick Desaulniers <ndesaulniers@google.com>, Tom Rix <trix@redhat.com>, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org Subject: [PATCH] leds: lm3697: Annotate struct lm3697 with __counted_by Date: Fri, 15 Sep 2023 13:10:10 -0700 Message-Id: <20230915201010.never.399-kees@kernel.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1122; i=keescook@chromium.org; h=from:subject:message-id; bh=UTGtDE2akLSsdTySqF59uiPuDzz1OaDB2cv0YvrcVBc=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBlBLoiuSQ3SORqIHxgEzXMXxgMfoY6915BNtJRe 8pDUP6OpliJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCZQS6IgAKCRCJcvTf3G3A JpbaD/0clVqVUxTw1+EOL/tG6W6RoCiaXFDUaXAPcnNTfob2vfYL2KQkMIjFYbgvOOwd9Z3glI2 b95tMT0bCRoHujNvqOOpI/cdAfKFKxz6SD522+Hhrx1ufi0cCHh2iO0HT7UgOLrW0+Rr/AgXFUm CBjn0TNqarPBQOJNSrk0AoIdpKp4HYfydvM1AhzU8YlakmhAqVlNM3gy2pwnDars5U5ed3p9pBO vj8XrD3iumDh/0eVACxk2cIdIRztZ7sjPNJ/HrzdxEfb60YXjHFqRJAc3BlmNTJhiqCW1mpPDzD R2+WA7VEcEoj0oTFmLEJGeOCjLizRTkRt4AVyMXG//RfLOiwD/FGV8i/9BU0CjArO5KZDbiN6pg XkXTlGgx2udPvdFKjs0oIBd7/sAOPWAk4I+5qLhSkAZkB+PzoRZbGM00+/JYYrAgPD+n8sBi0eD 8VIeXQJvQ1t6NCjw3GwU/5AkySxbWyCL5fMpTHI+P65znv3n2QAYJ2idcC5/x7F9E07cxhsP29l 6eHYhQYkfFHL+F+PQ/t1v2XeXg/v4GqAM1+9N41ktDpoP47HeFBhs9wwVj96wbU0sGgrkBpZJs4 wydpIoJeJ2wJ68fdxIXE0QKuxqbCL4kqgVri1VsGVVia6NO+TM5kM4KVQw67PaY7QgMX8Yj1w72 mgcWtvz G82BZOPA== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 15 Sep 2023 13:11:32 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777138448905698891 X-GMAIL-MSGID: 1777155969121380115 |
Series |
leds: lm3697: Annotate struct lm3697 with __counted_by
|
|
Commit Message
Kees Cook
Sept. 15, 2023, 8:10 p.m. UTC
Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).
As found with Coccinelle[1], add __counted_by for struct lm3697.
[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Lee Jones <lee@kernel.org>
Cc: linux-leds@vger.kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
---
drivers/leds/leds-lm3697.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Fri, 15 Sep 2023 13:10:10 -0700, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct lm3697. > > [...] Applied, thanks! [1/1] leds: lm3697: Annotate struct lm3697 with __counted_by commit: 1a210f7d060854f541be9a613bf942849fd5c0b5 -- Lee Jones [李琼斯]
diff --git a/drivers/leds/leds-lm3697.c b/drivers/leds/leds-lm3697.c index cfb8ac220db6..380d17a58fe9 100644 --- a/drivers/leds/leds-lm3697.c +++ b/drivers/leds/leds-lm3697.c @@ -89,7 +89,7 @@ struct lm3697 { int bank_cfg; int num_banks; - struct lm3697_led leds[]; + struct lm3697_led leds[] __counted_by(num_banks); }; static const struct reg_default lm3697_reg_defs[] = {