Message ID | 20230915200955.never.871-kees@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp1362947vqi; Fri, 15 Sep 2023 15:48:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF9fJMrkDmrVbP5v92llWNemAsFC3rvMfL30iuoHs8BpwEnntOhYwLfNvtwrFn/O0Qm7ooL X-Received: by 2002:a05:6e02:1605:b0:34f:7e1b:a7a2 with SMTP id t5-20020a056e02160500b0034f7e1ba7a2mr4376657ilu.13.1694818125214; Fri, 15 Sep 2023 15:48:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694818125; cv=none; d=google.com; s=arc-20160816; b=DC8M0+7GgTZDWdHlNLX4PeUx3ki/7gadQKBbb2o1ksDdB9b2TRoZCCM8NeAf2liAbv SuxX3FQIS/4m69qB1JyzEDIz21rp4UR4ntD0ctKaoLOFs8P4Ypbx2kqay8rnLbssY+us 8rMLGzUby2yOz306HMvnkwwzDyswkI7rDV6mGzQZ6DMY69MV4RORR8GGS8v69vN6Ghu/ G6ZsQQENYnaE80st2Hp50jgOhKYYPQCsZwQwGMFVtQqEp4bAj+PAHi8GedR+Y6D4IjEA zY9J+bGjadKhkcAUhREtAXF3zkGYaM0fCpw7JGySC6Rm1VVzspkBaqP8vJ4BO+J7igIE 4Mtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Nk/nOdWGEwQoqrorI1M5M4fwyDhM0MyESikBhRPJynY=; fh=r+hzNCJNjZBhBnwT56Rr+FsW7xZvUmXrASgy00ukr78=; b=wOfxwP0n0cs5qg72rdQ+q+t8nOyciJvCN8E87r6OSidQ6BYqAy7vjM/z266+l4p07o MB1E/S3VsU03HH15uL7ELspu+AcedTmTKQiB7DHH4EidqWh1Bc/Svv09GeE5cIPQxQ45 cvtz7mygYUESIy+VaT2HCnPGvh+ZLN0XHk3z1L7iFvouGq06+PYeH5YN4E3JB1zt/MpK Rvy85ghh3TxxtCoxR6ONwfnRBHYtlQGOCTQ3SC3KRT6tkxDm3wH6uY+j2KyttW9MCVvv mGIoATRxkO04H4Gwt9oU/vO4wjyE00kSH6byKMWQN/1SRBlSiOwP0wo89RRpaMx0CowF hfDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=GoXo+IQu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id b26-20020a6567da000000b00530b3b98fc5si3876745pgs.417.2023.09.15.15.48.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 15:48:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=GoXo+IQu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 5BD7A81BDF12; Fri, 15 Sep 2023 13:10:56 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237174AbjIOUKV (ORCPT <rfc822;realc9580@gmail.com> + 29 others); Fri, 15 Sep 2023 16:10:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237295AbjIOUKJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 15 Sep 2023 16:10:09 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFBD610C3 for <linux-kernel@vger.kernel.org>; Fri, 15 Sep 2023 13:10:00 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-68fbd31d9ddso2138857b3a.0 for <linux-kernel@vger.kernel.org>; Fri, 15 Sep 2023 13:10:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1694808600; x=1695413400; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Nk/nOdWGEwQoqrorI1M5M4fwyDhM0MyESikBhRPJynY=; b=GoXo+IQumbCh93lMrBeK1O7HBstJmd6H2DeRANwWPg2DLSCVbkK0gy5yFtTg95KYAg pMZXG8lSp4/RaWR7OQH/CW5NMO7ogkaRm7zZfoFIYXO/UlVv76MWHShxPn2846QbNmQw zzyYtesLZ7KqU7cov2metdcauBd9/3pM8Sr5w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694808600; x=1695413400; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Nk/nOdWGEwQoqrorI1M5M4fwyDhM0MyESikBhRPJynY=; b=rnthfYDZavQCHEZcLssMJrZ4Z01egyydHdkH/MHVakwVcuiTLRUCTbrlcnFiCDQ3BD nE8dfgCZw1nsMXqTRPWTE74OKVDRTIErAqAVBV1wVFnhxgfliE45ZbgaZl2xkXZZNwJ4 jMZO2nAj9feP3eNj5p+gQvB0nMpXXBVqoKI7DYnhlxtc846wQZMvuCb70LdtiySuWMfb JisAoTRHuUu7OGBdrVMeVjNSrjZdxEGmQgSzP/3+mjq/rsfDd1ZpQJn2hf9wH9sSa5Am M2k31uzA0jSuJojf0+/NmVRYYgIC5J08DmTCGKRsiY1c8pvAT7RZz+XzJjR3cw2lSvbl Reyw== X-Gm-Message-State: AOJu0Yx6Gjoy8etovuRKv5Pn0NyNAsGWPnmR9BKpDXmx8KehUxwJJc8c cZi5tmBYJYYl8l0T6KxfP5vmkMiKZyBw/Qxj+8M= X-Received: by 2002:a05:6a20:9193:b0:130:7803:57bd with SMTP id v19-20020a056a20919300b00130780357bdmr3001465pzd.3.1694808600453; Fri, 15 Sep 2023 13:10:00 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id j26-20020aa783da000000b006883561b421sm3321766pfn.162.2023.09.15.13.09.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 13:09:59 -0700 (PDT) From: Kees Cook <keescook@chromium.org> To: Pavel Machek <pavel@ucw.cz> Cc: Kees Cook <keescook@chromium.org>, Lee Jones <lee@kernel.org>, linux-leds@vger.kernel.org, Nathan Chancellor <nathan@kernel.org>, Nick Desaulniers <ndesaulniers@google.com>, Tom Rix <trix@redhat.com>, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org Subject: [PATCH] leds: el15203000: Annotate struct el15203000 with __counted_by Date: Fri, 15 Sep 2023 13:09:56 -0700 Message-Id: <20230915200955.never.871-kees@kernel.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1207; i=keescook@chromium.org; h=from:subject:message-id; bh=AuQmhyKilUvoXwglsma/MaTlIjm+821tEBgc3NFI2G0=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBlBLoTgbluNuEb1ppIxCDVPhVSRR03x+HRH+wGk TRaulMR7I2JAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCZQS6EwAKCRCJcvTf3G3A JmYoEACdL3vVF2NKECABdmlrHoQg7GoQpORVNGSD7el8DAMl2SBhoB09PyPXllokTqK9Wdil8zV zZPIhIGvvUg5oG9N/OMZs9AwUK+CMQNWBG1YsP6za4n0V2TaobBHGIJmhYbBfcYx8ZgAp/bSWN+ TvG9AQpwF5p5NuHck+/CfHURygXTJpYCHco/6y8qBEuIttCFIsytyfX2AQPbQuSvDyoVXAcfxjb iaKhvLFCMqVMnBmihmv6mFyiLZfARMGlfrvAAO642M46+/rMmAx0Fg0TCkLZDrmOwoOXUqiV4kj BJSWoBKjM0hUxo0fXw/Ha5n6uDjLsZ9uXNh6cszZO9Dx1z1bCrAWDkyIKpryVLX4ZF0Xn2MZSD9 y2tF1ooPUPeZHIFOy+ZdXVrUI5Hrcgq6J/85H2zltLR30GOyvTV0cl4wD6vz7T1xZz6JT0jN//L tBY+QCaBMaB2e7UPPX6ivy4npGZRvC93WHEHwYZ7pRXA6aDkDEL91tLzVdMdPeGvNvybrASe8sN vwcfhZhL+89ozR+go0DF8VBaeAuHatpbKYiUM39R3IB+Lvn5c3v8fUxPUHvkZDJEvD0R7u8gsqi tFykTaw5+cMlZFoLrXywMsHcXVrOccqZEt+dOi9SCZnr7CvdKlmoHc+hTlyIOli3HNATBr5UqqP pJ1mVkd qJDn93uQ== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 15 Sep 2023 13:10:56 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777138805164623344 X-GMAIL-MSGID: 1777145610245387817 |
Series |
leds: el15203000: Annotate struct el15203000 with __counted_by
|
|
Commit Message
Kees Cook
Sept. 15, 2023, 8:09 p.m. UTC
Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).
As found with Coccinelle[1], add __counted_by for struct el15203000.
[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Lee Jones <lee@kernel.org>
Cc: linux-leds@vger.kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
---
drivers/leds/leds-el15203000.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Fri, 15 Sep 2023 13:09:56 -0700, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct el15203000. > > [...] Applied, thanks! [1/1] leds: el15203000: Annotate struct el15203000 with __counted_by commit: 1d6d5c03fabeb5e5bb7fd7ac3319a8c5471be9e8 -- Lee Jones [李琼斯]
diff --git a/drivers/leds/leds-el15203000.c b/drivers/leds/leds-el15203000.c index 7e7b617bcd56..d40194a3029f 100644 --- a/drivers/leds/leds-el15203000.c +++ b/drivers/leds/leds-el15203000.c @@ -80,7 +80,7 @@ struct el15203000 { struct spi_device *spi; unsigned long delay; size_t count; - struct el15203000_led leds[]; + struct el15203000_led leds[] __counted_by(count); }; #define to_el15203000_led(d) container_of(d, struct el15203000_led, ldev)