Message ID | 20230915200352.never.118-kees@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp1321296vqi; Fri, 15 Sep 2023 14:10:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHpcPMNbsJY2TbtPn6nDuy+bsch5WfbyFDXo/7PNG+MmqTlD8WeB6a+G5DeuoY+ZKD4+MYH X-Received: by 2002:a05:6a00:14c6:b0:68c:6a77:4845 with SMTP id w6-20020a056a0014c600b0068c6a774845mr3141994pfu.12.1694812214333; Fri, 15 Sep 2023 14:10:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694812214; cv=none; d=google.com; s=arc-20160816; b=ihoZmKcAsnn/SSJ93WrBt1qAAdGfYZ5WBuelmPEur471ljKq1DLv+Hf4SUFsiASMw2 AH3oj1IDM9+nUfOghrxbX5N3KmnGXuxJSfd0SI47BlnLqqW9ClA7yywnq11H7trFKR1D w7rYTyQq09gmUQsQxaQxkgAJ0gXRnb+JuJjJw+TraY3xw5yTsMm7Lw96GzVwgNXQxlVn piFag2Qkpjg+GZJvnex+lcZgRT6nxCftD1T0sMQuwU/vyraJl9mhS6H1iazWGf9ZgXLq ZKKSFYVwqMXl19LsD+t2t2Gs31NdAMMs56RhREJeoXCwaFWceu60zw9gTlwD/Oo6gD1D QLVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Yl8emKrmc/KfUuXy2E3tRAOG2iLFA4b4JMVH2AzKln0=; fh=8usbhTyLEs+UqinFzzonmw/C95jphrrnd4BsKDJ2VSc=; b=pE5d338PtDrmRXrC5zrzwFzJX+TswDbTWExxPAM3iAu0KG/xkRs2PWTs/elA0Yo+Z2 qK/PwkgOR2wP036BfTehhGKezJFAR2Mzhfy+Df6JE+uLRupc1hBOyaKu7aM2krtew+r+ le+ytDUIEnEt1lTalvDvFRPnWB2kkl3YWqX47IxQ4JphXufzeidaz7lCWokBL0AkZIy0 Hlp7M32TtDSgxltLt/pXX4yUeXWWALLcVmFq+gEj2DtO96yML0we7I+XvRNlrhGkGkwv aG4Kv0eNIutkB4+d/kyGjXArDks0F45T+XLomJJED1XXaRJjvMMlL+U9TjtajJvP2Hhf yAvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=C9dZmy3w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id ea13-20020a056a004c0d00b00686baf235easi3844628pfb.258.2023.09.15.14.10.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 14:10:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=C9dZmy3w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 41BE180330EC; Fri, 15 Sep 2023 13:05:01 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237112AbjIOUE3 (ORCPT <rfc822;realc9580@gmail.com> + 29 others); Fri, 15 Sep 2023 16:04:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237086AbjIOUEA (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 15 Sep 2023 16:04:00 -0400 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56469211E for <linux-kernel@vger.kernel.org>; Fri, 15 Sep 2023 13:03:55 -0700 (PDT) Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1c337aeefbdso23495005ad.0 for <linux-kernel@vger.kernel.org>; Fri, 15 Sep 2023 13:03:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1694808235; x=1695413035; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Yl8emKrmc/KfUuXy2E3tRAOG2iLFA4b4JMVH2AzKln0=; b=C9dZmy3wuLpOhsdwWwAGaoNiyrWDYFOotOg+CrPiTqjOeAxiqm5NoE2m7bWbl2x/5t UpoCaHvtUKpCUI63V2B9Oz0iWGNCRlHVbeH7AbRPpo4Arfy8sEJBNkdAnGQ5zNtnTcc9 ybth8bRfd/P7fimWvpwlRJGNzbukmtcqvt6Tc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694808235; x=1695413035; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Yl8emKrmc/KfUuXy2E3tRAOG2iLFA4b4JMVH2AzKln0=; b=lY9iDy7dAvDQeri2ALIP1RNINKcCeYp1lmn5qcfLduuwaHx3F8TQVsdhtxmQIvKsGC eYo5p+Zn9Dfb4pUT2pBRoEkhS+eORHg5AiggQKg2mb+Jj3L6TkpKio11Hzai27/0H9/g ljXOPCCh11YHZv+AkCcn79qpvdwvnMGK+Aw6PsTMOfiHVtyCKevEgX8sN+FbwZINBn1c nKcc8mpyX0gMzMzDKuYcNnyRj4FXxrRirS9i1dHxz9aLd9rWeFMVF9cq1C637t4EkY+K SlFNqDTwZX8ycgF0/d4HGxTwS0uKs37w56tqYdIuF6MVHWKkcgQBN3WhJ+AczQfN6pJB agoQ== X-Gm-Message-State: AOJu0Yy1HOfys/voP6WFUyjASopYXaCe2zdXzwlwGdiY9/GFIqeO5eW6 IfOsgzxeFbnazyJZfPzMwuW8ww== X-Received: by 2002:a17:903:24e:b0:1bc:6799:3f6c with SMTP id j14-20020a170903024e00b001bc67993f6cmr2435450plh.35.1694808234867; Fri, 15 Sep 2023 13:03:54 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id jc19-20020a17090325d300b001c4247300adsm2521123plb.276.2023.09.15.13.03.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 13:03:54 -0700 (PDT) From: Kees Cook <keescook@chromium.org> To: Alasdair Kergon <agk@redhat.com> Cc: Kees Cook <keescook@chromium.org>, Mike Snitzer <snitzer@kernel.org>, dm-devel@redhat.com, Nathan Chancellor <nathan@kernel.org>, Nick Desaulniers <ndesaulniers@google.com>, Tom Rix <trix@redhat.com>, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org Subject: [PATCH] dm: Annotate struct stripe_c with __counted_by Date: Fri, 15 Sep 2023 13:03:53 -0700 Message-Id: <20230915200352.never.118-kees@kernel.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1103; i=keescook@chromium.org; h=from:subject:message-id; bh=vOEysGbU/jyBebBE5nHunAiTa99HsxKjPw7GE7dUesk=; b=owEBbQKS/ZANAwAKAYly9N/cbcAmAcsmYgBlBLip2KpsBUO/hCQjlCTSWf2rc87i8jMHzNeSE Q8UaPFCOvWJAjMEAAEKAB0WIQSlw/aPIp3WD3I+bhOJcvTf3G3AJgUCZQS4qQAKCRCJcvTf3G3A JpnJD/44Xz/i8BNUv0MMMNLHpqKkkGXhsnX3/oK7sG9t5GcOmsd2TGoGmk+Mi0lfFizMo1Wu4rd D1aP5qTGM3Ufj8/4nIvQUnuJ3fTsDiuJGvyZidtO2mhY4z0sDqDFwq0iWQQEec4kD+wxSGPnSd3 s+RmtXzI2BuE5DXDc1Y9jCZbMi9sQqJJq3Dp+l+vOGr+ovc/TSK4hL5tLKy3x4pyR+OL9xZbp5S OcnrtzlmHhv/+gzQh1TdQXFXKiZP0JpGye/uLGzm/JLBBh4O6BUf1WqE+JuZJXdyxm9IzsWyi6m VpTxDakDYjz3OY5vNgdASvDfGeA4tlf0faus+ogRlMXiyFWCpYxfiPCgLjLKd8j/qDY6fNFrfn2 fMopN7jzzjuDuQKwLvwo0WreafHn/87Npf0vrNSgxxVSIDcn1xagASs2Dc+tzhrhaovAV0vg/b2 /1k2Oi2JiXX6i+wNfGmUIBmUJC+5EggoLK9bSp8Krg5X9TWkzK5BWxIsEIFy4fChFtGDfPx/zrl 6RE1NFzGHIuHI/9gkAs+Pd7SzewGh/0sFbi7aEB4mh9lO+nc4NikCrdZsu9L1BNxFCjwPsGL/D0 CMh9MqgB/q+43pEGchjFoK3DQp3hz1cSDRUDWidEdAIjizb1sw6N5ohw8hOyYZ7YWMl6Jk/Zdfv 1L0V1+E HhwIYZFg== X-Developer-Key: i=keescook@chromium.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 15 Sep 2023 13:05:01 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777139327487629464 X-GMAIL-MSGID: 1777139412879561163 |
Series |
dm: Annotate struct stripe_c with __counted_by
|
|
Commit Message
Kees Cook
Sept. 15, 2023, 8:03 p.m. UTC
Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).
As found with Coccinelle[1], add __counted_by for struct stripe_c.
[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
Cc: Alasdair Kergon <agk@redhat.com>
Cc: Mike Snitzer <snitzer@kernel.org>
Cc: dm-devel@redhat.com
Signed-off-by: Kees Cook <keescook@chromium.org>
---
drivers/md/dm-stripe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Fri, 15 Sep 2023 13:03:53 -0700, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct stripe_c. > > [...] Applied to for-next/hardening, thanks! [1/1] dm: Annotate struct stripe_c with __counted_by https://git.kernel.org/kees/c/052b7cba53b4 Take care,
diff --git a/drivers/md/dm-stripe.c b/drivers/md/dm-stripe.c index e2854a3cbd28..5e70f5ae394d 100644 --- a/drivers/md/dm-stripe.c +++ b/drivers/md/dm-stripe.c @@ -44,7 +44,7 @@ struct stripe_c { /* Work struct used for triggering events*/ struct work_struct trigger_event; - struct stripe stripe[]; + struct stripe stripe[] __counted_by(stripes); }; /*