From patchwork Fri Sep 15 15:57:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ilpo_J=C3=A4rvinen?= X-Patchwork-Id: 140774 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp1385164vqi; Fri, 15 Sep 2023 16:45:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHEMFk53lF6s08WcMEY+sWbz8tE8A26j4vkKsEUc2t4gmwooY3Ydo7BzC3gey9Vh7Z9eOHl X-Received: by 2002:a05:6a21:a588:b0:140:6d68:ce07 with SMTP id gd8-20020a056a21a58800b001406d68ce07mr4512314pzc.52.1694821522021; Fri, 15 Sep 2023 16:45:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694821522; cv=none; d=google.com; s=arc-20160816; b=eeqAIK7FyocgWbJqtnETYnOq/0vi4sk8Ze9uU5uKJhs3Bl4C0q26UBG9f7YG1zDgWl /w8Za4ABK/15pO48qHG4YQreMhVJQoV8itEY4vFplCsjQndkW25BHbco7mtkqgO4mkf2 whfkAvL0PTEgMx9Xb2kPS2GwiqxiQOw4+kds4uVvS2lMzn1ryCO3fDa1w2+AnYefo761 WH3BRj/LnJ6QPoZGl27AkVvcE/uDrlt8QX+Gjx4AFFzPSv9eERsWvge/dRs9IATneZAz 9q2qsxyiAnVfKdALgE3SCDwM+BbYGk5ur6x3bTpjo9CutBx1VRcSlbZ45636nX7FYCQ+ butA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0ACBD4bHtmkueZkDaIN4peb61KBakapF2Phd9SW4OHk=; fh=hZLmt6afxROhcWMieefqgqDfx+oilLKHrk2svuRRdTk=; b=JBxBAhk+xrVET0GnYL7AT0OhxbNlb+s0V6PDHyOvHmJEHRfJStCYdx3L7UW6GTTn6G mnjLKcV2U37a7hunTwEvmRXXOJgYVxKOI4f12nwzXFIQFCPR/trt2Ra0T6TcZTG1amCY MHzEY88MjstAvTQyHzk64laj4aQWDgHNmUcQkdZkPSXRsF8I/2mkQToD4ldU2DIJr3Ce UQlW+186OYvPN4k5eHPel7Or5vKD1Cfo6suhwCy+PzKKkR1FyBisaY2Y5M4ndsie7Muz d3YbYBY+f/5p4S9sajoO+OS0sZmYktzv7yt3eXMn/e+IETSa34m8IREFpSBFvx1HytQN WX1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=B3kJOAr3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id go4-20020a17090b03c400b0027189fa5057si3907750pjb.120.2023.09.15.16.45.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 16:45:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=B3kJOAr3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id B911D832519C; Fri, 15 Sep 2023 08:59:10 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236386AbjIOP6o (ORCPT + 30 others); Fri, 15 Sep 2023 11:58:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236304AbjIOP6S (ORCPT ); Fri, 15 Sep 2023 11:58:18 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E2C610D9; Fri, 15 Sep 2023 08:58:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694793492; x=1726329492; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=oC+J51tGvN01jsQNJsaVvoKnBvB9vBS5Yv0KL0IOWys=; b=B3kJOAr3XSyI4Wieru29LTbHaM12uI63wHR1NMFu3gOb6jJiP8jvgi5M 8ZvYSbjaH/LDOgcXXXz3z16/MAO6z+mOzwjQotduM+mum9HVh5LH2Zzzn nmVXj8BSSqqT3N9piWadqxMEVfyjY+G24apnubCgO75XINLZ+0DIXyZRz B2UyURsHYYG9EZCaKbQBDx0xqXnA1YCH2gW19kMM9lam1g85PUcfkqVZM 860emiZZ1YjHJ0U+Pooktw55x0EHPdiCTGuf6u/x1KYzGJEzx1jAU0cri UylFAH54TitS37FaM61ljGr7VsDdEAUczlXPCr9yDMfRs8J0tmWB1Lxyy Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10834"; a="369594629" X-IronPort-AV: E=Sophos;i="6.02,149,1688454000"; d="scan'208";a="369594629" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2023 08:58:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10834"; a="745036695" X-IronPort-AV: E=Sophos;i="6.02,149,1688454000"; d="scan'208";a="745036695" Received: from srdoo-mobl1.ger.corp.intel.com (HELO ijarvine-mobl2.ger.corp.intel.com) ([10.252.38.99]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2023 08:58:10 -0700 From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= To: linux-pci@vger.kernel.org, Bjorn Helgaas , linux-kernel@vger.kernel.org Cc: =?utf-8?q?Ilpo_J=C3=A4rvinen?= Subject: [PATCH 3/7] PCI/ASPM: Return U32_MAX instead of bit magic construct Date: Fri, 15 Sep 2023 18:57:48 +0300 Message-Id: <20230915155752.84640-4-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230915155752.84640-1-ilpo.jarvinen@linux.intel.com> References: <20230915155752.84640-1-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 15 Sep 2023 08:59:10 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777149172458020007 X-GMAIL-MSGID: 1777149172458020007 Instead of returning a bit obscure -1U, make code's intent of returning the maximum representable value more obvious by returning U32_MAX. Signed-off-by: Ilpo Järvinen --- drivers/pci/pcie/aspm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c index 06f175d8dee5..4cd11ab27233 100644 --- a/drivers/pci/pcie/aspm.c +++ b/drivers/pci/pcie/aspm.c @@ -9,6 +9,7 @@ #include #include +#include #include #include #include @@ -279,7 +280,7 @@ static u32 calc_l0s_latency(u32 lnkcap) static u32 calc_l0s_acceptable(u32 encoding) { if (encoding == 0x7) - return -1U; + return U32_MAX; return (64 << encoding); } @@ -297,7 +298,7 @@ static u32 calc_l1_latency(u32 lnkcap) static u32 calc_l1_acceptable(u32 encoding) { if (encoding == 0x7) - return -1U; + return U32_MAX; return (1000 << encoding); }