From patchwork Fri Sep 15 12:31:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dhruva Gole X-Patchwork-Id: 140555 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp1194784vqi; Fri, 15 Sep 2023 10:06:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFyba2hYbBpO9zbN81924CJqNB+ztNyp5tweIXSuE80VRnnYXuplt+YnE9InH1nGqphRrKp X-Received: by 2002:a17:90a:f312:b0:273:e42b:34c1 with SMTP id ca18-20020a17090af31200b00273e42b34c1mr1946760pjb.42.1694797577379; Fri, 15 Sep 2023 10:06:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694797577; cv=none; d=google.com; s=arc-20160816; b=dGnARS65PN3UWUl4CkYCaLspdv3PIqtXIzfocqOmZgfaQjIAW1s7xSUdtHOtaAKVxW hqDqKV7hbGBDSBewYurFg3rlXOA8s60iK13XrkGS7A4nK40MCvC9R2/oF1ZmXsjGJ5ds GLAbMrVhtpbUgiCW12R4yiKt/RTxwqXmx+n2Lz5Eh9VrQ7S6GtfU9TFYMu0hSOrhyA4N cYKFW6EGDn7r2kmNF6090vy1hmgbEQJiGjP7K4x2ZmXopQkpbZu+2hDpffQgxPycudZ7 GJHNVdT9e7hNa2BdA9XRvwoV4hm3sEyVbliHpZXAXLrz+k/cpDe4bfsBFwJAWEuYLaqE 93gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=BRW8EyUjjI/j4vI+qIaQK8OauJ8jbUUuCaWiIex1n10=; fh=TWPTJZL7PHSOEEMVTqGIH+uKAiNNCdHaFG7dBC8BuJw=; b=daJahjecCH91COLNRQ3R1Ed20zbP9aSqN0jaLYI4bbSdv2vWp5luY8hq2i0Pq74OxW 1cksz8sePG/Yhi8Nk7Iqu5hUDoJ38H1h6qA+6o+G9gh4sZp1RWhST/czhBLoBphrCZBe MWrXv+JCfYm7xOKGDAhRhG6CoIXf9CJYBCzO0x/RLG4r1gyNRXzhyXk3+e7J0UdaUzN5 MFiBmPFk+7eWYDXuBqjFKxbd73R9eQ3sFwRlPQBWMInKeKEJJMT4jHLlWdK46RdMXw9H BavQPmL230cjD/FS+jbtpOnO3xWJOrYrfr8YTfOjndtcN9SHtACJJ+vzhftrXLE1+DW8 T1YA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=bb2fptpe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id i3-20020a17090a64c300b0027198088485si5674420pjm.45.2023.09.15.10.06.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 10:06:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=bb2fptpe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 4195C828EC1C; Fri, 15 Sep 2023 05:46:52 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235034AbjIOMqk (ORCPT + 32 others); Fri, 15 Sep 2023 08:46:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234979AbjIOMqi (ORCPT ); Fri, 15 Sep 2023 08:46:38 -0400 Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B7D02D51; Fri, 15 Sep 2023 05:46:01 -0700 (PDT) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 38FCjtxX024939; Fri, 15 Sep 2023 07:45:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1694781955; bh=BRW8EyUjjI/j4vI+qIaQK8OauJ8jbUUuCaWiIex1n10=; h=From:To:CC:Subject:Date; b=bb2fptpeTtxGKySsY07ibStDdulLhF4a78Hc1m2NH7IR2YBxwcn0FOGzUgmyOQwdW 4AFHTApmAKgx+wyOfJNMEmtfqEER5ltNeGGi9GVC6ZoYdSXWbjAI+BPPa/LbP4ofVu hM5CJ75xWpRHeNbzrSmQfJ6eQKo0JgXKjvWBlb/Q= Received: from DLEE112.ent.ti.com (dlee112.ent.ti.com [157.170.170.23]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 38FCjtRp100203 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 15 Sep 2023 07:45:55 -0500 Received: from DLEE106.ent.ti.com (157.170.170.36) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Fri, 15 Sep 2023 07:45:54 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE106.ent.ti.com (157.170.170.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Fri, 15 Sep 2023 07:45:55 -0500 Received: from dhruva.dhcp.ti.com (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 38FCjqOc016962; Fri, 15 Sep 2023 07:45:52 -0500 From: Dhruva Gole To: Mark Brown CC: , , Vignesh Raghavendra , Dhruva Gole , kernel test robot , Dan Carpenter Subject: [PATCH] spi: spi-cadence-quadspi: Fix missing unwind goto warnings Date: Fri, 15 Sep 2023 18:01:04 +0530 Message-ID: <20230915123103.2493640-1-d-gole@ti.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 15 Sep 2023 05:46:52 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777109105226511639 X-GMAIL-MSGID: 1777124064763685778 Fix the smatch warnings that were recently introduced in the runtime pm patch [0]: drivers/spi/spi-cadence-quadspi.c:1882 cqspi_probe() warn: missing unwind goto? [0] https://lore.kernel.org/all/20230829062706.786637-1-d-gole@ti.com/ Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202309140543.03dMbMM5-lkp@intel.com/ Signed-off-by: Dhruva Gole --- Link: https://lore.kernel.org/r/20230915123103.2493640-1-d-gole@ti.com Tested locally using the following cmd: make -j32 ARCH=arm64 CROSS_COMPILE=aarch64-none-linux-gnu- drivers/spi/spi-cadence-quadspi.o CHECK="smatch -p=kernel" C=1 W=1 drivers/spi/spi-cadence-quadspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-quadspi.c index 4828da4587c5..e04f257c1067 100644 --- a/drivers/spi/spi-cadence-quadspi.c +++ b/drivers/spi/spi-cadence-quadspi.c @@ -1879,7 +1879,7 @@ static int cqspi_probe(struct platform_device *pdev) ret = devm_pm_runtime_enable(dev); if (ret) - return ret; + goto probe_setup_failed; pm_runtime_set_autosuspend_delay(dev, CQSPI_AUTOSUSPEND_TIMEOUT); pm_runtime_use_autosuspend(dev);