From patchwork Fri Sep 15 18:28:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Stitt X-Patchwork-Id: 140730 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp1352633vqi; Fri, 15 Sep 2023 15:21:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEbiUoKjryrSHhM7De8JOyDVRPu+5YvVjmkVLDI5N8/HpJFzBtvSni3WvlQ+8wMu/hX8q0d X-Received: by 2002:a05:6358:618c:b0:140:f6ab:b11e with SMTP id w12-20020a056358618c00b00140f6abb11emr3613497rww.28.1694816504787; Fri, 15 Sep 2023 15:21:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694816504; cv=none; d=google.com; s=arc-20160816; b=rXUo5jKQHV+E3onweFNyuyG3oY1P2/pHazM3jryg9mli7azXntXahylJVGapFnUmGV qvMNk/PaLUXS0Zl+ltzSS6bqYk79t+gNAZimjS9I0e/upHkAN8Ywe58CLUTZickZGFPT nOVxPujqN1H8QoQwJNV5Qk8ViJYD4PkTtb/hSK/xEfcf697BPVOjJWR1MKxuDJA2/D3P U5ibqqi04ZR0QDrU2088Acr2hbbdRaECfOdiXSYPQIabpB6gTluosuAu0j4HXloa4hQf 6xVkWelWD4WGDshVcCc1YeBmdxCeJYIHBYCqt1EE26oHLhlXoPmZbao8I0I3vM5Qpa4J gWNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:mime-version:date :dkim-signature; bh=Y1TNhbabomfqxi0sSxeEOnLpESqLvSHW6eZcfpfNAeo=; fh=lUNFC9BzGw/skX17+P6SZfiEhaPS211NV0E86C9JC/M=; b=BJ9pUBuOuhNPfouptidm4IcHnjMq39yjWf+sT0cu9MgfMuxXnDqg1VH8ACcQr2MSTy ciKF0udTncwiae/2ebqugAWckcN9l9ns2DdtdxzufKTfFcRg2erqD2iSyIJXJ6/qJb4c 0H2OpBQnZew79qxkkzCaLIY+vmBb8Pg4jFtgkRbGDpwo5quOYKSwCC++vFhkQMAmsTuy IYiUVwXMYNl6+YTM3wr0idNBDZDdRoiQyBg50JacJfhHBVTFRU+MoB2lzgaDimjE2SmM r43RvIpWraOh08e2Wv7gH7qzOwureHJKuCDmX9XD+XKiHixzMd0XF+Ylf7XYi7D3dYeK 74tw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=shsz4Nxq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id cn4-20020a056a020a8400b00569466198c3si3661740pgb.751.2023.09.15.15.21.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 15:21:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=shsz4Nxq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 782FF809E8BC; Fri, 15 Sep 2023 11:30:25 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234869AbjIOS3s (ORCPT + 30 others); Fri, 15 Sep 2023 14:29:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236095AbjIOS3N (ORCPT ); Fri, 15 Sep 2023 14:29:13 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85DD12D49 for ; Fri, 15 Sep 2023 11:28:49 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-d815354ea7fso2799261276.1 for ; Fri, 15 Sep 2023 11:28:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1694802528; x=1695407328; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=Y1TNhbabomfqxi0sSxeEOnLpESqLvSHW6eZcfpfNAeo=; b=shsz4NxqypQhdtRZb+2ArAjNbNsbC9gJdHgjUlcjlN6hQ2Y5Gs7VC+jF9I4AI2ZtaO rU+24rkLSE7ZJCtKfNaIMfzJ+nPRThW2Tne8lLZrK0Tkj3A+gLVzkNyv0GoCKFSI0q86 kl8c2XpNYCi6dR+LYezrVhxnCSEJb4882hnyfBUNKNL63neV3yzar/YX+b92IHhg1WOO ZoKrT759x7DqOQl90FhdqMywSRu9nOf3284JDr0bGFMhIHi+pj3Z0hfXg6uLeiemqFv/ NAdoQgtJ/gDIFb/qJNnph4CUzV/zomN8AG2PKnlvN86GP0uTF/TTjjCceEV5+0UGsPIa 9VQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694802528; x=1695407328; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Y1TNhbabomfqxi0sSxeEOnLpESqLvSHW6eZcfpfNAeo=; b=VJOaxc0GOVGMmyVW+9pbbtdA4T1bv+PygR4haCbVPlFnu6Mpeb3bqjxvXG4Ki7skub ZtvYyK9LgyHfJbPiJ3EN4Lo85EPK9r+5I0a8lUR9zUiNPzTY4kGQlnDYBV3bK7cCHR0O 587Yb+Xr28U9vXdjBaBpEt4ALZMWnwhB18R/LGSzLH7+ZEyrjg3EVjRDZOi+OLreS9wi 5AaLj61zQ/J/Vr7VPyMEGKlVF0qBrkKfVv4K+WgfjgS+ru6j+jFOa10uVSXG+K8t1SyP njxq2dpKnM9hAkRIXKgPf54sZag+d2GZyIq4ywL5GRjpI45qd6OXyH7jWY7JIZkTQtC0 KICg== X-Gm-Message-State: AOJu0YwP2nmAxaNsSX//zX3UGaMDH/3EUamL/xcpcJDAYnThzUnSMw1o 4PZk/xvPb19aUuVrhJflQ0DeSJWVVrmxQfeoEg== X-Received: from jstitt-linux1.c.googlers.com ([fda3:e722:ac3:cc00:2b:ff92:c0a8:23b5]) (user=justinstitt job=sendgmr) by 2002:a05:6902:4cf:b0:d7b:92d7:5629 with SMTP id v15-20020a05690204cf00b00d7b92d75629mr61024ybs.8.1694802528783; Fri, 15 Sep 2023 11:28:48 -0700 (PDT) Date: Fri, 15 Sep 2023 18:28:41 +0000 Mime-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAFiiBGUC/yWNQQrCMBAAv1L27EKaYGr8iojUdG330CTs1qqU/ t2gl4G5zGygJEwK52YDoZWVc6rSHhqIU59GQh6qgzXWmdAeURdJsXxwEF5JFKfXnBOW+f7UP28 xC2HEk+2C9y540zuouSL04Pdvdbnu+xfaojGoegAAAA== X-Developer-Key: i=justinstitt@google.com; a=ed25519; pk=tC3hNkJQTpNX/gLKxTNQKDmiQl6QjBNCGKJINqAdJsE= X-Developer-Signature: v=1; a=ed25519-sha256; t=1694802527; l=1589; i=justinstitt@google.com; s=20230717; h=from:subject:message-id; bh=ipgUK5swse4talncYcp6ZaLyjV9MF6ZXeEtQq4t0z+U=; b=yh6ji8oppxJbHWrSSNWzb+891+/79MW/r+6+gbkV96zGC/G3BpGuzOqrL/9EaMbaa54XhF4HE AIU7cylhy+6BOoljr90F/91Mh0SiWTLQa1nb8q+u8TQGrMeqSEQFENN X-Mailer: b4 0.12.3 Message-ID: <20230915-strncpy-drivers-hwmon-pmbus-pmbus_core-c-v1-1-fca2cbca41ea@google.com> Subject: [PATCH] hwmon: pmbus: refactor deprecated strncpy From: Justin Stitt To: Guenter Roeck , Jean Delvare Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Justin Stitt X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 15 Sep 2023 11:30:25 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777129796298486051 X-GMAIL-MSGID: 1777143911042712430 `strncpy` is deprecated for use on NUL-terminated destination strings [1]. We should prefer more robust and less ambiguous string interfaces. A suitable replacement is `strscpy` [2] due to the fact that it guarantees NUL-termination on the destination buffer without unnecessarily NUL-padding. `label` is zero-allocated and as such the NUL-padding behavior of strncpy is not required here. Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1] Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2] Link: https://github.com/KSPP/linux/issues/90 Cc: linux-hardening@vger.kernel.org Signed-off-by: Justin Stitt --- drivers/hwmon/pmbus/pmbus_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 3669558bdf354cd352be955ef2764cde6a9bf5ec change-id: 20230915-strncpy-drivers-hwmon-pmbus-pmbus_core-c-8279663960a3 Best regards, -- Justin Stitt diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c index 1363d9f89181..dcc8b12387cc 100644 --- a/drivers/hwmon/pmbus/pmbus_core.c +++ b/drivers/hwmon/pmbus/pmbus_core.c @@ -1394,7 +1394,7 @@ static int pmbus_add_label(struct pmbus_data *data, snprintf(label->name, sizeof(label->name), "%s%d_label", name, seq); if (!index) { if (phase == 0xff) - strncpy(label->label, lstring, + strscpy(label->label, lstring, sizeof(label->label) - 1); else snprintf(label->label, sizeof(label->label), "%s.%d",