From patchwork Thu Sep 14 14:08:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Fitzgerald X-Patchwork-Id: 139711 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp495928vqi; Thu, 14 Sep 2023 10:08:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFUV3q4FHhPw0NvJwGWakGDHRNuzsxNavHhRSDy7LA3z/SV1J65nx064QUqzE+5CJj+tb+l X-Received: by 2002:a05:6a20:9714:b0:14c:daa9:5e22 with SMTP id hr20-20020a056a20971400b0014cdaa95e22mr5445846pzc.45.1694711326794; Thu, 14 Sep 2023 10:08:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694711326; cv=none; d=google.com; s=arc-20160816; b=hMm/10AUFKihGv8yVwV0gYsZAaIltVgUY1UUv6B8LcK1OOLwdqPU0ElZD8x7ucWc0U /i03y+lBYwFvBgc0qWl0bru+jP+uhLvQVeODBfVuwFH93QKSo31hlcKlFxL58kwY1iFl XMN2HO3sHSzeXb10rkyQQitfgeJYkyDI6FyvykIGyIy4W/gbIzV2MyF71z1FEeZcaZcr uW/eBsJDsywX00DoXx3yXI16AD15v91mWI3BozYD8PVufimqeGLeVmoL4MgYzC/2Z8wo Rj1Xq4lSrMwfoFtJhpoeaL2okqVkzyvy77rJn0BBsI7Tnc2Dc1C1VnV5/OrMRuHB7LWG RSxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=4HgihXxVrhiu2Qr7o1AFiNL6OECM0mNgN7UuJbdBwcg=; fh=SyhPsGKNo/JGCZgOgs8oor82YQAWZ9kc5f/0PFOAxm0=; b=Q7mkWyN9OaQTT9Saphm5b5mr4g8Si/mMsQNy+bSwkruCmvD+FUeVoqsW16a2lytFg3 dEn06pUXev5rBI1nncVuF1hME4EIHvTLJekM1YF8YS5gHygAq10wtCcl/Utg4D3WleG6 VZj3UnHdCte8XbMMzmZ/2nXg8xLikwykXcmWyIFP5J+mmSnMED/W4kbIOZu5P/e2ttjZ 7kh6x5iMT0maEt9KGTUW7oP6GOEoaQwkJOsORzTb0BTZpb80WMaoZLD9sx+EhyvIjjgW feHgnKWU6O+U3TkGCvCJr2jUax5Q7EfTfvf0MZWoQbhFNJzMgZQMkK8pFlPFCc6f5bQw xw2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=LxEo36sU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id z3-20020a633303000000b00573f9d916fbsi1860559pgz.784.2023.09.14.10.08.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Sep 2023 10:08:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=LxEo36sU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id E908A84CA7EA; Thu, 14 Sep 2023 07:09:08 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239511AbjINOJJ (ORCPT + 35 others); Thu, 14 Sep 2023 10:09:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239491AbjINOJI (ORCPT ); Thu, 14 Sep 2023 10:09:08 -0400 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F1A91BF8 for ; Thu, 14 Sep 2023 07:09:04 -0700 (PDT) Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.17.1.22/8.17.1.22) with ESMTP id 38E3ihQq012982; Thu, 14 Sep 2023 09:08:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding:content-type; s=PODMain02222019; bh=4 HgihXxVrhiu2Qr7o1AFiNL6OECM0mNgN7UuJbdBwcg=; b=LxEo36sUTZ9NjyabM APBU5ZX9VP3h7y/Ta68+R0QT17lDzPTbi5ppoD9d2Yi1KY3Vg5emY1/qgBDF17K7 JujFfWW/VZqkxmtvtIY6dYQI5oj6G86X+T6lo1teMmhG23vX6F4hxAAQZk48Mqb0 6n7kpxtPrea/DxIWp1967yGbyG6F68pSqvhh2f/xBe/q+k744mon1YLNYjB3VtIc XLhDIDP/vn7CL8K26uLNeiyF64d/x3Bymf2PBPKQcK92tU6Mh8jL1ma+NysSxHrW IdoczHSn7HYGwogKxVbBcpQLHQW63atRQzJ/+vrYkbcAaddRmUC5PeOCAPOj1uIV kJ8Dg== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 3t2y7u2gp8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Sep 2023 09:08:56 -0500 (CDT) Received: from ediex02.ad.cirrus.com (198.61.84.81) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.37; Thu, 14 Sep 2023 15:08:54 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by anon-ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server id 15.2.1118.37 via Frontend Transport; Thu, 14 Sep 2023 15:08:54 +0100 Received: from EDIN4L06LR3.ad.cirrus.com (EDIN4L06LR3.ad.cirrus.com [198.61.65.215]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 48E9C15B4; Thu, 14 Sep 2023 14:08:54 +0000 (UTC) From: Richard Fitzgerald To: CC: , , , Richard Fitzgerald Subject: [PATCH] ALSA: hda: cs35l56: Don't 'return ret' if ret is always zero Date: Thu, 14 Sep 2023 15:08:52 +0100 Message-ID: <20230914140852.7112-1-rf@opensource.cirrus.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Proofpoint-GUID: npi1-VwBihTbS2d2xtl1agzUXGFvtmK9 X-Proofpoint-ORIG-GUID: npi1-VwBihTbS2d2xtl1agzUXGFvtmK9 X-Proofpoint-Spam-Reason: safe Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 14 Sep 2023 07:09:09 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777033624581746471 X-GMAIL-MSGID: 1777033624581746471 The final return in cs35l56_hda_posture_get() was returning the value of 'ret', but ret is always zero at this point. So this can be a simple 'return 0'. Signed-off-by: Richard Fitzgerald --- sound/pci/hda/cs35l56_hda.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/cs35l56_hda.c b/sound/pci/hda/cs35l56_hda.c index a9844336bdc9..c64600280f02 100644 --- a/sound/pci/hda/cs35l56_hda.c +++ b/sound/pci/hda/cs35l56_hda.c @@ -216,11 +216,11 @@ static int cs35l56_hda_posture_get(struct snd_kcontrol *kcontrol, if (ret) return ret; ucontrol->value.integer.value[0] = pos; - return ret; + return 0; } static int cs35l56_hda_posture_put(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) {