From patchwork Thu Sep 14 06:33:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yang, Weijiang" X-Patchwork-Id: 139781 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp554405vqi; Thu, 14 Sep 2023 11:50:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFiTmWiDOv4k4DzGvzGstdjOWWpqYpKgrqPVGbwsR+AnnD/XL4H8u9bF9F07lsSr6QLdC1p X-Received: by 2002:a05:6a20:12d1:b0:134:135c:5a23 with SMTP id v17-20020a056a2012d100b00134135c5a23mr3366973pzg.18.1694717435104; Thu, 14 Sep 2023 11:50:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694717435; cv=none; d=google.com; s=arc-20160816; b=YhTfl8r+6B/yM4FsFbyvTy0LTqIcjVMOjcYWFjSpYMcTG45KNaQyn7+KDur7cqNRV6 Yov5PIFnhWCS0XmPKw0DfCQT9FgVcJfxJaMjR4Qubr7+QgZLzV6na39jScNr/VftDAfy WJjrR2IuTTQ39Z+5WohZOclD7yikq5bW8GND98qMU4bAyiSxKTTNugzFTfg6MNFhSXV2 n3Fw+XchOzOqcwlEMif4zmOu1P4S6+jx+VkiKUM8a+i5vJ8MFisQpNjk0nHjmoHp/bZq 1QdX72414EuzIdNCKctApfNBgAMNWFHl1wEcsQAk7qhr1KrU4rj0l2dlilgR7cBRryZA S/eA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=FggzxxUH/b6hV2zW1ZjOUdrnNzRY+MdNgiyVl+BTjIM=; fh=jQqUhNQZPAXcZ44u72Wu3jv2pQizzn2Be2T8mkd1RwU=; b=w2szYML8VrpooPBJ/opDEYF7gb+dIRhbOl/ogZUaXdqllOmgVWRXD3movkBrKBAatY HUyuYLmBxkvs6/c4y2mjPIOKluTVwmXY3PdKwpN5a3rZbPd/8nllfo43rMviQTgrKovV vbKDPYSn1K/U6yAVOu2BeMKGceTr5eaYBqNMFAdEIxsauLWlWC4J1vrCV34WK33c6C03 pqdwPEKDjpYEYgpqMeaA2UaOuBxSCpnbE6d4+6XIpOScoT8+k4HCr1Dyloc9jwXZY9vu 4kZSnXIp+o6LInI9DeQuTA5bCB6HrWtf0MRTDFXeMjhHzAfj3G1HF3war58V5ozMkIvd WziA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=gfsfPXzR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id bv2-20020a632e02000000b0056fc3ceaba4si1814176pgb.432.2023.09.14.11.50.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Sep 2023 11:50:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=gfsfPXzR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 14C8B875EA0C; Thu, 14 Sep 2023 02:38:49 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237632AbjINJiq (ORCPT + 35 others); Thu, 14 Sep 2023 05:38:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237264AbjINJiW (ORCPT ); Thu, 14 Sep 2023 05:38:22 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBB931BF2; Thu, 14 Sep 2023 02:38:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694684298; x=1726220298; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Mo0J7nmC7/MpnJ3d9RwhENdZi4KZZ89Pbi3lSWxz018=; b=gfsfPXzRKPscqyalcDfTKP10vg4ulbrXvfC9cSe/vgEgerL3h1RMhN3/ +WIX3/LvPAyyCAKJ4M5OZh2anH0LHTsB1/b2KZKkIQnov9ONS6mgtPqze uc3/hZRD7VY8DWGR1Ffui2ppVgH9Ky3LuZ7TJtLjqE56diaJ/fut2lVmn 8ZAcbhzfs+Tf5ZpcJDfHxEDDUoxVNEeIFK8XeJAvY7MoyTSXDi10Rkwav RsbJ3yg7L/+R0JG77FZfqkqdeK1HpUNsWRedPW2Tzc/H5YPJ6vW2q9Sll l8JNmiLQWShyZdeN/iHmObsNvXtKyB9vfi/6grwA8jXKpPRGhFtneT2Kw A==; X-IronPort-AV: E=McAfee;i="6600,9927,10832"; a="409857346" X-IronPort-AV: E=Sophos;i="6.02,145,1688454000"; d="scan'208";a="409857346" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2023 02:38:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10832"; a="747656237" X-IronPort-AV: E=Sophos;i="6.02,145,1688454000"; d="scan'208";a="747656237" Received: from embargo.jf.intel.com ([10.165.9.183]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2023 02:38:18 -0700 From: Yang Weijiang To: seanjc@google.com, pbonzini@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: dave.hansen@intel.com, peterz@infradead.org, chao.gao@intel.com, rick.p.edgecombe@intel.com, weijiang.yang@intel.com, john.allen@amd.com Subject: [PATCH v6 08/25] x86/fpu/xstate: WARN if normal fpstate contains kernel dynamic xfeatures Date: Thu, 14 Sep 2023 02:33:08 -0400 Message-Id: <20230914063325.85503-9-weijiang.yang@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20230914063325.85503-1-weijiang.yang@intel.com> References: <20230914063325.85503-1-weijiang.yang@intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 14 Sep 2023 02:38:49 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777040029140970229 X-GMAIL-MSGID: 1777040029140970229 fpu_kernel_dynamic_xfeatures now are __ONLY__ enabled by guest kernel and used for guest fpstate, i.e., none for normal fpstate. The bits are added when guest fpstate is allocated and fpstate->is_guest set to %true. For normal fpstate, the bits should have been removed when init system FPU settings, WARN_ONCE() if normal fpstate contains kernel dynamic xfeatures before xsaves is executed. Signed-off-by: Yang Weijiang --- arch/x86/kernel/fpu/xstate.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/x86/kernel/fpu/xstate.h b/arch/x86/kernel/fpu/xstate.h index 9c6e3ca05c5c..c2b33a5db53d 100644 --- a/arch/x86/kernel/fpu/xstate.h +++ b/arch/x86/kernel/fpu/xstate.h @@ -186,6 +186,9 @@ static inline void os_xsave(struct fpstate *fpstate) WARN_ON_FPU(!alternatives_patched); xfd_validate_state(fpstate, mask, false); + WARN_ON_FPU(!fpstate->is_guest && + (mask & fpu_kernel_dynamic_xfeatures)); + XSTATE_XSAVE(&fpstate->regs.xsave, lmask, hmask, err); /* We should never fault when copying to a kernel buffer: */