From patchwork Thu Sep 14 03:23:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yang, Weijiang" X-Patchwork-Id: 139600 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp359981vqi; Thu, 14 Sep 2023 06:47:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGIR+ewg5LyhvZZWDTOQg5STIiLHJZs1yaZRhM7X5yePONdfSNxTBoG1e9jWO26LGQcZchX X-Received: by 2002:a17:903:244c:b0:1c3:a396:25ae with SMTP id l12-20020a170903244c00b001c3a39625aemr6908469pls.56.1694699227125; Thu, 14 Sep 2023 06:47:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694699227; cv=none; d=google.com; s=arc-20160816; b=fE83jl8m6/5dT4z4VQSybP9bNobrbLwxHC4Tz6DpRmIpoK/YrZrO+BG+/qKwfxKhtF wH6EsBYAwsjvD6nMam+OaysoXc3j0DJ3ABtBDeesIS2gBiVMOeW9GekeOSn2R/dY5Ef9 WKrOio2VDe0iyyEGBLXuOj/e1elayVJq/gxRKe7mo82hztgYHfm2fL+hM6ZSiG/TkORR qBPBAtbcXwyzX50ywwk/BIKEVLUQDPFD97wpXLN7q4RgzakBcAJzPqFzIxLDIXbb6594 3lzy6UnQ7FsOy7Q9yK57eH64wceYsN+as/2UkABsds3g6NNH+m6dCizPC7bfaJ+tg7nt nRJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=FggzxxUH/b6hV2zW1ZjOUdrnNzRY+MdNgiyVl+BTjIM=; fh=VKDky7JI6Mwho+jW2kjyYjgneGFqVaPlgJX6sIBNvQM=; b=T5IOJIeWe2l6VCsJkB51FTrQxb5V22ajiwUlcpSQ+g2zMHYRCKXKODhJzHZFTiW2D1 J3lUCxhcPIZX2MaT7Shqk68l+YHB6BgtPjR2Zk/ipreLSVM0WsTeGqbfmvIgIWiB620W YVma6zawpbwQiFLMGJvhsPVFQWJmtkve5qKVHFZ/zV2LWhZBMHpOekUdxHN8+xaX6Dg/ iOznM8/8Sxosnxs/5qSpGgmr+JqAxfWYtRVOPSFuQqqkYJ+KbD8JS9VnsTao17WN9EuU 0LjajE7rUNvO4LoH2l2HFPPubvfhPpZ26r4VpwHNS7XZE0Smc8A2zRDemXr/BTWbxo8j q/Lw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Y6uA6VCp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id k7-20020a170902c40700b001bb0ff2b354si1776573plk.425.2023.09.14.06.47.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Sep 2023 06:47:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Y6uA6VCp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 9081D8320DC6; Wed, 13 Sep 2023 23:29:10 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235760AbjING3H (ORCPT + 35 others); Thu, 14 Sep 2023 02:29:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235443AbjING2t (ORCPT ); Thu, 14 Sep 2023 02:28:49 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 545B3F9; Wed, 13 Sep 2023 23:28:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694672925; x=1726208925; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Mo0J7nmC7/MpnJ3d9RwhENdZi4KZZ89Pbi3lSWxz018=; b=Y6uA6VCpNaCCxTjQV54+DXc5d3erxGQYYWtOWL2TV1I+q3Z5WvnFHWaJ JS47NT+1WT6NJz+Bd03btwzqy9u2sl3i5l1N/Dt26KEvkaDzyvka2szUU kcJn9q4lCAvSyS8GwqFd3KFYaEUaXjGM89ff8PP+l9GRg82+vOxiVZqk0 wQk+NNOPy1mjmgAP/V0Fx8SNCSkY1Zl8rlfw5i3b/6xL6fbh1Fe3rfXFk 32gOt5x0r8Jmon0WvaMzxgFn6NZlpM9nAhavdCndb7nVFMdCMua3hHCvq pFx/Xowb18L3tm9ne7fACJAD1eoU4aYoP7+E7MYVR0kq2LtJmAzv6Yh8Q w==; X-IronPort-AV: E=McAfee;i="6600,9927,10832"; a="382672480" X-IronPort-AV: E=Sophos;i="6.02,145,1688454000"; d="scan'208";a="382672480" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2023 23:28:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10832"; a="809937999" X-IronPort-AV: E=Sophos;i="6.02,145,1688454000"; d="scan'208";a="809937999" Received: from embargo.jf.intel.com ([10.165.9.183]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2023 23:28:44 -0700 From: Yang Weijiang To: x86@kernel.org, linux-kernel@vger.kernel.org Cc: dave.hansen@intel.com, tglx@linutronix.de, peterz@infradead.org, seanjc@google.com, pbonzini@redhat.com, rick.p.edgecombe@intel.com, kvm@vger.kernel.org, yang.zhong@intel.com, jing2.liu@intel.com, chao.gao@intel.com, Yang Weijiang Subject: [RFC PATCH 8/8] x86/fpu/xstate: WARN if normal fpstate contains kernel dynamic xfeatures Date: Wed, 13 Sep 2023 23:23:34 -0400 Message-Id: <20230914032334.75212-9-weijiang.yang@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20230914032334.75212-1-weijiang.yang@intel.com> References: <20230914032334.75212-1-weijiang.yang@intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 13 Sep 2023 23:29:10 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777020936270444404 X-GMAIL-MSGID: 1777020936270444404 fpu_kernel_dynamic_xfeatures now are __ONLY__ enabled by guest kernel and used for guest fpstate, i.e., none for normal fpstate. The bits are added when guest fpstate is allocated and fpstate->is_guest set to %true. For normal fpstate, the bits should have been removed when init system FPU settings, WARN_ONCE() if normal fpstate contains kernel dynamic xfeatures before xsaves is executed. Signed-off-by: Yang Weijiang --- arch/x86/kernel/fpu/xstate.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/x86/kernel/fpu/xstate.h b/arch/x86/kernel/fpu/xstate.h index 9c6e3ca05c5c..c2b33a5db53d 100644 --- a/arch/x86/kernel/fpu/xstate.h +++ b/arch/x86/kernel/fpu/xstate.h @@ -186,6 +186,9 @@ static inline void os_xsave(struct fpstate *fpstate) WARN_ON_FPU(!alternatives_patched); xfd_validate_state(fpstate, mask, false); + WARN_ON_FPU(!fpstate->is_guest && + (mask & fpu_kernel_dynamic_xfeatures)); + XSTATE_XSAVE(&fpstate->regs.xsave, lmask, hmask, err); /* We should never fault when copying to a kernel buffer: */