From patchwork Thu Sep 14 00:05:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 139550 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp316427vqi; Thu, 14 Sep 2023 05:38:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGEe2lhGogLsKHVbrv6yxHmxfgwJwO1nuTeeTHkU/D7APp7PMbz7vCqM3Y01AK+MUNGUlpx X-Received: by 2002:a17:903:2302:b0:1c3:a4f2:7cc1 with SMTP id d2-20020a170903230200b001c3a4f27cc1mr5762221plh.5.1694695118257; Thu, 14 Sep 2023 05:38:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694695118; cv=none; d=google.com; s=arc-20160816; b=YTGKnPwXBmVZ9P5N9XyXVBPn3m8oNArvLWVXc8H/geYSxBm+csvIR1VscQc6Swseet SeoawV2K8XVoOr/fJeraJgQOc21oGsRUvu/YenThZ+owF+q2TUjbx9D0r2UJovwPNO7R 61oqgl9GIXZiq3ip5q9qKJaH1gP1zIANfTf+JflCUTrgXQOCRvlDpwynH2D82HAQROpK zyOFsY0WcBl+WIpViJ0CklNz2uZiR6rAJidIdwBjSPpVv6pbPtH0Y4Th0tE88VXBOh2q sGVY59bT6YqExB9FaCSJXL4YtX618OiXgnau6SELs/F95882A7Wjssra24tl8bqFfM// 05vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ru4tgUXmNV0z0CNxeAwewwnktolUzJXXBFTYWbp6120=; fh=7LBrczNX033+xsXic+0jggqdE05g4jnTU8AAkvqsVNY=; b=vHxaECzQ9NNXqqdM1bGdxO/myOVmnIeQF9cnn5FvG2joUSf5yUtlOUIA2UAM2kmQyK +VpUyhPfvPJ6IAtxoU+S4vtfLPmhlS3jn16xIO373na2bPZGiRc25omXU3VyZsbUGOoj FpBod6y5Ev0QytQF9wQUao66qtHIXXHsp2EiR82yvYSsuSATtQnqjtlBv910PrxzjNrA cuslslx1umZvn4T+9R/uXg7bZVlYDDzGemjA/2CVeBf/DwOsh8Z7195vrAgDGmc8l0bv DD4iR0Tkg8j2APdc9+0XElli+EG6PnE+/BcwJF4Jr6YDbben+T/oiHpU7Cf5m7o53Yra 7HIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=CBnac8ez; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id t7-20020a1709027fc700b001c382ba4f5bsi1584361plb.434.2023.09.14.05.38.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Sep 2023 05:38:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=CBnac8ez; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 09600807757E; Wed, 13 Sep 2023 17:05:32 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233280AbjINAF1 (ORCPT + 35 others); Wed, 13 Sep 2023 20:05:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229996AbjINAFZ (ORCPT ); Wed, 13 Sep 2023 20:05:25 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC302E6A; Wed, 13 Sep 2023 17:05:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=ru4tgUXmNV0z0CNxeAwewwnktolUzJXXBFTYWbp6120=; b=CBnac8ezMmvKD2BY8KS5Y7mhVS XSmAkMgQobLem2gVa997F59XbtM/3WRYqONnoGEhwq6I+h0NEi39djQ3bQxAhQD/ufETRP43ghrym EjV+7mVT3PwkpTCshsCoA0bEDkyI6zeow6URcDI277wGvXCEL7Trd7Zd2jVL9C0LwykYwcq+myUpC U3rTlEO0BcdzSqG7Pvz9PxAiWpy2MPvjygbNCZrZ6mftlYTQw4OhB3vrkNkJX7LOt+2RJD99SI/VZ BOuPffSrYXUV+gjt8lDtcUygoWBDl0vtnsz6oVCSRz6KJ+1QelbWWa3xiT+4sHzTcvI3OGTtKmTB4 Y/E0i8QQ==; Received: from [2601:1c2:980:9ec0::9fed] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qgZrE-006vlO-37; Thu, 14 Sep 2023 00:05:21 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Rahul Rameshbabu , Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org Subject: [PATCH] HID: nvidia-shield: add LEDS_CLASS dependency Date: Wed, 13 Sep 2023 17:05:17 -0700 Message-ID: <20230914000517.16252-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 13 Sep 2023 17:05:32 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776988449435013120 X-GMAIL-MSGID: 1777016628377822093 The hid-nvidia-shield driver uses functions that are built only when LEDS_CLASS is set, so make the driver depend on that symbol to prevent build errors. riscv32-linux-ld: drivers/hid/hid-nvidia-shield.o: in function `.L11': hid-nvidia-shield.c:(.text+0x192): undefined reference to `led_classdev_unregister' riscv32-linux-ld: drivers/hid/hid-nvidia-shield.o: in function `.L113': hid-nvidia-shield.c:(.text+0xfa4): undefined reference to `led_classdev_register_ext' Fixes: 09308562d4af ("HID: nvidia-shield: Initial driver implementation with Thunderstrike support") Signed-off-by: Randy Dunlap Cc: Rahul Rameshbabu Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: linux-input@vger.kernel.org --- drivers/hid/Kconfig | 1 + 1 file changed, 1 insertion(+) diff -- a/drivers/hid/Kconfig b/drivers/hid/Kconfig --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -799,6 +799,7 @@ config HID_NVIDIA_SHIELD tristate "NVIDIA SHIELD devices" depends on USB_HID depends on BT_HIDP + depends on LEDS_CLASS help Support for NVIDIA SHIELD accessories.