From patchwork Wed Sep 13 16:05:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Fitzgerald X-Patchwork-Id: 139813 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp588413vqi; Thu, 14 Sep 2023 12:52:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFjbYJcMtfnecVUPTZ8qdejjAaOJu8jMOFQiDIRSXZZEqCwMNc1o3ChkkpFbs4wyilbJ/Yl X-Received: by 2002:a17:903:234f:b0:1bd:d510:78fb with SMTP id c15-20020a170903234f00b001bdd51078fbmr3935258plh.3.1694721141421; Thu, 14 Sep 2023 12:52:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694721141; cv=none; d=google.com; s=arc-20160816; b=NlH81fO8QbrxR3nuayuukX8HHUUHqqhAbkBGYdt24iLqt/x8JoS9IAie8ycaRqr+Lk uHXuJ/AHIvVYNVc0KLLTAxJ582rdCZihVWwUe84gvAZ0mqpfBLxNxRAzGhU5NHfoWOiQ GlspUyob1LVcUel0vECsg1WKFNdYtZx7W/46S1qRlDgIm+pAfIpN8o6te5f6D01XOm1F V8Dt5KhW146klVrPNJZ02fuOwHjfDZOoF2X/Xc46smPF/kdAeS+U/fUVPnLQG1ooeYSR ehmpdcgoFW1k58CKHrboUlTaU7JJAUhMqIajU3wqUJZ4+1L77MqDXTYM2s+2rc206N6s lPgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=x7xY/Bo54rmkapWVRvyY9QbwaOEFq2pdNqDed36g8Fw=; fh=msJyvNxU746DPxHNUm730fSh0XzR8hw6ZQ26j1rHfOg=; b=BD6QEjjcTcA8ts8Yssi9nSAWSS+bm/CtNwEDUJBl12+TESZtwZKncHjW4vulNSHVcW cFJucypC1kHEPW0HJPN4YRoQZb85pLAkrYGlX2ojzuMOXhqz+MaZjzr1nzzwnLzR+IPw tDHNXULKA1E5T+Q+V8QO+YdqmndGm87kOsjck4TP5ze/nKwvydcZzNwp2wMCT/tsOtoj D6X8TYM58tT1ElC5Lx9cFP4NP1BptejapwjVc1YSFPea/Jrp3hwe9v28W21BzJcrB1Fs ZUiz9i2tsEXIX4CpiUZQI9gBFsM5AQO+Za7pEEgkO5RcuwYJhZwwxV87LVyddft9BxqN htfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=M34Tx9z8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id k186-20020a6384c3000000b00577960a815csi1995306pgd.188.2023.09.14.12.52.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Sep 2023 12:52:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=M34Tx9z8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 1C36E8074535; Wed, 13 Sep 2023 09:05:48 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229983AbjIMQFm (ORCPT + 35 others); Wed, 13 Sep 2023 12:05:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbjIMQFl (ORCPT ); Wed, 13 Sep 2023 12:05:41 -0400 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56CD190 for ; Wed, 13 Sep 2023 09:05:37 -0700 (PDT) Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.22/8.17.1.22) with ESMTP id 38DFQcjq002023; Wed, 13 Sep 2023 11:05:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding:content-type; s=PODMain02222019; bh=x 7xY/Bo54rmkapWVRvyY9QbwaOEFq2pdNqDed36g8Fw=; b=M34Tx9z8kUskTNPCn hlPmo2rEf5LjHQEN7z1S5dyMGd1vDZJ5DANq37yP2Vloj+qUl+B/RQB5N5/UqbuK E03MLhfOVznwMrj/ZLQmPehyMjCIguQfx7HnLBcMeUvpavpRyd7CIgiadkDgLTwo rVSMSl9oP0w6coIQOaKInxe3P69KnlOfXbUNkWGSlFl8l2t70f2zkKA0tERNRWVp pggCSm7+vW8pO3+iX2A8b3swgmviwK67D90gJyulpOIppP6ZP8A3xA/vLejD7AfZ AV4nerBGPFBOlWc7VewhkgP/0Raf9QA4SZ//ijLClDvrlRXXw9DlUcPndVA2g12i ecGng== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3t2y7sh0qb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Sep 2023 11:05:24 -0500 (CDT) Received: from ediex02.ad.cirrus.com (198.61.84.81) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.37; Wed, 13 Sep 2023 17:05:23 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by anon-ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server id 15.2.1118.37 via Frontend Transport; Wed, 13 Sep 2023 17:05:23 +0100 Received: from edi-sw-dsktp-006.ad.cirrus.com (edi-sw-dsktp-006.ad.cirrus.com [198.90.251.125]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 0873515B9; Wed, 13 Sep 2023 16:05:23 +0000 (UTC) From: Richard Fitzgerald To: CC: , , , Richard Fitzgerald Subject: [PATCH] firmware: cirrus: cs_dsp: Only log list of algorithms in debug build Date: Wed, 13 Sep 2023 17:05:23 +0100 Message-ID: <20230913160523.3701189-1-rf@opensource.cirrus.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Proofpoint-GUID: LcYtPJMkHiOR5iOEnMyA45-FaDiOlyKX X-Proofpoint-ORIG-GUID: LcYtPJMkHiOR5iOEnMyA45-FaDiOlyKX X-Proofpoint-Spam-Reason: safe Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 13 Sep 2023 09:05:48 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777025348913476938 X-GMAIL-MSGID: 1777043915840209296 Change the logging of each algorithm from info level to debug level. On the original devices supported by this code there were typically only one or two algorithms in a firmware and one or two DSPs so this logging only used a small number of log lines. However, for the latest devices there could be 30-40 algorithms in a firmware and 8 DSPs being loaded in parallel, so using 300+ lines of log for information that isn't particularly important to have logged. Signed-off-by: Richard Fitzgerald --- drivers/firmware/cirrus/cs_dsp.c | 34 ++++++++++++++++---------------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/firmware/cirrus/cs_dsp.c b/drivers/firmware/cirrus/cs_dsp.c index 17b7198b87dc..4d702442565e 100644 --- a/drivers/firmware/cirrus/cs_dsp.c +++ b/drivers/firmware/cirrus/cs_dsp.c @@ -1827,15 +1827,15 @@ static int cs_dsp_adsp2_setup_algs(struct cs_dsp *dsp) return PTR_ERR(adsp2_alg); for (i = 0; i < n_algs; i++) { - cs_dsp_info(dsp, - "%d: ID %x v%d.%d.%d XM@%x YM@%x ZM@%x\n", - i, be32_to_cpu(adsp2_alg[i].alg.id), - (be32_to_cpu(adsp2_alg[i].alg.ver) & 0xff0000) >> 16, - (be32_to_cpu(adsp2_alg[i].alg.ver) & 0xff00) >> 8, - be32_to_cpu(adsp2_alg[i].alg.ver) & 0xff, - be32_to_cpu(adsp2_alg[i].xm), - be32_to_cpu(adsp2_alg[i].ym), - be32_to_cpu(adsp2_alg[i].zm)); + cs_dsp_dbg(dsp, + "%d: ID %x v%d.%d.%d XM@%x YM@%x ZM@%x\n", + i, be32_to_cpu(adsp2_alg[i].alg.id), + (be32_to_cpu(adsp2_alg[i].alg.ver) & 0xff0000) >> 16, + (be32_to_cpu(adsp2_alg[i].alg.ver) & 0xff00) >> 8, + be32_to_cpu(adsp2_alg[i].alg.ver) & 0xff, + be32_to_cpu(adsp2_alg[i].xm), + be32_to_cpu(adsp2_alg[i].ym), + be32_to_cpu(adsp2_alg[i].zm)); alg_region = cs_dsp_create_region(dsp, WMFW_ADSP2_XM, adsp2_alg[i].alg.id, @@ -1960,14 +1960,14 @@ static int cs_dsp_halo_setup_algs(struct cs_dsp *dsp) return PTR_ERR(halo_alg); for (i = 0; i < n_algs; i++) { - cs_dsp_info(dsp, - "%d: ID %x v%d.%d.%d XM@%x YM@%x\n", - i, be32_to_cpu(halo_alg[i].alg.id), - (be32_to_cpu(halo_alg[i].alg.ver) & 0xff0000) >> 16, - (be32_to_cpu(halo_alg[i].alg.ver) & 0xff00) >> 8, - be32_to_cpu(halo_alg[i].alg.ver) & 0xff, - be32_to_cpu(halo_alg[i].xm_base), - be32_to_cpu(halo_alg[i].ym_base)); + cs_dsp_dbg(dsp, + "%d: ID %x v%d.%d.%d XM@%x YM@%x\n", + i, be32_to_cpu(halo_alg[i].alg.id), + (be32_to_cpu(halo_alg[i].alg.ver) & 0xff0000) >> 16, + (be32_to_cpu(halo_alg[i].alg.ver) & 0xff00) >> 8, + be32_to_cpu(halo_alg[i].alg.ver) & 0xff, + be32_to_cpu(halo_alg[i].xm_base), + be32_to_cpu(halo_alg[i].ym_base)); ret = cs_dsp_halo_create_regions(dsp, halo_alg[i].alg.id, halo_alg[i].alg.ver,