From patchwork Wed Sep 13 15:16:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chengming Zhou X-Patchwork-Id: 138890 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9ecd:0:b0:3f2:4152:657d with SMTP id t13csp1161909vqx; Wed, 13 Sep 2023 08:22:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHTgQ//ZuRfJ1wTg5K1S5+fpvgpBlWAphJEW5O3aXIHRXfeSbjp8JNVjreCUVmDdg7V1fGD X-Received: by 2002:a17:903:11d1:b0:1c0:ce0f:ab57 with SMTP id q17-20020a17090311d100b001c0ce0fab57mr4735142plh.3.1694618525234; Wed, 13 Sep 2023 08:22:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694618525; cv=none; d=google.com; s=arc-20160816; b=fdesP+us4TlThrcNxwsjlctQNL6J3OCt/I5S8F8yKpzXQ7E5woKNQXgHdKg7EvPQ8H xRluFfQFopQpedpnflweVsxmEm79t/yIUtLmYtJ01ajORFcPxwXhVSNM0PbLx1lPiOZe V5IqAspD40Vq6WEBOA/+ox61hE044srmbeCNpKhLrOmQcGuUSQANe0aDy/FoB25CUwlE LFbpYy65+exx80GXJIYsUXEwD+u6733OSjmJqKwJJj7zl1V4JoFrgL1hBIqyHkESiNYO yEpdlJ8w282S9fyXen4cvR998duhYX8rt3kglVyJAI7KVa0v6Mbp/b9VBFhYLa7RPh0n ehWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0/BBRvz91/qS3KlzgnvKJU+Ez3qMEnH1nXMNaUxqVE0=; fh=szS6nKOHqWqdmo+pDmdMHkpBM8bpzBlMJyKfLi9jRHY=; b=ywfxyndzGfkkMp7AeU1BQ5XM28JSwVT3woYREoNUJNzTOnf8SYMzCiGtdw9VyWzRtn G8xSzta9tPyx7N+h7u01tcJ9kMQ0guLznM8li0lObtUXgt1Tw4XWnQXF6KBtgm4waEHu vxkcCCSQYqHaJufnD1gSib+rXijeZRQIQo/hKZYhhK0RdkoKfRAOxRHI0p91t92FHnVf hOEkfCC5+FMxZIXehl5YjGlF5s5b6N2DPgB8e+ClyOiEP/jJ7GF2fDOr2i7JnpGgTZAw CigGp+KEfnS6hkW7jxoUuRszTbQBtpl2atV0CfuTPoXkpS1RGKDXw5SLRceGm6fqjKj6 PVoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=F4q3Ygj6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id d6-20020a170902cec600b001c3868f594bsi9948403plg.634.2023.09.13.08.22.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 08:22:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=F4q3Ygj6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 373FF802389B; Wed, 13 Sep 2023 08:17:40 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241631AbjIMPRE (ORCPT + 36 others); Wed, 13 Sep 2023 11:17:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241673AbjIMPQl (ORCPT ); Wed, 13 Sep 2023 11:16:41 -0400 Received: from out-227.mta1.migadu.com (out-227.mta1.migadu.com [95.215.58.227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16861B9 for ; Wed, 13 Sep 2023 08:16:37 -0700 (PDT) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1694618195; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0/BBRvz91/qS3KlzgnvKJU+Ez3qMEnH1nXMNaUxqVE0=; b=F4q3Ygj6OhewGfFQk8HXu//5xlTYgIC1sqR6KVRQA0SVq6L0RiUD/ZRfRu1NkH95snA+s5 woXrvUBK7WVCG2aACvaVJKPnZ7UHGDwOPfJcKH9deghCemJVWWxDZ1PVKJ/Jg5WEa9Ni0W MpDPeTrjt51ApEQrfPSEPDq7qam3WVY= From: chengming.zhou@linux.dev To: axboe@kernel.dk, hch@lst.de, ming.lei@redhat.com, bvanassche@acm.org Cc: kbusch@kernel.org, mst@redhat.com, damien.lemoal@opensource.wdc.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, chengming.zhou@linux.dev, Chengming Zhou Subject: [PATCH v2 3/5] blk-mq: support batched queue_rqs() on shared tags queue Date: Wed, 13 Sep 2023 15:16:14 +0000 Message-Id: <20230913151616.3164338-4-chengming.zhou@linux.dev> In-Reply-To: <20230913151616.3164338-1-chengming.zhou@linux.dev> References: <20230913151616.3164338-1-chengming.zhou@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 13 Sep 2023 08:17:40 -0700 (PDT) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776936315153521531 X-GMAIL-MSGID: 1776936315153521531 From: Chengming Zhou Since active requests have been accounted when allocate driver tags, we can remove this limit now. Signed-off-by: Chengming Zhou Reviewed-by: Ming Lei --- block/blk-mq.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index c209a7dddee3..68ce9357463b 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -2781,13 +2781,8 @@ void blk_mq_flush_plug_list(struct blk_plug *plug, bool from_schedule) * If we do, we can dispatch the whole plug list in one go. We * already know at this point that all requests belong to the * same queue, caller must ensure that's the case. - * - * Since we pass off the full list to the driver at this point, - * we do not increment the active request count for the queue. - * Bypass shared tags for now because of that. */ - if (q->mq_ops->queue_rqs && - !(rq->mq_hctx->flags & BLK_MQ_F_TAG_QUEUE_SHARED)) { + if (q->mq_ops->queue_rqs) { blk_mq_run_dispatch_ops(q, __blk_mq_flush_plug_list(q, plug)); if (rq_list_empty(plug->mq_list))