From patchwork Wed Sep 13 12:27:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ilpo_J=C3=A4rvinen?= X-Patchwork-Id: 139230 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp54425vqi; Wed, 13 Sep 2023 18:59:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHOj5HfhRHMBXhmCs7/iT2PQXTbF00lFc/DSNKCxe2Fda0d3kXrSYbUgQ8McV2bQ8uGkfwp X-Received: by 2002:a17:90b:33cd:b0:26b:280b:d24c with SMTP id lk13-20020a17090b33cd00b0026b280bd24cmr3777317pjb.42.1694656783283; Wed, 13 Sep 2023 18:59:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694656783; cv=none; d=google.com; s=arc-20160816; b=blk/GiPUuhUqByBkW/9k3O3xhtY8ulF3Pw3kEHrsjmY7xtjyZxiaCXfwpzGnR7MH5/ Ky1qKm0efKOleHJ9MGUL11DTeUSJGZtB0TjnmZgjiChQY1I2RApTfqgckKYH9CfCnhVg pS3M7K1J13zXTspukfEC6KMQBsphWDFaI5MXbaaykuKx9SkOMkCcYt25qwaBaPyMGVj+ BQU2ASgZLliMWKye94DbIHiYjb+JkCnJza1uYTmpbivJ/+5GXBWJhMLESuiQS6t92izz QQj1b8WeqJgyceHYaMKUpVkFRt8wPRpG2OdViQYWWmH8SbjL2I91jl2GLyWdxGlpjZPn CeVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=yEuadT3J77AROzwqn5ZlD/G3jIuuHLd1Hj7O5oEpAHU=; fh=X4Uye5sNwVBuCVMZMaHyDTEYQvcWCD9KmOMf5RPIL/A=; b=L9e4j6kuqBYd4a339eUDkiT2ewJrOtlsVQLVkjvtruZ7URsfrCVwoLcCuYDhn+t2dH gOF3uTWFOXBT3OX9yYlpuJo4ON/BabsC3WFc+iKlJVibmGvwUe74MKMrKq5mwarJXDKC s17fzqGQeWPfstCKNp8o1926RS2LDHa36fL7OLOLJQK+k0xokbdOVoH31iyAf0v0fCvh w9A9poXEA7iweZd5VbU9/6aHXgeLK3TLpbtAHPCdiw9/20y+wtFWFUiNo7+x0bA1cF0D ecRgKklnwu+KjIQbEG0HPUXBRpMAiWG6pY2E2XnCBdgY8/4eT7OEU2pxwmoJsURf6X6V xOOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=eDfgN0Mf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id g20-20020a17090a579400b00263220254e2si570294pji.41.2023.09.13.18.59.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 18:59:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=eDfgN0Mf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 610AD823CC6B; Wed, 13 Sep 2023 05:30:45 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240538AbjIMMap (ORCPT + 36 others); Wed, 13 Sep 2023 08:30:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236266AbjIMMak (ORCPT ); Wed, 13 Sep 2023 08:30:40 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 776B11BDD; Wed, 13 Sep 2023 05:30:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694608235; x=1726144235; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=zQpj7OaTDonluY2E3OGQf5kVh3FqltWnatkxOc0duHk=; b=eDfgN0MfyQUdB5ZYrBp0kmgE5KJ/Hn6imRmwhkLYeSWBAMDQO4Qwdbx9 RAFTBcjqI6eZwr0LlRJoTP/iom81QI1Wfhr/NPMjkKv8tnvm8/PmXVtOy 48iCNCzjUXeHnf1iQDrStnH3EbPKmltJHNSmbgiX818BqcrzeeC6YuRF8 WurnHQwNdY25crh9NlxWu/g00Ef/uFSA0m87I/T/EUIMKUo8C3rSFYQeW VLwGKBgYadRL1NFtp7veXPXV6fdFVyuzEYe6pja4I4MA+FACELjyQApeu 30uy+1Td5n5XuVKpt0qXkjuLmp9o0ZJ1hXKgxPNdqj4W1kJq+FR6KIj2F Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10832"; a="368912417" X-IronPort-AV: E=Sophos;i="6.02,143,1688454000"; d="scan'208";a="368912417" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2023 05:28:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10832"; a="693836628" X-IronPort-AV: E=Sophos;i="6.02,143,1688454000"; d="scan'208";a="693836628" Received: from pakurapo-mobl3.ger.corp.intel.com (HELO ijarvine-mobl2.ger.corp.intel.com) ([10.249.45.213]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2023 05:28:08 -0700 From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= To: Jonathan Cameron , linux-pci@vger.kernel.org, Bjorn Helgaas , Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Jonathan Cameron Subject: [PATCH v2 03/10] igb: Use FIELD_GET() to extract Link Width Date: Wed, 13 Sep 2023 15:27:41 +0300 Message-Id: <20230913122748.29530-4-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230913122748.29530-1-ilpo.jarvinen@linux.intel.com> References: <20230913122748.29530-1-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 13 Sep 2023 05:30:45 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776976431199369333 X-GMAIL-MSGID: 1776976431199369333 Use FIELD_GET() to extract PCIe Negotiated Link Width field instead of custom masking and shifting. Signed-off-by: Ilpo Järvinen Reviewed-by: Jonathan Cameron --- drivers/net/ethernet/intel/igb/e1000_mac.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/e1000_mac.c b/drivers/net/ethernet/intel/igb/e1000_mac.c index caf91c6f52b4..5a23b9cfec6c 100644 --- a/drivers/net/ethernet/intel/igb/e1000_mac.c +++ b/drivers/net/ethernet/intel/igb/e1000_mac.c @@ -1,6 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* Copyright(c) 2007 - 2018 Intel Corporation. */ +#include #include #include #include @@ -50,9 +51,8 @@ s32 igb_get_bus_info_pcie(struct e1000_hw *hw) break; } - bus->width = (enum e1000_bus_width)((pcie_link_status & - PCI_EXP_LNKSTA_NLW) >> - PCI_EXP_LNKSTA_NLW_SHIFT); + bus->width = (enum e1000_bus_width)FIELD_GET(PCI_EXP_LNKSTA_NLW, + pcie_link_status); } reg = rd32(E1000_STATUS);