Message ID | 20230913115001.23183-5-brgl@bgdev.pl |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9ecd:0:b0:3f2:4152:657d with SMTP id t13csp1120186vqx; Wed, 13 Sep 2023 07:19:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEipF/3skDKZgLk/CuNEMg2J2FEZ+dCZi2YMZ0c8w/5Vtwo2jiiRPP8LRIp7mI7g0AhFcNh X-Received: by 2002:a17:903:188:b0:1c0:e472:5412 with SMTP id z8-20020a170903018800b001c0e4725412mr3435878plg.18.1694614782004; Wed, 13 Sep 2023 07:19:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694614781; cv=none; d=google.com; s=arc-20160816; b=N78BCmMhY7Kaz38JyLup17Oo+ZMWHMLbeB5xBwK9x+oq++2wfvlPF43OlskGccXu+s SynnMBKI14z/MB/UcOAS6dc87LlzuZqzpp8LuSv9uG7C3u0zbRyCA9gyTfs8cci0E+ee wVLBlpjblrxlZ32e73bdk6P7bOWU2KFA3dSYeTk9oEGAgOKLX+u4byarrZrtVd7sZbRP wZFqNd9PTs9RU2Ic3qc8wGG+tAexzQsMuHDklgJID311DDSfnhXAezZ+DtfLB1Hz0xyW CBH/DoyCjJTofKt8lDUAheu9s4h9YD65yBdQ34lHICY5IEQnpvU3SABSf+j2ZxJKlIKe +I4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=jSDvgG/AlTocCbtsh72PpLY+FqxqCYIc4jmjYno6s+Q=; fh=0APTZUKOvF74sGqrjhjjJpAFLL5Kw9fbVHsTj8Q1YJA=; b=G7ERAjn2JBlh54ArXMFo7xKo4nFYe3SF36d6yx8pGs9qX7QRHnJwJoGIlwSM9sfBf5 vH1PCSGBvfjsT2DIAiRUm1tMDWJHlqVz549jAT/N1+SjXx+eOYyWGS5B+UdM7Kkp55fD VkmvqtB2Z6CruI0U5I6g4Usrv6euAK2+nbkhGwLmbE70BRTHMBKjtaDKyE5e/2XhjRHo H+OoypYJZnd58a9DdYfqt/hzoNUmArw5OVQGG296ATOgA5Ifvvtg/B+aePNkAJQ9VfWs Wsezx3tZ53W/Mzd2WhXy62YshOVk9ZqRwAvnVqyywd18b3p/hUk1ZeHOsDWxmydE1G+O 4hcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=LPBaRxGK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id e4-20020a17090301c400b001bb0ba81053si2245503plh.50.2023.09.13.07.19.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 07:19:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=LPBaRxGK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 21632822076C; Wed, 13 Sep 2023 04:50:41 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240570AbjIMLuf (ORCPT <rfc822;pwkd43@gmail.com> + 36 others); Wed, 13 Sep 2023 07:50:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240565AbjIMLu2 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 13 Sep 2023 07:50:28 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFEA11999 for <linux-kernel@vger.kernel.org>; Wed, 13 Sep 2023 04:50:23 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-31f853f2f3aso557029f8f.0 for <linux-kernel@vger.kernel.org>; Wed, 13 Sep 2023 04:50:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1694605822; x=1695210622; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jSDvgG/AlTocCbtsh72PpLY+FqxqCYIc4jmjYno6s+Q=; b=LPBaRxGKMqxZeVdBmAh6uE6kJYetpBgLfZaeQ5ZTeaAnb7dbPzxZMLpW6rKB8MTGET fn6QXEMiRSoXe7fZZnCMqoZSk5OnPd/EPLDMZ3I8m2J8cEyAUQ2tqqUzd6IhD75fhBT/ bnXfXL/3vO8x+ScWtCkhQK6+LRdN2uBXZo5RjcHixqOpCkFrZnEQ//PQRxwV0E6O83f4 9TR2TPo6vXwxRf03TkU8G/o/UA9C0QhBRuLvTsAD2fn5LEE/r9GB5PmOdp1tpSEkLaSD 71XMTllaBzKCrPwd7R0MhZTp7q8MG+5DjV/urg4o+eTVw8bqGmzliKPLWt6/rPmNG025 DFsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694605822; x=1695210622; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jSDvgG/AlTocCbtsh72PpLY+FqxqCYIc4jmjYno6s+Q=; b=sTFADl5/1cMABmY14A9MTpSczJ/UeyYBecJzWWgeqRszjMFBVh2hD502447dn2WV84 A4EFl6VdDu2+Rka4RLoPVigenVG7QoDLUJEyDfY74P48w8tIREs88eVZtX+v2OeIsUCf AblBhcXyFsyPb0/irKqJvIMh2kREFe8rlZSUraigtLG1jipR0Sx32gKCerUW6RuMxmlF Kuuy1mJxESBKfJyPm4ICAG842bW2oUubZeDfreZWLD9nL03R3mtTYzVQAw8hY7Cnrw4Y b6AENUgQRpG7JwN7XNR3ayx6c6PMvw2CbWS2mMhGxGzRHsNo+lJDCmzL5uhkSlySIYeX Qc1Q== X-Gm-Message-State: AOJu0YzRhPPqGqEzFjoFq2CgwH4y4/s2+V+BnyEkS2Y4FJlFCxYMuVf9 wz0tJyf+SDUO+NnQ/kW7tV6HEA== X-Received: by 2002:adf:e885:0:b0:31f:9bd6:e8c3 with SMTP id d5-20020adfe885000000b0031f9bd6e8c3mr1744751wrm.22.1694605822422; Wed, 13 Sep 2023 04:50:22 -0700 (PDT) Received: from brgl-uxlite.home ([2a01:cb1d:334:ac00:3b50:bca5:a754:7463]) by smtp.gmail.com with ESMTPSA id j14-20020adfd20e000000b0031fc4c31d77sm1932689wrh.88.2023.09.13.04.50.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 04:50:21 -0700 (PDT) From: Bartosz Golaszewski <brgl@bgdev.pl> To: Linus Walleij <linus.walleij@linaro.org>, Andy Shevchenko <andy@kernel.org>, Ulf Hansson <ulf.hansson@linaro.org>, Paul Cercueil <paul@crapouillou.net>, Harvey Hunt <harveyhuntnexus@gmail.com>, Miquel Raynal <miquel.raynal@bootlin.com>, Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>, Daniel Scally <djrscally@gmail.com>, Hans de Goede <hdegoede@redhat.com>, Mark Gross <markgross@kernel.org>, Heiner Kallweit <hkallweit1@gmail.com> Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mips@vger.kernel.org, linux-mtd@lists.infradead.org, platform-driver-x86@vger.kernel.org, Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Subject: [PATCH 4/5] platform/x86: int3472/discrete: use gpiod_set_active_low() Date: Wed, 13 Sep 2023 13:50:00 +0200 Message-Id: <20230913115001.23183-5-brgl@bgdev.pl> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230913115001.23183-1-brgl@bgdev.pl> References: <20230913115001.23183-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 13 Sep 2023 04:50:41 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776932389962628782 X-GMAIL-MSGID: 1776932389962628782 |
Series |
gpio: remove gpiod_toggle_active_low()
|
|
Commit Message
Bartosz Golaszewski
Sept. 13, 2023, 11:50 a.m. UTC
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Use the new polarity setter instead of the more cumbersome toggle function. Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> --- drivers/platform/x86/intel/int3472/clk_and_regulator.c | 2 +- drivers/platform/x86/intel/int3472/led.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
Comments
Hi, On 9/13/23 13:50, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Use the new polarity setter instead of the more cumbersome toggle > function. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > --- > drivers/platform/x86/intel/int3472/clk_and_regulator.c | 2 +- > drivers/platform/x86/intel/int3472/led.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/intel/int3472/clk_and_regulator.c b/drivers/platform/x86/intel/int3472/clk_and_regulator.c > index ef4b3141efcd..31e520838b95 100644 > --- a/drivers/platform/x86/intel/int3472/clk_and_regulator.c > +++ b/drivers/platform/x86/intel/int3472/clk_and_regulator.c > @@ -183,7 +183,7 @@ int skl_int3472_register_gpio_clock(struct int3472_discrete_device *int3472, > } > > if (polarity == GPIO_ACTIVE_LOW) > - gpiod_toggle_active_low(int3472->clock.ena_gpio); > + gpiod_set_active_low(int3472->clock.ena_gpio); > > /* Ensure the pin is in output mode and non-active state */ > gpiod_direction_output(int3472->clock.ena_gpio, 0); > diff --git a/drivers/platform/x86/intel/int3472/led.c b/drivers/platform/x86/intel/int3472/led.c > index bca1ce7d0d0c..46c9c569df5e 100644 > --- a/drivers/platform/x86/intel/int3472/led.c > +++ b/drivers/platform/x86/intel/int3472/led.c > @@ -32,7 +32,7 @@ int skl_int3472_register_pled(struct int3472_discrete_device *int3472, > "getting privacy LED GPIO\n"); > > if (polarity == GPIO_ACTIVE_LOW) > - gpiod_toggle_active_low(int3472->pled.gpio); > + gpiod_set_active_low(int3472->pled.gpio); > > /* Ensure the pin is in output mode and non-active state */ > gpiod_direction_output(int3472->pled.gpio, 0); Thanks. I agree that the new API is much better: Acked-by: Hans de Goede <hdegoede@redhat.com> Feel free to merge this through the GPIO tree. Regards, Hans
diff --git a/drivers/platform/x86/intel/int3472/clk_and_regulator.c b/drivers/platform/x86/intel/int3472/clk_and_regulator.c index ef4b3141efcd..31e520838b95 100644 --- a/drivers/platform/x86/intel/int3472/clk_and_regulator.c +++ b/drivers/platform/x86/intel/int3472/clk_and_regulator.c @@ -183,7 +183,7 @@ int skl_int3472_register_gpio_clock(struct int3472_discrete_device *int3472, } if (polarity == GPIO_ACTIVE_LOW) - gpiod_toggle_active_low(int3472->clock.ena_gpio); + gpiod_set_active_low(int3472->clock.ena_gpio); /* Ensure the pin is in output mode and non-active state */ gpiod_direction_output(int3472->clock.ena_gpio, 0); diff --git a/drivers/platform/x86/intel/int3472/led.c b/drivers/platform/x86/intel/int3472/led.c index bca1ce7d0d0c..46c9c569df5e 100644 --- a/drivers/platform/x86/intel/int3472/led.c +++ b/drivers/platform/x86/intel/int3472/led.c @@ -32,7 +32,7 @@ int skl_int3472_register_pled(struct int3472_discrete_device *int3472, "getting privacy LED GPIO\n"); if (polarity == GPIO_ACTIVE_LOW) - gpiod_toggle_active_low(int3472->pled.gpio); + gpiod_set_active_low(int3472->pled.gpio); /* Ensure the pin is in output mode and non-active state */ gpiod_direction_output(int3472->pled.gpio, 0);