From patchwork Tue Sep 12 18:22:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 138367 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9ecd:0:b0:3f2:4152:657d with SMTP id t13csp601688vqx; Tue, 12 Sep 2023 11:30:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEgnO8GUcEwF8b4DeLUYADw9WGyTvdwrCvFH9maQvSwDTRGg0Zef0c53ycdoHXgzj78W45c X-Received: by 2002:a05:6a20:8f2a:b0:14c:a2e1:65ec with SMTP id b42-20020a056a208f2a00b0014ca2e165ecmr240837pzk.38.1694543436247; Tue, 12 Sep 2023 11:30:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694543436; cv=none; d=google.com; s=arc-20160816; b=1ERVjmhxVX91HZ1jmwHj7zXuZ7nLqIdZsM8y61VbW8cGg4lNtfV3m+/5BDSIcl0nTP xQde0z6nx+Z+y/P6lzvKGloJkBtQtUE/MpodVODoaXyjA08CIwsxyxDq0EpNZIys66m5 hFaTlUivJ+FXOw+t2TLCAheOpm0sU+T/tCaC8uyRJ/4vprGcxSdcwZLwwDHdSOMed5Oc HrjQandZkVEkQxxpeqQgchkTOPWGIzsWG3V0zJc/v48vQEeRZVXj48P8XXmVo6IV0EZF KQ0YskcSNWMT0f0ltS3RyEyLNAnuo81X7APakT7RzNZZcokWhiNGReEEhwe8CPQZYFvM YdTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=Pnzy4+7Heb5hCZOZeVLT5CsDr8/8INFqo+IZoAa3ASY=; fh=+TLGgU8p1ZLn0EkVGuAxO6nyt1mPp1f8nk1Y8831aus=; b=LcEo1Cv3sEg19Md8X9xmxSWRzdnn/VK7sS0x+KqGuO0orSw/qeyr7Xv8tzFvFEZ6MR OtEjP0ZWx+xgc0wMQX9/2cg5ysRda2DJUSnF/jTh+ZowmCsb7AZeKyni1fB0Nke/ezaR jsdqnvYv75Ir2iPXTOOyRMYDndFdamYM1hsjPFmRpD57UpX8vve1a8KTVBBA3bWEkdFs wFA16l5Jn98OC38JCYKeiPWqNy/34KInupbkiuuPGhoyme5Qx/SnJroLKCkayo1P+BJk MvieugiRLFmT3uGwY8sIbjtjKRti3H//hmT2DoofyND2ROhbdKaY0jv2NVnwVq2Szu5E S3bQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id ce11-20020a056a002a0b00b0068e3e4f5b90si8478534pfb.10.2023.09.12.11.30.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 11:30:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 7438E81BD3FE; Tue, 12 Sep 2023 11:22:38 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237349AbjILSW2 (ORCPT + 36 others); Tue, 12 Sep 2023 14:22:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233007AbjILSWZ (ORCPT ); Tue, 12 Sep 2023 14:22:25 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3051510D8; Tue, 12 Sep 2023 11:22:22 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5B27C433C7; Tue, 12 Sep 2023 18:22:21 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.96) (envelope-from ) id 1qg824-000JRV-16; Tue, 12 Sep 2023 14:22:40 -0400 Message-ID: <20230912182240.156094298@goodmis.org> User-Agent: quilt/0.66 Date: Tue, 12 Sep 2023 14:22:14 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Andrew Morton , stable@vger.kernel.org, Tero Kristo Subject: [for-linus][PATCH 1/3] tracing/synthetic: Print out u64 values properly References: <20230912182213.795801173@goodmis.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 12 Sep 2023 11:22:38 -0700 (PDT) X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776857578080969457 X-GMAIL-MSGID: 1776857578080969457 From: Tero Kristo The synth traces incorrectly print pointer to the synthetic event values instead of the actual value when using u64 type. Fix by addressing the contents of the union properly. Link: https://lore.kernel.org/linux-trace-kernel/20230911141704.3585965-1-tero.kristo@linux.intel.com Fixes: ddeea494a16f ("tracing/synthetic: Use union instead of casts") Cc: stable@vger.kernel.org Signed-off-by: Tero Kristo Signed-off-by: Steven Rostedt (Google) --- kernel/trace/trace_events_synth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace_events_synth.c b/kernel/trace/trace_events_synth.c index 9897d0bfcab7..14cb275a0bab 100644 --- a/kernel/trace/trace_events_synth.c +++ b/kernel/trace/trace_events_synth.c @@ -337,7 +337,7 @@ static void print_synth_event_num_val(struct trace_seq *s, break; default: - trace_seq_printf(s, print_fmt, name, val, space); + trace_seq_printf(s, print_fmt, name, val->as_u64, space); break; } }