From patchwork Tue Sep 12 15:52:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pratyush Yadav X-Patchwork-Id: 138466 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9ecd:0:b0:3f2:4152:657d with SMTP id t13csp716504vqx; Tue, 12 Sep 2023 15:27:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGEkvvVKPzi0J7YLMfITEYEJD+WnQJpOuZtZc6hjaE5KomvJM16FkL10BHpuXe6TCB1vpWk X-Received: by 2002:a17:902:ab51:b0:1bf:1320:9743 with SMTP id ij17-20020a170902ab5100b001bf13209743mr958820plb.45.1694557676022; Tue, 12 Sep 2023 15:27:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694557676; cv=none; d=google.com; s=arc-20160816; b=TnOned85UwXD6H7pj7wkz1w+sbH2Ce/zv+9MzAwok0thLYJVgwN3tTH5SuHFM4O/kh eXthJtG2xoS203hNnwnzVmxEs8gMHaQ2ForzQj/kSbc+kiqOCrnLN40Ad/7LiYQbf0EY ue7QlNtwx5IWw0lMLtDYWmHybWBWPG3vPuoMTu2QHefexjvRQTb13B2AsDhZkYYqQOSH 9EBv1D4D4laDIB/biVxWInkjqD8Oy/y1GvvAgBiGz4IlnqK1629qQtyiT3lkSLBB1MWn gvT24vi57NM3E4E0/2KRhJk6n3/SfZDtOxCebdLIm306bYew1zbQH31gJGS8p0fR4cLT MiPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=cCIAGD0EhSyg1g9Is9nI4Dr2kf8GMGSZY5kO3oFROQA=; fh=gCS3e+tTkHn8IsO0upJ21mX13qO6vHsLVsNGNNfjzZs=; b=tttqShqQi2xypSkoYkzv7lyGFdAnEIJI24tFyvXy6Hd+l6Ig4Tm+alzrnULT8uiWan 9HIrSIOsjDpjs6PhWVhjOKymEYxfrOXzvC2l3zzsz+CBfRi0dboYhW8Nwpe3ughp2TpV K0B36XUU1J1+TiWVPhcTNCWZmHMozHcFKzvaUnzYGREGnYmm5K7EQMYVUhx3oh29xc9P LPuqtf5nLWYMNxrndKpC0y5FJaSWU547Q5UIpq38Dch18W/ujBbwwjIgUBE+8NYk4l7D hDvgipUp4V35J2w2vD0b3WfG9zZNhe8PHjC16H2Ew20YKH9xjYU8R4EjlBBrQWDnNvB1 ikNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amazon.de header.s=amazon201209 header.b="t/Nt4gGb"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.de Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id w6-20020a636206000000b0056aa105b6a4si8375113pgb.79.2023.09.12.15.27.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 15:27:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@amazon.de header.s=amazon201209 header.b="t/Nt4gGb"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 14B8D81CDE2E; Tue, 12 Sep 2023 08:53:13 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236368AbjILPxJ (ORCPT + 37 others); Tue, 12 Sep 2023 11:53:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229661AbjILPxI (ORCPT ); Tue, 12 Sep 2023 11:53:08 -0400 Received: from smtp-fw-6002.amazon.com (smtp-fw-6002.amazon.com [52.95.49.90]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41AD910DE for ; Tue, 12 Sep 2023 08:53:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1694533985; x=1726069985; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=cCIAGD0EhSyg1g9Is9nI4Dr2kf8GMGSZY5kO3oFROQA=; b=t/Nt4gGbjFImWElwQRi7jVYoOpzNhv0ex5jhKbKLQByvHorVuvVJ6y8b xWvcagcNKhiDc2cplKjFhsPjErIca8HFvfD6PoPD857W1vEB5TIL/eU95 x89IW+VGpSq1eb1WbUvpSg5G/DYr+ATx8WfKLhx+b3fcvVromF1i08xyb s=; X-IronPort-AV: E=Sophos;i="6.02,139,1688428800"; d="scan'208";a="355873318" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-iad-1a-m6i4x-b5bd57cf.us-east-1.amazon.com) ([10.43.8.6]) by smtp-border-fw-6002.iad6.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Sep 2023 15:53:02 +0000 Received: from EX19D020EUA002.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-iad-1a-m6i4x-b5bd57cf.us-east-1.amazon.com (Postfix) with ESMTPS id 42D4A47852; Tue, 12 Sep 2023 15:53:00 +0000 (UTC) Received: from EX19D028EUC001.ant.amazon.com (10.252.61.241) by EX19D020EUA002.ant.amazon.com (10.252.50.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.37; Tue, 12 Sep 2023 15:52:59 +0000 Received: from EX19MTAUWA001.ant.amazon.com (10.250.64.204) by EX19D028EUC001.ant.amazon.com (10.252.61.241) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.37; Tue, 12 Sep 2023 15:52:59 +0000 Received: from dev-dsk-ptyadav-1c-37607b33.eu-west-1.amazon.com (10.15.11.255) by mail-relay.amazon.com (10.250.64.204) with Microsoft SMTP Server id 15.2.1118.37 via Frontend Transport; Tue, 12 Sep 2023 15:52:58 +0000 Received: by dev-dsk-ptyadav-1c-37607b33.eu-west-1.amazon.com (Postfix, from userid 23027615) id 342B720D5A; Tue, 12 Sep 2023 17:52:58 +0200 (CEST) From: Pratyush Yadav To: Keith Busch , Jens Axboe , "Christoph Hellwig" , Sagi Grimberg CC: Pratyush Yadav , , Subject: [PATCH v2] nvme-pci: do not set the NUMA node of device if it has none Date: Tue, 12 Sep 2023 17:52:49 +0200 Message-ID: <20230912155249.113009-1-ptyadav@amazon.de> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 12 Sep 2023 08:53:13 -0700 (PDT) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776849310016814013 X-GMAIL-MSGID: 1776872509513110745 If a device has no NUMA node information associated with it, the driver puts the device in node first_memory_node (say node 0). Not having a NUMA node and being associated with node 0 are completely different things and it makes little sense to mix the two. Signed-off-by: Pratyush Yadav --- Changes in v2: - Re-worded the commit message. drivers/nvme/host/pci.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 2f57da12d983..347cb5daebc3 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -2916,9 +2916,6 @@ static struct nvme_dev *nvme_pci_alloc_dev(struct pci_dev *pdev, struct nvme_dev *dev; int ret = -ENOMEM; - if (node == NUMA_NO_NODE) - set_dev_node(&pdev->dev, first_memory_node); - dev = kzalloc_node(sizeof(*dev), GFP_KERNEL, node); if (!dev) return ERR_PTR(-ENOMEM);