From patchwork Tue Sep 12 12:37:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 138275 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9ecd:0:b0:3f2:4152:657d with SMTP id t13csp496610vqx; Tue, 12 Sep 2023 08:43:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGwU6trLOqn+3qUz8WgJWP6sdji+gLvEGuafQl57UhHXWRcO6FHXatFi1zp8KBkrlbctZmf X-Received: by 2002:a05:6a20:244d:b0:153:591b:4101 with SMTP id t13-20020a056a20244d00b00153591b4101mr16052844pzc.49.1694533380033; Tue, 12 Sep 2023 08:43:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694533380; cv=none; d=google.com; s=arc-20160816; b=SlYpwGLfl9HmqukhjhozfVrCuwXEnFmORr3raemFVpxTJoSElWV6oUNxURZR1Hubk6 cGQyDvoUmxuWLfhVRCxKO3yrbKReL9zCAU+DbFuINq/eP4Zxia2twK+YsDtLh9soD9qA TptBofPvCEi++vQh7nNpE4SKX3P6xjPg6V1yJNf2ThOU05kPKnk9FV20Hfmjd7Wf1Q3a tXLXeLSM18J3dE8kGvjH1IlRpsWk1FNEXnaGnUlFPnRxCGIqLG8dsF+nyYF43vDgpw/l FPz0hmw/24koMtwQ4w20kRBns/jWzaxrrqBF8mp1guiexGNL/Y2miNMTDvvCS/wLnlXy BOIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=iPgIpG5TOZNPAt8S1evljl9V3lEAQHO8eSzeI6GnXt4=; fh=XG4WW3CNAL509GDoc/W3Ryl++WqlrKFHTUxG5J6uH4c=; b=nGtPyvbDt4B5T044cBMi1gYASOCKmloQsoHiDmXZVx+6m4s0pR1NfvjVO+7SJf8F7K 2M2MCozn5ypyA4SQFvRMZRBwanrQRn/0xrkuq5cvWQYQu7dGvngQtTRTjrWxyTIQU0Gq TejMat52vKbfka3r4ip1rt7UxX/jv+adst7PXyT58UmTRK6QyfF8iuTqdHA50agjNeKE 447BTX20T1FeOes63Q303APYZolIEPwNXTd9GfW2AUGwgIimrVZpGNh0MNdrmA9nsQ2T 9UYDsKrI1iAI3a6mn+djgHlL9wHhyxFn8b01+DY1Gl0hEPx2T9IFX/ushh+eerFmUjUv 0ARw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=QUvvzmsH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id l3-20020a633e03000000b005644f8fa12dsi8382577pga.335.2023.09.12.08.42.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 08:43:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=QUvvzmsH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id B386B81CDE02; Tue, 12 Sep 2023 05:38:05 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235229AbjILMhz (ORCPT + 37 others); Tue, 12 Sep 2023 08:37:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235208AbjILMhx (ORCPT ); Tue, 12 Sep 2023 08:37:53 -0400 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E71419F; Tue, 12 Sep 2023 05:37:48 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-401c90ed2ecso60012835e9.0; Tue, 12 Sep 2023 05:37:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694522267; x=1695127067; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iPgIpG5TOZNPAt8S1evljl9V3lEAQHO8eSzeI6GnXt4=; b=QUvvzmsHcWrsb7/vMtgO4JlEG+7lILTzCtRWevxVBXxSOldldIUp3nCeZUUzASYHwJ vB+Tey3lHIIrwfJ7UFnElFPlZGHoTcXjFG3TQTtDRpXyT3Lgtu0nt7sGkfzZDXrlTtdh Hvjd414+Z1Xff1FYLyQCIqior4Dhx3Wqvz/Sxwcw7sy/iKaabJZz2yDHF4357xLQoszr uotDK399JGEbBhKKT0OtDAYyNCdSHuHxM5hN3NTkLcz5GwDH5j58jm657gOd0oUwfvun 6dBL7wCUcDUdXAbSYfFQOVUwz0qUqGaoqRYhadshgSDAj4xkiBwt97SSFjyupPkmq5zH zPlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694522267; x=1695127067; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iPgIpG5TOZNPAt8S1evljl9V3lEAQHO8eSzeI6GnXt4=; b=q+VrSZs0OyTmdRq1vHAFpg8goYdK4NE5yyfc6PBxxojA1PXiK5sa3yoraePAU36ILd tH/sX3fBF8grNBmF+5PjEnkIt3Ph1ROHHSQl/9TUQW+ZoOMoaFkCR91B8e53Uwk35eva ZpHOokYnkqEgg5hxPnyvpj9KbdP+lXrmuXMj34ZjbchvqRMcOp96I3HC47tT6lfDB5tK msVe23TcidThCSHNvwWsVPsr+ZOVhRcIFUDqldxRrLTaZwr+0TkBqvJtffjDTqY6uBLp iuIQpi+xrVPPD7SvfHGshUEmShihnXZedCNAMJpLKYwNCbFsJut+1vXWESqaER3DilWy 2GGA== X-Gm-Message-State: AOJu0YzLhNHtWpzKHQkUmo25K7CrXMbnWgSRQ7H6NzvYkVNc5e/G8IiO 2YgAbxOI5/2A8A9aUFb++vM= X-Received: by 2002:a5d:4ac3:0:b0:31a:e772:ddf6 with SMTP id y3-20020a5d4ac3000000b0031ae772ddf6mr10792700wrs.39.1694522267081; Tue, 12 Sep 2023 05:37:47 -0700 (PDT) Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net. [80.193.200.194]) by smtp.gmail.com with ESMTPSA id j6-20020adfb306000000b003142c85fbcdsm8184474wrd.11.2023.09.12.05.37.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 05:37:46 -0700 (PDT) From: Colin Ian King To: Kent Overstreet , Brian Foster , linux-bcachefs@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/5][next] bcachefs: remove redundant initialization of pointer d Date: Tue, 12 Sep 2023 13:37:40 +0100 Message-Id: <20230912123744.3929609-2-colin.i.king@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230912123744.3929609-1-colin.i.king@gmail.com> References: <20230912123744.3929609-1-colin.i.king@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 12 Sep 2023 05:38:05 -0700 (PDT) X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776847033249375530 X-GMAIL-MSGID: 1776847033249375530 The pointer d is being initialized with a value that is never read, it is being re-assigned later on when it is used in a for-loop. The initialization is redundant and can be removed. Cleans up clang-scan build warning: fs/bcachefs/buckets.c:1303:25: warning: Value stored to 'd' during its initialization is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King --- fs/bcachefs/btree_update_interior.c | 2 +- fs/bcachefs/buckets.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/bcachefs/btree_update_interior.c b/fs/bcachefs/btree_update_interior.c index 73c950d2788e..35f7af297ac0 100644 --- a/fs/bcachefs/btree_update_interior.c +++ b/fs/bcachefs/btree_update_interior.c @@ -143,7 +143,7 @@ static size_t btree_node_u64s_with_format(struct btree *b, } /** - * btree_node_format_fits - check if we could rewrite node with a new format + * bch2_btree_node_format_fits - check if we could rewrite node with a new format * * This assumes all keys can pack with the new format -- it just checks if * the re-packed keys would fit inside the node itself. diff --git a/fs/bcachefs/buckets.c b/fs/bcachefs/buckets.c index c02c8c917a29..951f945bbc22 100644 --- a/fs/bcachefs/buckets.c +++ b/fs/bcachefs/buckets.c @@ -1300,7 +1300,7 @@ int bch2_trans_fs_usage_apply(struct btree_trans *trans, static int warned_disk_usage = 0; bool warn = false; unsigned disk_res_sectors = trans->disk_res ? trans->disk_res->sectors : 0; - struct replicas_delta *d = deltas->d, *d2; + struct replicas_delta *d, *d2; struct replicas_delta *top = (void *) deltas->d + deltas->used; struct bch_fs_usage *dst; s64 added = 0, should_not_have_added;