diff mbox series

[net-next] ipv6: mcast: Remove redundant comparison in igmp6_mcf_get_next()

Message ID 20230912084100.1502379-1-Ilia.Gavrilov@infotecs.ru
State New
Headers
Series [net-next] ipv6: mcast: Remove redundant comparison in igmp6_mcf_get_next() |

Commit Message

Gavrilov Ilia Sept. 12, 2023, 8:42 a.m. UTC 
  The 'state->im' value will always be non-zero after
the 'while' statement, so the check can be removed.

Found by InfoTeCS on behalf of Linux Verification Center
(linuxtesting.org) with SVACE.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Gavrilov Ilia <Ilia.Gavrilov@infotecs.ru>
---
Repost according to https://lore.kernel.org/all/cdc2183a-c79a-b4bd-2726-bd3a2d6d5440@kernel.org/
 net/ipv6/mcast.c | 2 --
 1 file changed, 2 deletions(-)

Comments

David Ahern Sept. 12, 2023, 3:43 p.m. UTC | #1 
On 9/12/23 2:42 AM, Gavrilov Ilia wrote:
> The 'state->im' value will always be non-zero after
> the 'while' statement, so the check can be removed.
> 
> Found by InfoTeCS on behalf of Linux Verification Center
> (linuxtesting.org) with SVACE.
> 
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Gavrilov Ilia <Ilia.Gavrilov@infotecs.ru>
> ---
> Repost according to https://lore.kernel.org/all/cdc2183a-c79a-b4bd-2726-bd3a2d6d5440@kernel.org/
>  net/ipv6/mcast.c | 2 --
>  1 file changed, 2 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@kernel.org>
patchwork-bot+netdevbpf@kernel.org Sept. 14, 2023, 3:40 p.m. UTC | #2 
Hello:

This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Tue, 12 Sep 2023 08:42:49 +0000 you wrote:
> The 'state->im' value will always be non-zero after
> the 'while' statement, so the check can be removed.
> 
> Found by InfoTeCS on behalf of Linux Verification Center
> (linuxtesting.org) with SVACE.
> 
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Gavrilov Ilia <Ilia.Gavrilov@infotecs.ru>
> 
> [...]

Here is the summary with links:
  - [net-next] ipv6: mcast: Remove redundant comparison in igmp6_mcf_get_next()
    https://git.kernel.org/netdev/net-next/c/59bb1d698028

You are awesome, thank you!
diff mbox series

Patch

diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c
index 5ce25bcb9974..421264a69e97 100644
--- a/net/ipv6/mcast.c
+++ b/net/ipv6/mcast.c
@@ -3011,8 +3011,6 @@  static struct ip6_sf_list *igmp6_mcf_get_next(struct seq_file *seq, struct ip6_s
 				continue;
 			state->im = rcu_dereference(state->idev->mc_list);
 		}
-		if (!state->im)
-			break;
 		psf = rcu_dereference(state->im->mca_sources);
 	}
 out: