[v3,1/2] dt-bindings: arm64: dts: mediatek: mt8365-evk: update compatible

Message ID 20230912072340.22862-1-macpaul.lin@mediatek.com
State New
Headers
Series [v3,1/2] dt-bindings: arm64: dts: mediatek: mt8365-evk: update compatible |

Commit Message

Macpaul Lin Sept. 12, 2023, 7:23 a.m. UTC
  Fix compatible of 'mediatek,mt8365-evk' from 'enum' to 'const'.

Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
---
 Documentation/devicetree/bindings/arm/mediatek.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

change for v2:
 - rebase this patch to follow the v5 patch set of mt8395.
  - depends on https://lore.kernel.org/lkml/20230909132819.21626-2-macpaul.lin@mediatek.com/T/
 - Fix description as a single board.

changes for v3:
 - rebase this patch to follow the v6 patch set of mt8395.
  - depends on https://lore.kernel.org/lkml/20230911115717.26184-1-macpaul.lin@mediatek.com/T/
 - drop "Fixes:" tag in commit message.
 - drop platform description update for mt8365-evk (Genio 350-EVK).
  

Comments

Krzysztof Kozlowski Sept. 12, 2023, 8:08 a.m. UTC | #1
On 12/09/2023 09:23, Macpaul Lin wrote:
> Fix compatible of 'mediatek,mt8365-evk' from 'enum' to 'const'.

What is there to fix? There is no bug... please describe why you are
doing changes.

> 
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> ---
>  Documentation/devicetree/bindings/arm/mediatek.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> change for v2:
>  - rebase this patch to follow the v5 patch set of mt8395.
>   - depends on https://lore.kernel.org/lkml/20230909132819.21626-2-macpaul.lin@mediatek.com/T/
>  - Fix description as a single board.
> 
> changes for v3:
>  - rebase this patch to follow the v6 patch set of mt8395.
>   - depends on https://lore.kernel.org/lkml/20230911115717.26184-1-macpaul.lin@mediatek.com/T/
>  - drop "Fixes:" tag in commit message.
>  - drop platform description update for mt8365-evk (Genio 350-EVK).
> 
> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> index 2e8ad49c3479..bab4fa0e8199 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> @@ -245,7 +245,7 @@ properties:
>                - mediatek,mt8183-pumpkin
>            - const: mediatek,mt8183
>        - items:
> -          - enum:
> +          - const:

Obviously this was not tested... Please test before sending.

Best regards,
Krzysztof
  
Macpaul Lin Sept. 12, 2023, 9:36 a.m. UTC | #2
On 9/12/23 16:08, Krzysztof Kozlowski wrote:
> 	
> 
> External email : Please do not click links or open attachments until you 
> have verified the sender or the content.
> 
> On 12/09/2023 09:23, Macpaul Lin wrote:
>> Fix compatible of 'mediatek,mt8365-evk' from 'enum' to 'const'.
> 
> What is there to fix? There is no bug... please describe why you are
> doing changes.
> 
>> 
>> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
>> ---
>>  Documentation/devicetree/bindings/arm/mediatek.yaml | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> change for v2:
>>  - rebase this patch to follow the v5 patch set of mt8395.
>>   - depends on https://lore.kernel.org/lkml/20230909132819.21626-2-macpaul.lin@mediatek.com/T/
>>  - Fix description as a single board.
>> 
>> changes for v3:
>>  - rebase this patch to follow the v6 patch set of mt8395.
>>   - depends on https://lore.kernel.org/lkml/20230911115717.26184-1-macpaul.lin@mediatek.com/T/
>>  - drop "Fixes:" tag in commit message.
>>  - drop platform description update for mt8365-evk (Genio 350-EVK).
>> 
>> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
>> index 2e8ad49c3479..bab4fa0e8199 100644
>> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
>> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
>> @@ -245,7 +245,7 @@ properties:
>>                - mediatek,mt8183-pumpkin
>>            - const: mediatek,mt8183
>>        - items:
>> -          - enum:
>> +          - const:
> 
> Obviously this was not tested... Please test before sending.
> 
> Best regards,
> Krzysztof
> 

I'm sorry, will be fixed in v4 with dtbs_check test.

Thanks
Macpaul Lin
  

Patch

diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
index 2e8ad49c3479..bab4fa0e8199 100644
--- a/Documentation/devicetree/bindings/arm/mediatek.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
@@ -245,7 +245,7 @@  properties:
               - mediatek,mt8183-pumpkin
           - const: mediatek,mt8183
       - items:
-          - enum:
+          - const:
               - mediatek,mt8365-evk
           - const: mediatek,mt8365
       - description: MediaTek Genio 1200 Boards (Genio 1200 EVK)