[v2,2/2] arm64: dts: qcom: sdm845: cheza doesn't support LMh node

Message ID 20230912071205.11502-2-david@ixit.cz
State New
Headers
Series [v2,1/2] arm64: dts: qcom: sdm845: Fix PSCI power domain names |

Commit Message

David Heidelberg Sept. 12, 2023, 7:12 a.m. UTC
  Cheza firmware doesn't allow controlling LMh from the operating system.

Fixes: 36c6581214c4 ("arm64: dts: qcom: sdm845: Add support for LMh node")
Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: David Heidelberg <david@ixit.cz>
---
v2:
 - moved power-domains removal from this patch to previous one, since
   it's not related to LMh support
 arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)
  

Comments

Stephen Boyd Sept. 12, 2023, 6:09 p.m. UTC | #1
Quoting David Heidelberg (2023-09-12 00:12:04)
> Cheza firmware doesn't allow controlling LMh from the operating system.
>
> Fixes: 36c6581214c4 ("arm64: dts: qcom: sdm845: Add support for LMh node")
> Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>
  
Doug Anderson Sept. 12, 2023, 11:30 p.m. UTC | #2
Hi,

On Tue, Sep 12, 2023 at 12:14 AM David Heidelberg <david@ixit.cz> wrote:
>
> Cheza firmware doesn't allow controlling LMh from the operating system.
>
> Fixes: 36c6581214c4 ("arm64: dts: qcom: sdm845: Add support for LMh node")
> Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> v2:
>  - moved power-domains removal from this patch to previous one, since
>    it's not related to LMh support
>  arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)

I haven't used a cheza in years, but this seems reasonable to me.

Reviewed-by: Douglas Anderson <dianders@chromium.org>
  

Patch

diff --git a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
index e0ee91225eec..e51bf02fbfe3 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
@@ -143,6 +143,10 @@  panel_in_edp: endpoint {
 	};
 };
 
+&cpufreq_hw {
+	/delete-property/ interrupts-extended; /* reference to lmh_cluster[01] */
+};
+
 &psci {
 	/delete-node/ power-domain-cpu0;
 	/delete-node/ power-domain-cpu1;
@@ -275,6 +279,14 @@  &BIG_CPU_SLEEP_1
 			   &CLUSTER_SLEEP_0>;
 };
 
+&lmh_cluster0 {
+	status = "disabled";
+};
+
+&lmh_cluster1 {
+	status = "disabled";
+};
+
 /*
  * Reserved memory changes
  *