From patchwork Tue Sep 12 07:58:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Gleixner X-Patchwork-Id: 138041 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9ecd:0:b0:3f2:4152:657d with SMTP id t13csp271205vqx; Tue, 12 Sep 2023 02:04:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEcubL5Q+0BjMJqRsOlAyFkWaQFXMphGEmuij8fqSA437AkY5efE2gKlIynWD1hZpx5bSLZ X-Received: by 2002:a05:6358:16c7:b0:141:51d:4c93 with SMTP id r7-20020a05635816c700b00141051d4c93mr3164777rwl.29.1694509462433; Tue, 12 Sep 2023 02:04:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694509462; cv=none; d=google.com; s=arc-20160816; b=qRDRVrooJse4+bMw9yrLmgzeEPV/WzsYs9VYQgdrbEJTZB91Idp45FXgtSkJZZ3Nre cf4Mc9iZLs4x5EuSEYeQfd/TG19GTlgK+MRlskotbZ3LVCJdAdJsT1i1lYquDmZfjfa8 tfMwkie7b1QBlxdCF47FiVRA4Fw4NE7AgghpdaRW1kbA6JinXShEOodP7BvhvctUEfT2 JR9uu7zChv4+pEjFi5/huY0zyVRhSFC+cXBd7+AvPcY/9KpnTQmeN90RsRpt0JL9TNvL El9J4fsxXLtuOiY27SXjtdZwjr11PxnzZ26Fb1VmHNaJgE2Qj6cIV61VOOTVrQZLt6ak CZvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:mime-version:references:subject:cc:to:from :dkim-signature:dkim-signature:message-id; bh=29AYhkI+1B+aP2ulSjBZYvwAxHR9z6zN13x7VQxgXac=; fh=u57tXYamzTrJA+Ht8n1u7SfTMptrQaIb6LVW+jsaYf4=; b=Ooky713Qc1zlrHl449t/Pu6PUndekE2tgwLtfmaN+ioRhWkC5MuiZ4/kotFr1F6eHK MkVBihgfNWMlWmYXFEHV6Myda2aTr0jaSmM9vylfLqgVyfFBnKtOV/X7m5PfZxKAwWPT jGiKnff2zSHh3oRt4gGyVBELs59HohoLOTw9d4iatbbEip0AT2JJfa6onT2ho8IzJUvo hH1XcI26zQj7pmRBlJ1wGY57v880qs1HDRVNb5NHPK3vHlFcEAs2QfP0Nk+H+GisjTgy ciT1+QVCtz0yGUJqkh0QFu8lMh5GlgeyJaTyb07k/HQQi9oiG9angAxt+prL+7hjCO5X 3FFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=o5K9GLXM; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=KBTh1d6S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id m187-20020a6326c4000000b005648d3f2031si7703297pgm.362.2023.09.12.02.04.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 02:04:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=o5K9GLXM; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=KBTh1d6S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 793AB8271DF5; Tue, 12 Sep 2023 00:59:20 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232062AbjILH7N (ORCPT + 39 others); Tue, 12 Sep 2023 03:59:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232090AbjILH6l (ORCPT ); Tue, 12 Sep 2023 03:58:41 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E6DB2102 for ; Tue, 12 Sep 2023 00:58:12 -0700 (PDT) Message-ID: <20230912065501.838955709@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1694505491; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=29AYhkI+1B+aP2ulSjBZYvwAxHR9z6zN13x7VQxgXac=; b=o5K9GLXM3XJpdsaGpiBbbxvmmBIEGDFBMHADfwXSBVH3+l+2a6D+OMu0ia1mVRFIBR+2/W uqhaCgGahmSxDrsgnpSSfKNZgh2/GoQ9wgUxow4iRFVmePrffytWctRvaSFsl+96+kX74g zlJgwaZvvgCQmI6EiyN6ZGRhVwjXgtKyuA0JdnL86v769V7k0rqWg+VX12BZ81XK90BKrx UDfvQWrLaM5X5TCNsxvuQju+uFM5ejimEM0tmkqd6UFbmMKHK4NoN//og2uzek166vUZS3 SmYm44zVjymVBgVX0RHw8UiGBGFkOnvzrc5lpTvDA2aOkRo55AUu6Zu3sgCdLg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1694505491; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=29AYhkI+1B+aP2ulSjBZYvwAxHR9z6zN13x7VQxgXac=; b=KBTh1d6SrsaSukcbTTTJGUkoMfBfIkLyuLjz/8JnxI6kpyDX2Zvx2BOGrpl8ML2w5Q8AHK rbusKTV3I4h1YaDQ== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, Borislav Petkov , "Chang S. Bae" , Arjan van de Ven , Nikolay Borisov Subject: [patch V3 17/30] x86/microcode: Clean up mc_cpu_down_prep() References: <20230912065249.695681286@linutronix.de> MIME-Version: 1.0 Date: Tue, 12 Sep 2023 09:58:10 +0200 (CEST) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 12 Sep 2023 00:59:20 -0700 (PDT) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776821953648501676 X-GMAIL-MSGID: 1776821953648501676 This function has nothing to do with suspend. It's a hotplug callback. Remove the bogus comment. Drop the pointless debug printk. The hotplug core provides tracepoints which track the invocation of those callbacks. Signed-off-by: Thomas Gleixner --- V2: New patch --- arch/x86/kernel/cpu/microcode/core.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) --- a/arch/x86/kernel/cpu/microcode/core.c +++ b/arch/x86/kernel/cpu/microcode/core.c @@ -569,16 +569,10 @@ static int mc_cpu_online(unsigned int cp static int mc_cpu_down_prep(unsigned int cpu) { - struct device *dev; - - dev = get_cpu_device(cpu); + struct device *dev = get_cpu_device(cpu); microcode_fini_cpu(cpu); - - /* Suspend is in progress, only remove the interface */ sysfs_remove_group(&dev->kobj, &mc_attr_group); - pr_debug("%s: CPU%d\n", __func__, cpu); - return 0; }