From patchwork Tue Sep 12 07:58:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Gleixner X-Patchwork-Id: 138134 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9ecd:0:b0:3f2:4152:657d with SMTP id t13csp363592vqx; Tue, 12 Sep 2023 05:17:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHekImx7nU0hvZo3awouLcbXM1r9zBSKAlgiCnigQAn0SlekTT3wPvOwO2AgiU2s/0To+ka X-Received: by 2002:a05:6a00:17a2:b0:68f:d44c:22f8 with SMTP id s34-20020a056a0017a200b0068fd44c22f8mr3505820pfg.1.1694521062508; Tue, 12 Sep 2023 05:17:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694521062; cv=none; d=google.com; s=arc-20160816; b=SunAwKZrdNbCQHvf+qnZPJLEUvCF5SyF0EylGmTmVyP0leGmNItJNEL5kV1jQ95d1A N8Y90iNo7gxMXTsx8AVXrEnRwiT2+vEyoSxGJ0nIxJZxjzF13mohDb4+epaQnQu2zWv2 sFNPlaC2wn1higfxSuANg/HcobDt+GZfUNJTkRGhy5SINw7DfDxxIClRpg6L9snJD0p/ CbUWwHxDLTVoXHMqDGVTaE40GDIwzrVN1jSgzPhVs1xSxGyZe4zrvkoZGvBrRHJ2ALCD Lxa5+VBYF0AAcNSPc7nygP9dbeMlphmvM20bM45Ln1J0L3lfKdmMMKt0rhSqsCnwLZ1i kFaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:mime-version:references:subject:cc:to:from :dkim-signature:dkim-signature:message-id; bh=dBHUwt2VZzLKlhZD7lus6ZMnFKpXbbWJtwBvilrxafU=; fh=u57tXYamzTrJA+Ht8n1u7SfTMptrQaIb6LVW+jsaYf4=; b=T+sHTQDopXdhDkmo0zOJQtuOfU223AV5UEmW2S1Ye9j9rd0RlZBqIBehH32/0RKAwa 12HoGdTCU6iES39a9JxmdVcVtRtXyWnyvyP0S3jiIDJdRw7JVZyLtEHZwK1wdP0Cqxnw 12XAgDw/WIwdIl3qi/bobXh2962xmDYbPLyc+MPF4MkA5fF2dt/aQvs8IP8MpYv0ZYBZ xTtfUPXitQfKuHKaGYuUNuBmS2S32/pKR6XtytUNIzMKx5FRzY2i2iJH8ra0MBh5EhhF ejgF0GyfZKhY5RbqZtr4EIOrJgtptu8qB4yU4y2HOCHFR9OwaLQOw1CozJm4VEaPoGj9 2YSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=WNmU6iY9; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id az1-20020a056a02004100b005776a454f3csi3788644pgb.379.2023.09.12.05.17.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 05:17:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=WNmU6iY9; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id CC311818D53E; Tue, 12 Sep 2023 00:59:55 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232145AbjILH7G (ORCPT + 39 others); Tue, 12 Sep 2023 03:59:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232157AbjILH6k (ORCPT ); Tue, 12 Sep 2023 03:58:40 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B32C51BEA for ; Tue, 12 Sep 2023 00:58:10 -0700 (PDT) Message-ID: <20230912065501.777893171@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1694505489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=dBHUwt2VZzLKlhZD7lus6ZMnFKpXbbWJtwBvilrxafU=; b=WNmU6iY9mLJRMZGkGeQdBmj9PHK4NojOS348gK8kWx9n8wdhoIQtZv+pFsYG1i3+ow8lWJ i5Dmy30dLW1n/mUZasLMRQA8Pzl/HDnc14N+gw75DEqGyTaVK3ZQU/bhF9GNV9Lhl9JcYv s/TD/8kBRb3/AwVOcoKuBpDbrkIK4F6fHySkjTJiSx+314zh33lWZrGuS16Y7pONHPOvm5 RndoYo0gGdYKfoREkUS1gDSMkrXBzPfiogcW85PxfTvfyNbsYfac1qEFedxqXQY5qy8hQ1 CEESiNxNiQnnLFxKJrTdyrXu1uMvArjl+2i/6SbXsARUIJHGfoUeW3M5AtZ+9Q== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1694505489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=dBHUwt2VZzLKlhZD7lus6ZMnFKpXbbWJtwBvilrxafU=; b=fyo9/Q/8h/II6rdgCACFg1uN+807cKfPKMZbwfGmdh4g0z+kmveZDimC6jbu4fUdWuETXx WWkhie4MYJZXqRAg== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, Borislav Petkov , "Chang S. Bae" , Arjan van de Ven , Nikolay Borisov Subject: [patch V3 16/30] x86/microcode: Get rid of the schedule work indirection References: <20230912065249.695681286@linutronix.de> MIME-Version: 1.0 Date: Tue, 12 Sep 2023 09:58:08 +0200 (CEST) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 12 Sep 2023 00:59:55 -0700 (PDT) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776834117748859147 X-GMAIL-MSGID: 1776834117748859147 Scheduling work on all CPUs to collect the microcode information is just another extra step for no value. Let the CPU hotplug callback registration do it. Signed-off-by: Thomas Gleixner --- V2: New patch --- arch/x86/kernel/cpu/microcode/core.c | 29 ++++++++++------------------- 1 file changed, 10 insertions(+), 19 deletions(-) --- a/arch/x86/kernel/cpu/microcode/core.c +++ b/arch/x86/kernel/cpu/microcode/core.c @@ -531,8 +531,16 @@ static struct syscore_ops mc_syscore_ops static int mc_cpu_online(unsigned int cpu) { + struct ucode_cpu_info *uci = ucode_cpu_info + cpu; struct device *dev = get_cpu_device(cpu); + memset(uci, 0, sizeof(*uci)); + + microcode_ops->collect_cpu_info(cpu, &uci->cpu_sig); + cpu_data(cpu).microcode = uci->cpu_sig.rev; + if (!cpu) + boot_cpu_data.microcode = uci->cpu_sig.rev; + if (sysfs_create_group(&dev->kobj, &mc_attr_group)) pr_err("Failed to create group for CPU%d\n", cpu); return 0; @@ -553,20 +561,6 @@ static int mc_cpu_down_prep(unsigned int return 0; } -static void setup_online_cpu(struct work_struct *work) -{ - int cpu = smp_processor_id(); - struct ucode_cpu_info *uci = ucode_cpu_info + cpu; - - memset(uci, 0, sizeof(*uci)); - - microcode_ops->collect_cpu_info(cpu, &uci->cpu_sig); - cpu_data(cpu).microcode = uci->cpu_sig.rev; - if (!cpu) - boot_cpu_data.microcode = uci->cpu_sig.rev; - mc_cpu_online(cpu); -} - static struct attribute *cpu_root_microcode_attrs[] = { #ifdef CONFIG_MICROCODE_LATE_LOADING &dev_attr_reload.attr, @@ -612,12 +606,9 @@ static int __init microcode_init(void) } } - /* Do per-CPU setup */ - schedule_on_each_cpu(setup_online_cpu); - register_syscore_ops(&mc_syscore_ops); - cpuhp_setup_state_nocalls(CPUHP_AP_ONLINE_DYN, "x86/microcode:online", - mc_cpu_online, mc_cpu_down_prep); + cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "x86/microcode:online", + mc_cpu_online, mc_cpu_down_prep); pr_info("Microcode Update Driver: v%s.", DRIVER_VERSION);