Message ID | 20230911214609.2201040-1-robh@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9ecd:0:b0:3f2:4152:657d with SMTP id t13csp198996vqx; Mon, 11 Sep 2023 23:01:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHBSh7ATdnoqFQLfz5nHR5Nne1mXMWma30XqhBR8bEo2wUaE6DCKvvVZ4Hod2bQJnNb7z6a X-Received: by 2002:a05:6a20:12d6:b0:141:d54e:a907 with SMTP id v22-20020a056a2012d600b00141d54ea907mr12914033pzg.19.1694498496639; Mon, 11 Sep 2023 23:01:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694498496; cv=none; d=google.com; s=arc-20160816; b=V+TWW4w1DQ6XOCn9lNfUhmRN9LykbMHQ7b8P/n/orxTXRnnLg1Cx0RZN/CyyYyydoe e0dJXnxJAOeIeAOSVBdjT0IZpYlNPN+9w/FDk1ppU20SUyUJnHWD0kbBXV90rP/BnzJ7 KjaxPI4qCsstBI1jZBmTU6aLI917WSFaUIDMhIdcZwVn+e57E/+ld+4rmcVel5rWM8In znvR/pXRqbAmhvz8XVTouVUZvtytIc/OHD5y8JmbgvUuZU0cIKxQYz4FwnXhf/YaMiPz f7HnBBKDF9T9ecw5QE9Sxas1IdcIRH1baoMVmryMgm1ID0VXlPnOSLIkSwdp2mF7fgUe s/tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=R23pudbz+LHibrZx6hUdoCnCE+CmukXevRlW99aZjpI=; fh=fJCylndCv2+yrr/ozQlvEimzYBlnw16/X5lJEwvChKI=; b=B33G3Ap1jLoImLadZdK4HZ+M+36WL2mVyn7Bx2w3a7fgxHDmRDvhh2POK0udgeh0m8 4N0GlBtaRAit8H2ngFAvZcZdKR0JSpdtzoYM0aEaFIxRiQExCLYV9ekknNSDfPFR+bvf dqFqGpl4joigpe0wa0Q/K/o5+maEZU4x95Cw38qHQbi3DImtw/sSerAyDtN0aglbLZwB I1SBmrX8vI9W5/qclCJIOTaXc9IGPhovu+nqLXDyIPzO6Te1qjuAFRsq94I5Ujejt0ae /P1oPAVn2ZD4NXG8so35Edu6ATAPwu7Xp/4BrxwcEScj/5bEU14p+O6CRX1Lonm5bZjt 1/sA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Jq/ie0C1"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id fb35-20020a056a002da300b0068a5acb2719si7540565pfb.199.2023.09.11.23.01.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Sep 2023 23:01:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Jq/ie0C1"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 51EEF8233645; Mon, 11 Sep 2023 21:32:23 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238618AbjILC2m (ORCPT <rfc822;ivan.orlov0322@gmail.com> + 83 others); Mon, 11 Sep 2023 22:28:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237703AbjILC2J (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 11 Sep 2023 22:28:09 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B1F6134D3C; Mon, 11 Sep 2023 18:52:26 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24B41C433BF; Mon, 11 Sep 2023 21:46:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694468775; bh=vY7vawU4FZYoEgdX4LDl+2Hb+tqanE/PYLPwILCYrzU=; h=From:To:Cc:Subject:Date:From; b=Jq/ie0C175g+KTBPmu5n84htYUDAi1mRxI4NyK4fvQTjM/LuZlK054qvUoGSVWBzb lqMpADHgNYUdroXydWBpFZlhaQozAOY4m5iRRFs+I+ZmhO4muIR2bLcUeQhezgf45G 21njU3Mvd9JBaEWU50PZVrC8Zwj7Ta9k0bijWDJofATThy0FTB86ha/WcMscp+Ie44 t2aD14HVwW71epMXTsOf9x21tQr6Ug90O2jsy3XTAe1LosUODEYb8zExGVkKorjx6e eU+/aYK3spBILJv7mFcFNwbKv740fdloCJf8IQpISjz7v75RYqWIvga+qJ6atpsIPV 8iMopSVxgiPiQ== Received: (nullmailer pid 2201291 invoked by uid 1000); Mon, 11 Sep 2023 21:46:13 -0000 From: Rob Herring <robh@kernel.org> To: =?utf-8?q?Beno=C3=AEt_Cousson?= <bcousson@baylibre.com>, Tony Lindgren <tony@atomide.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org> Cc: linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] arm: dts: omap: Apply am57xx-idk overlays to base dtbs Date: Mon, 11 Sep 2023 16:46:02 -0500 Message-Id: <20230911214609.2201040-1-robh@kernel.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 11 Sep 2023 21:32:23 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776810455560707334 X-GMAIL-MSGID: 1776810455560707334 |
Series |
arm: dts: omap: Apply am57xx-idk overlays to base dtbs
|
|
Commit Message
Rob Herring
Sept. 11, 2023, 9:46 p.m. UTC
DT overlays in tree need to be applied to a base DTB to validate they
apply, to run schema checks on them, and to catch any errors at compile
time.
Signed-off-by: Rob Herring <robh@kernel.org>
---
Note that I have no idea if this combination of overlays makes sense.
---
arch/arm/boot/dts/ti/omap/Makefile | 7 +++++++
1 file changed, 7 insertions(+)
Comments
* Rob Herring <robh@kernel.org> [230911 21:46]: > DT overlays in tree need to be applied to a base DTB to validate they > apply, to run schema checks on them, and to catch any errors at compile > time. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > Note that I have no idea if this combination of overlays makes sense. Adding Andrew to review this. Regards, Tony --- > arch/arm/boot/dts/ti/omap/Makefile | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/boot/dts/ti/omap/Makefile b/arch/arm/boot/dts/ti/omap/Makefile > index d2b590004fed..d0c76d09fe70 100644 > --- a/arch/arm/boot/dts/ti/omap/Makefile > +++ b/arch/arm/boot/dts/ti/omap/Makefile > @@ -129,6 +129,11 @@ dtb-$(CONFIG_SOC_AM43XX) += \ > am57xx-evm-dtbs := am57xx-beagle-x15.dtb am57xx-evm.dtbo > am57xx-evm-reva3-dtbs := am57xx-beagle-x15-revc.dtb am57xx-evm.dtbo > > +am571x-idk-overlays-dtbs := am571x-idk.dtb \ > + am571x-idk-touchscreen.dtbo am57xx-idk-lcd-osd101t2587.dtbo > +am572x-idk-overlays-dtbs := am572x-idk.dtb \ > + am572x-idk-touchscreen.dtbo am57xx-idk-lcd-osd101t2045.dtbo > + > dtb-$(CONFIG_SOC_DRA7XX) += \ > am57xx-beagle-x15.dtb \ > am57xx-beagle-x15-revb1.dtb \ > @@ -145,6 +150,8 @@ dtb-$(CONFIG_SOC_DRA7XX) += \ > am574x-idk.dtb \ > am57xx-idk-lcd-osd101t2045.dtbo \ > am57xx-idk-lcd-osd101t2587.dtbo \ > + am571x-idk-overlays.dtb \ > + am572x-idk-overlays.dtb \ > dra7-evm.dtb \ > dra72-evm.dtb \ > dra72-evm-revc.dtb \ > -- > 2.40.1 >
On 9/12/23 1:59 AM, Tony Lindgren wrote: > * Rob Herring <robh@kernel.org> [230911 21:46]: >> DT overlays in tree need to be applied to a base DTB to validate they >> apply, to run schema checks on them, and to catch any errors at compile >> time. >> >> Signed-off-by: Rob Herring <robh@kernel.org> >> --- >> Note that I have no idea if this combination of overlays makes sense. > It does make sense, but it is only one of many valid combinations. I'm guessing the goal here is just to make sure they all get applied in at least one way so the scheme check runs. In that case this is fine other than it might give the impression this is the only valid combinations. Also now we end up with these odd `am57{1,2}x-idk-overlays.dtb` files which also might confuse folks, I wonder if there is some way to apply and check, but not ship/install these.. Andrew > Adding Andrew to review this. > > Regards, > > Tony > > --- >> arch/arm/boot/dts/ti/omap/Makefile | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/arch/arm/boot/dts/ti/omap/Makefile b/arch/arm/boot/dts/ti/omap/Makefile >> index d2b590004fed..d0c76d09fe70 100644 >> --- a/arch/arm/boot/dts/ti/omap/Makefile >> +++ b/arch/arm/boot/dts/ti/omap/Makefile >> @@ -129,6 +129,11 @@ dtb-$(CONFIG_SOC_AM43XX) += \ >> am57xx-evm-dtbs := am57xx-beagle-x15.dtb am57xx-evm.dtbo >> am57xx-evm-reva3-dtbs := am57xx-beagle-x15-revc.dtb am57xx-evm.dtbo >> >> +am571x-idk-overlays-dtbs := am571x-idk.dtb \ >> + am571x-idk-touchscreen.dtbo am57xx-idk-lcd-osd101t2587.dtbo >> +am572x-idk-overlays-dtbs := am572x-idk.dtb \ >> + am572x-idk-touchscreen.dtbo am57xx-idk-lcd-osd101t2045.dtbo >> + >> dtb-$(CONFIG_SOC_DRA7XX) += \ >> am57xx-beagle-x15.dtb \ >> am57xx-beagle-x15-revb1.dtb \ >> @@ -145,6 +150,8 @@ dtb-$(CONFIG_SOC_DRA7XX) += \ >> am574x-idk.dtb \ >> am57xx-idk-lcd-osd101t2045.dtbo \ >> am57xx-idk-lcd-osd101t2587.dtbo \ >> + am571x-idk-overlays.dtb \ >> + am572x-idk-overlays.dtb \ >> dra7-evm.dtb \ >> dra72-evm.dtb \ >> dra72-evm-revc.dtb \ >> -- >> 2.40.1 >>
On Fri, Sep 22, 2023 at 9:38 AM Andrew Davis <afd@ti.com> wrote: > > On 9/12/23 1:59 AM, Tony Lindgren wrote: > > * Rob Herring <robh@kernel.org> [230911 21:46]: > >> DT overlays in tree need to be applied to a base DTB to validate they > >> apply, to run schema checks on them, and to catch any errors at compile > >> time. > >> > >> Signed-off-by: Rob Herring <robh@kernel.org> > >> --- > >> Note that I have no idea if this combination of overlays makes sense. > > > > It does make sense, but it is only one of many valid combinations. I'm > guessing the goal here is just to make sure they all get applied in > at least one way so the scheme check runs. In that case this is fine > other than it might give the impression this is the only valid combinations. I only care that an overlay is applied to one base. You should care about any combination a user might do in a bootloader because who wants to debug a failure a) on a board and b) in the bootloader. > Also now we end up with these odd `am57{1,2}x-idk-overlays.dtb` files > which also might confuse folks, I wonder if there is some way to > apply and check, but not ship/install these.. There's already a config option, CONFIG_OF_ALL_DTBS, which adds $(dtb-) entries to the build. So if you have "dtb- += foo-overlays.dtb" it will only be built in that case. Note that they'd probably get installed too, but who installs allyesconfig builds. Rob
* Rob Herring <robh@kernel.org> [230922 16:23]: > On Fri, Sep 22, 2023 at 9:38 AM Andrew Davis <afd@ti.com> wrote: > > > > On 9/12/23 1:59 AM, Tony Lindgren wrote: > > > * Rob Herring <robh@kernel.org> [230911 21:46]: > > >> DT overlays in tree need to be applied to a base DTB to validate they > > >> apply, to run schema checks on them, and to catch any errors at compile > > >> time. > > >> > > >> Signed-off-by: Rob Herring <robh@kernel.org> > > >> --- > > >> Note that I have no idea if this combination of overlays makes sense. > > > > > > > It does make sense, but it is only one of many valid combinations. I'm > > guessing the goal here is just to make sure they all get applied in > > at least one way so the scheme check runs. In that case this is fine > > other than it might give the impression this is the only valid combinations. > > I only care that an overlay is applied to one base. You should care > about any combination a user might do in a bootloader because who > wants to debug a failure a) on a board and b) in the bootloader. > > > Also now we end up with these odd `am57{1,2}x-idk-overlays.dtb` files > > which also might confuse folks, I wonder if there is some way to > > apply and check, but not ship/install these.. > > There's already a config option, CONFIG_OF_ALL_DTBS, which adds > $(dtb-) entries to the build. So if you have "dtb- += > foo-overlays.dtb" it will only be built in that case. Note that they'd > probably get installed too, but who installs allyesconfig builds. So what's the conclusion here? Is this safe to apply yes or no? Regards, Tony
diff --git a/arch/arm/boot/dts/ti/omap/Makefile b/arch/arm/boot/dts/ti/omap/Makefile index d2b590004fed..d0c76d09fe70 100644 --- a/arch/arm/boot/dts/ti/omap/Makefile +++ b/arch/arm/boot/dts/ti/omap/Makefile @@ -129,6 +129,11 @@ dtb-$(CONFIG_SOC_AM43XX) += \ am57xx-evm-dtbs := am57xx-beagle-x15.dtb am57xx-evm.dtbo am57xx-evm-reva3-dtbs := am57xx-beagle-x15-revc.dtb am57xx-evm.dtbo +am571x-idk-overlays-dtbs := am571x-idk.dtb \ + am571x-idk-touchscreen.dtbo am57xx-idk-lcd-osd101t2587.dtbo +am572x-idk-overlays-dtbs := am572x-idk.dtb \ + am572x-idk-touchscreen.dtbo am57xx-idk-lcd-osd101t2045.dtbo + dtb-$(CONFIG_SOC_DRA7XX) += \ am57xx-beagle-x15.dtb \ am57xx-beagle-x15-revb1.dtb \ @@ -145,6 +150,8 @@ dtb-$(CONFIG_SOC_DRA7XX) += \ am574x-idk.dtb \ am57xx-idk-lcd-osd101t2045.dtbo \ am57xx-idk-lcd-osd101t2587.dtbo \ + am571x-idk-overlays.dtb \ + am572x-idk-overlays.dtb \ dra7-evm.dtb \ dra72-evm.dtb \ dra72-evm-revc.dtb \