From patchwork Fri Sep 8 20:35:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frederic Weisbecker X-Patchwork-Id: 137798 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ab0a:0:b0:3f2:4152:657d with SMTP id m10csp807262vqo; Fri, 8 Sep 2023 14:46:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFrBZzjlVyCi/weBpBJk1CnlHOCpfpAs5NYL7Ww4+9+qsAzoEkePUVMMXP5L5pL648YYYnx X-Received: by 2002:a17:903:244f:b0:1c1:d730:f0cf with SMTP id l15-20020a170903244f00b001c1d730f0cfmr4204698pls.20.1694209613379; Fri, 08 Sep 2023 14:46:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694209613; cv=none; d=google.com; s=arc-20160816; b=lxNf/YKwKD/bN54Pd27q8S356428Jbom9Di3CV9WlTFUnekMqPGj44qpVVUZhHrh+j PkuhmdnorkzMMjJr4Y3f48T22TeZRyx3N7IyccWOAEkef6E2fPLNZ8xjvHD1ppdlwWGe BN5o/PM8BzSVdzbJIqu652b/6L10UcM2IwkOzAEFKck7qy3yFV9Sbgm3w22gVV3c5meM b6l4+noFsRPD1BlZ7PK6CLyDMx5Mv82nbeesStKMSCxGPA/MAVbzItkzIrNuX3DUnqRj 9LJODgkUgGg8bgKi7w2aAv9Cx2mUuue8If5Rbfnz3YRbwYMFhp2QnHSf2YqzdTjtTANY 7jyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=blMzM4L7KTCta+RIVTUa9dZqKyvOL2v1f6wRkRwQg2E=; fh=PM0GxARnY2fq++lmnFr5zDtgNQoaxnNKf1FrSBSd8Ck=; b=ogAXh6te2C3AQSoIpylAZQXvtRZiPKqQ9JJeF4WFU7JBV0tYWEMJuNyKwPRGNEkcab WPTOdF/bUwne9UOcxEjHGblfUF0oLeBqMm++s7jkBbCZLvyQL5VHSFtdTg913uI+2iza vq/stUtKmv7Ba+Vr7GSXaRCHzK2Ge9pJC54M8q2dMD7g5nEqdiQxXlrf+BK7I/HJm0Rn Auk9gSIwzSQkmX+1r6M7Adt6DszXe8k8YMPBubeudZPIgH0h6UtP4NrTglof14Ym/N3+ 27187q+mWqf56ql+knxVhF8WbUfDC+Yv9kYPjlrV52lU9iZTudeddmoibnoGbs+CXU0h Dqkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Y4r72CYf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ku11-20020a170903288b00b001b8a3a8d707si2114253plb.573.2023.09.08.14.46.41; Fri, 08 Sep 2023 14:46:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Y4r72CYf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343905AbjIHUgW (ORCPT + 40 others); Fri, 8 Sep 2023 16:36:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233048AbjIHUgT (ORCPT ); Fri, 8 Sep 2023 16:36:19 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE9B18E; Fri, 8 Sep 2023 13:36:15 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5FAD2C433C9; Fri, 8 Sep 2023 20:36:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694205375; bh=mvgQfp1WaBcpfDTbCSVaFFlPEh1S9we854LIGmy5oWI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Y4r72CYfP8k8zha0VpGBOejgR2oZO5edDsBWsrRayIRwLTkKan/Bok+LpSDI/XWhb VwZYpRvFGYHMJKeGSBriUO30SdFeoL/e9fkvpVrR5YJSosGikFTaSK6Y1xocgPdg2R q66JaD+h4tZs+qql4yWrI2R6+L18dtGn6F+fQjNWx6Ko2WGX65fQHv1vetYyDn+mip YhwtStSj0EtCEqjxkN0Bo6nipse8R5mWnImjlpQDw/jYrNFdWyE93nO/sMVqT9Op8/ JXnhXp0iSo1NB/wwLfbkN5yAHL9PQu29JQiZn8lhZTV1lcB2yK66RAzos/j/zJZwOl I78RcKSLfvNkA== From: Frederic Weisbecker To: "Paul E . McKenney" Cc: LKML , Frederic Weisbecker , rcu , Uladzislau Rezki , Neeraj Upadhyay , Boqun Feng , Qiuxu Zhuo , Joel Fernandes Subject: [PATCH 01/10] rcu: Use rcu_segcblist_segempty() instead of open coding it Date: Fri, 8 Sep 2023 22:35:54 +0200 Message-ID: <20230908203603.5865-2-frederic@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230908203603.5865-1-frederic@kernel.org> References: <20230908203603.5865-1-frederic@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776507539754101139 X-GMAIL-MSGID: 1776507539754101139 This makes the code more readable. Reviewed-by: Qiuxu Zhuo Reviewed-by: Joel Fernandes (Google) Signed-off-by: Frederic Weisbecker Reviewed-by: Paul E. McKenney --- kernel/rcu/rcu_segcblist.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/rcu/rcu_segcblist.c b/kernel/rcu/rcu_segcblist.c index f71fac422c8f..1693ea22ef1b 100644 --- a/kernel/rcu/rcu_segcblist.c +++ b/kernel/rcu/rcu_segcblist.c @@ -368,7 +368,7 @@ bool rcu_segcblist_entrain(struct rcu_segcblist *rsclp, smp_mb(); /* Ensure counts are updated before callback is entrained. */ rhp->next = NULL; for (i = RCU_NEXT_TAIL; i > RCU_DONE_TAIL; i--) - if (rsclp->tails[i] != rsclp->tails[i - 1]) + if (!rcu_segcblist_segempty(rsclp, i)) break; rcu_segcblist_inc_seglen(rsclp, i); WRITE_ONCE(*rsclp->tails[i], rhp); @@ -551,7 +551,7 @@ bool rcu_segcblist_accelerate(struct rcu_segcblist *rsclp, unsigned long seq) * as their ->gp_seq[] grace-period completion sequence number. */ for (i = RCU_NEXT_READY_TAIL; i > RCU_DONE_TAIL; i--) - if (rsclp->tails[i] != rsclp->tails[i - 1] && + if (!rcu_segcblist_segempty(rsclp, i) && ULONG_CMP_LT(rsclp->gp_seq[i], seq)) break;