From patchwork Thu Aug 31 08:09:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Biju Das X-Patchwork-Id: 137335 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c792:0:b0:3f2:4152:657d with SMTP id b18csp410377vqu; Thu, 31 Aug 2023 11:04:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFKFLN//A8P2n97Lcrc68wzS5FNKWcmSV1Exh176QT9tL4CLL158CD4BbMmsSOjGLDiUGbI X-Received: by 2002:a05:6512:3da6:b0:500:977d:a4e1 with SMTP id k38-20020a0565123da600b00500977da4e1mr5294371lfv.40.1693505099564; Thu, 31 Aug 2023 11:04:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693505099; cv=none; d=google.com; s=arc-20160816; b=u1YMRFTQ6PZazrRjCvYel6RWOX8+uNUIIfAWpcJS/V2vVZXCcLqTPsjfqcI4HxbZdW 8sUkgLnrPxMjPT+SpHZ53tUhX3rw5L5DwD5uOMjr1MlqtrwbW8ZToSVQ8R27hUyZJCqk 18vb3lO7RTmxzbDwACygqjtRjYsBh7gXa//fPY7g68sgCX6IHPDeeJwz2Tv1kyPN9b2k emebEUkmhGFM0rgMLqE+adBfw/5brVY7RiUB1A1m4s33VjzYHPjKlBFpJuLDdA27A0c7 CrHL8HJ8ZMIXWHa3y+s4XAircVuy5lG2sh91BxzbBSUgQsiU5NNp9Sf2AvA2mdqPSNlP AtDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=BHGYHOskC9xVAHiT2QyYh5oyBQ/ZklIaQelxjjFFEXo=; fh=r00Pqt0uAaYxSoUnOtxebcCkqLeEbCP/usidTbTmIb4=; b=tCDTk7JB1gzfesOG/NfMuXgHYNgJ+3pzXLeQ6xC7YP9fNXH5WP0mQmspwkJjf5HK5M ce5XV5LT6ugkAhMm7kXY8qyaWl0x3uLFZet5QygvB2ytHE9nOUFH0Lnx6hZzpzyxoI1h 4Wk91ZIz3Eq7rlnQXqzVOvghm19NLS9WQVWdWuMfRn2mBm+4ps4E+19gyHZZa3ydYdwl Odej0Rjr8DQXywgwZOyaDL38l6m/tNIiWilxj8wVzO2Q+5cGSO1ksXKiASYJhq97MLMP wT9cLECbvZFYYDTlvnwufgqBnaw3J68aI1Ant8JJlAkfzQRQzXiO7lLiFrxzTwKx8bRu ACWw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=renesas.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gf7-20020a170906e20700b009a5830bb1fdsi1354908ejb.1054.2023.08.31.11.04.14; Thu, 31 Aug 2023 11:04:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=renesas.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240206AbjHaIJ4 (ORCPT + 99 others); Thu, 31 Aug 2023 04:09:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232058AbjHaIJz (ORCPT ); Thu, 31 Aug 2023 04:09:55 -0400 Received: from relmlie6.idc.renesas.com (relmlor2.renesas.com [210.160.252.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 18143185 for ; Thu, 31 Aug 2023 01:09:51 -0700 (PDT) X-IronPort-AV: E=Sophos;i="6.02,216,1688396400"; d="scan'208";a="178287314" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie6.idc.renesas.com with ESMTP; 31 Aug 2023 17:09:51 +0900 Received: from localhost.localdomain (unknown [10.226.92.179]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id B69F84010DFB; Thu, 31 Aug 2023 17:09:46 +0900 (JST) From: Biju Das To: Andrzej Hajda , Neil Armstrong , Robert Foss , David Airlie , Daniel Vetter Cc: Biju Das , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Douglas Anderson , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Zhu Wang , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Laurent Pinchart , Helen Koike Subject: [PATCH v6 1/4] drm/bridge/analogix/anx78xx: Drop ID table Date: Thu, 31 Aug 2023 09:09:35 +0100 Message-Id: <20230831080938.47454-2-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230831080938.47454-1-biju.das.jz@bp.renesas.com> References: <20230831080938.47454-1-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1775768803344852715 X-GMAIL-MSGID: 1775768803344852715 The driver has an ID table, but it uses the wrong API for retrieving match data and that will lead to a crash, if it is instantiated by user space or using ID. From this, there is no user for the ID table and let's drop it from the driver as it saves some memory. Signed-off-by: Biju Das Reviewed-by: Douglas Anderson Reviewed-by: Laurent Pinchart Reviewed-by: Andy Shevchenko Reviewed-by: Helen Koike --- v5->v6: * No change. v4->v5: * Added Rb tag from Andy and Helen. v3->v4: * Added Rb tag from Laurent and Douglas Anderson. v2->v3: * Updated commit header. v1->v2: * Dropped ID table support. --- drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c index 800555aef97f..6169db73d2fe 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c @@ -1367,12 +1367,6 @@ static void anx78xx_i2c_remove(struct i2c_client *client) kfree(anx78xx->edid); } -static const struct i2c_device_id anx78xx_id[] = { - { "anx7814", 0 }, - { /* sentinel */ } -}; -MODULE_DEVICE_TABLE(i2c, anx78xx_id); - static const struct of_device_id anx78xx_match_table[] = { { .compatible = "analogix,anx7808", .data = anx7808_i2c_addresses }, { .compatible = "analogix,anx7812", .data = anx781x_i2c_addresses }, @@ -1389,7 +1383,6 @@ static struct i2c_driver anx78xx_driver = { }, .probe = anx78xx_i2c_probe, .remove = anx78xx_i2c_remove, - .id_table = anx78xx_id, }; module_i2c_driver(anx78xx_driver);