Message ID | 20230824073710.2677348-2-lee@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a7d1:0:b0:3f2:4152:657d with SMTP id p17csp992004vqm; Thu, 24 Aug 2023 02:20:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHcl5baruE5JP6KIV/k6an1I69/3X1eXSBucB852vaekTcNk8UbwPTdkyStip+bGDIoZdpS X-Received: by 2002:a17:902:eb45:b0:1b8:9552:ca with SMTP id i5-20020a170902eb4500b001b8955200camr13027190pli.45.1692868812262; Thu, 24 Aug 2023 02:20:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692868812; cv=none; d=google.com; s=arc-20160816; b=awJuWM4BZyio5CcWiwGObsQUcUTK52dCg7dNnBgz52xeMU0dXN6+CQPRzhJ1YBnsO6 n3nBNUNuNZldVTKby3oOR9AcYAVAgdrlHzf8nEzt3eZ4vZcKql33ZDVdit+LWKLgAfkj l1uxtjpfHOJms4zGD1Q508YFATwylSF4TrIUMh3r4w9hwzaMfpVK3wIxnZBrQi/lSeid Vwn14vdfAhAayptHl6yDII5NqIqR6AQM6XSXdkcLl7a/1TIX9P5AXa0GBS5AjCSRqlZP EgYy+YA/hCvFeCz3gAcN2yKCE2x6VOsjI1zx3xeMkmjuzTeYBMqR5QjhAvdCVyWc7Uwz oOSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=H0mGhCD118/LdjNmBRneiPMfDyYiYBKCZc/9/Ij/w+w=; fh=kR3C+e3tiM8nWTd00fcU2xd6YMdosvcbzzB/Igqb/Ik=; b=tewfdQZ2sKgGM5lJ518zOZcRRPeN+Ha5aT6H6Nh38FEVsGqf7i8XcmzJdynuvfYsCv 2Pgcwh9abYrYE3uQfuaQaj/iLUBZpBaUAjvhenGJKO7sYBw6D5r+k7tMiOCu1nEgZn6G hg2Q3RlcA7d1Hz/SQzaDr9F4KB/S2nzOMXjTHfkrCW/tdwxOSO8dNHKqGDJRB3j2aMU9 gkonH3yilfb0H8DGnkvpTgKXpOBFG72jEwYmvSf/F+Eip68tD9J8FXdN/L63ATmdBx/m z06hrJYxz2mo5++75M55sh3fGhA6/L8iGPXH1MDzY+QHzgpPiZNb8E/wYI8XmeUpFZI0 tV8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mJ+PCb9q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x13-20020a17090300cd00b001bda18ea0e1si12683532plc.80.2023.08.24.02.19.59; Thu, 24 Aug 2023 02:20:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mJ+PCb9q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240340AbjHXHho (ORCPT <rfc822;kjyul0303@gmail.com> + 99 others); Thu, 24 Aug 2023 03:37:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240433AbjHXHhj (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 24 Aug 2023 03:37:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F8C81710 for <linux-kernel@vger.kernel.org>; Thu, 24 Aug 2023 00:37:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 98190658E8 for <linux-kernel@vger.kernel.org>; Thu, 24 Aug 2023 07:37:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F6EBC433CC; Thu, 24 Aug 2023 07:37:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692862649; bh=owKgS4t9YWA6m7XMWAlbtjBYVXwNlsgMFlK4MNeRCe4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mJ+PCb9qDFIEeA+r9YbcGdvsiyuPhwDzDqcSQtvg1i5VhDqBJ+gosfw2ZyPwvywey dF3EUQYxFi9WL4AXTZnu/yA6m+AjEVmhndkOP3AKcadWlSKr9Ejo2EfFz9/rtDmPzb 6nNsE0FS44unHsoVoF5wSwYzRkwKDyu+881E7MF68o44D7bAkNjc8KX1+kleLIEbqP L2divj0vALDxZ4AH+ri+DoALQg5i1n70iC3+mYntnYOfAQDSD6Qk5+b4P432HlnBk0 NsWcz76gOwazrDvCdEeOU5i/H3szji+JFwqqtCstbqZAhI84ryqmWQIDUGY1eyLERV mNNAJdXXzpWgQ== From: Lee Jones <lee@kernel.org> To: lee@kernel.org Cc: linux-kernel@vger.kernel.org, Hyun Kwon <hyun.kwon@xilinx.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Michal Simek <michal.simek@xilinx.com>, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 01/20] drm/xlnx/zynqmp_disp: Use correct kerneldoc formatting in zynqmp_disp Date: Thu, 24 Aug 2023 08:36:46 +0100 Message-ID: <20230824073710.2677348-2-lee@kernel.org> X-Mailer: git-send-email 2.42.0.rc1.204.g551eb34607-goog In-Reply-To: <20230824073710.2677348-1-lee@kernel.org> References: <20230824073710.2677348-1-lee@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1775101607199068070 X-GMAIL-MSGID: 1775101607199068070 |
Series |
Rid W=1 warnings from GPU
|
|
Commit Message
Lee Jones
Aug. 24, 2023, 7:36 a.m. UTC
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'blend' not described in 'zynqmp_disp'
drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'avbuf' not described in 'zynqmp_disp'
drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'audio' not described in 'zynqmp_disp'
Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Hyun Kwon <hyun.kwon@xilinx.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Michal Simek <michal.simek@xilinx.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-arm-kernel@lists.infradead.org
---
drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Comments
Hi Lee, Thank you for the patch. On Thu, Aug 24, 2023 at 08:36:46AM +0100, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'blend' not described in 'zynqmp_disp' > drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'avbuf' not described in 'zynqmp_disp' > drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'audio' not described in 'zynqmp_disp' > > Signed-off-by: Lee Jones <lee@kernel.org> > --- > Cc: Hyun Kwon <hyun.kwon@xilinx.com> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: David Airlie <airlied@gmail.com> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Michal Simek <michal.simek@xilinx.com> > Cc: dri-devel@lists.freedesktop.org > Cc: linux-arm-kernel@lists.infradead.org > --- > drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c > index 407bc07cec69a..7c64ab11fe2b0 100644 > --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c > +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c > @@ -128,9 +128,9 @@ struct zynqmp_disp_layer { > * struct zynqmp_disp - Display controller > * @dev: Device structure > * @dpsub: Display subsystem > - * @blend.base: Register I/O base address for the blender > - * @avbuf.base: Register I/O base address for the audio/video buffer manager > - * @audio.base: Registers I/O base address for the audio mixer > + * @blend: .base: Register I/O base address for the blender > + * @avbuf: .base: Register I/O base address for the audio/video buffer manager > + * @audio: .base: Registers I/O base address for the audio mixer This is really a hack to work around the warning, and not a clean fix. kerneldoc is still today unable, as far as I understand, to document nested structures. That's annoying, and the warning is a good way to remind us that it needs to be fixed. I'd be tempted to keep the warning for that reason. > * @layers: Layers (planes) > */ > struct zynqmp_disp {
diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c index 407bc07cec69a..7c64ab11fe2b0 100644 --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c @@ -128,9 +128,9 @@ struct zynqmp_disp_layer { * struct zynqmp_disp - Display controller * @dev: Device structure * @dpsub: Display subsystem - * @blend.base: Register I/O base address for the blender - * @avbuf.base: Register I/O base address for the audio/video buffer manager - * @audio.base: Registers I/O base address for the audio mixer + * @blend: .base: Register I/O base address for the blender + * @avbuf: .base: Register I/O base address for the audio/video buffer manager + * @audio: .base: Registers I/O base address for the audio mixer * @layers: Layers (planes) */ struct zynqmp_disp {