From patchwork Tue Aug 22 02:38:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 136465 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b82d:0:b0:3f2:4152:657d with SMTP id z13csp3474800vqi; Tue, 22 Aug 2023 01:05:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEZXb2FD3XWh6u6DgXj46gKS3ZKwDivJhVnwAtm/OYPgG3y4GLUcUPP4w0515UKlPEcPGlz X-Received: by 2002:a05:6e02:1c41:b0:349:865d:9fb with SMTP id d1-20020a056e021c4100b00349865d09fbmr14025974ilg.5.1692691513502; Tue, 22 Aug 2023 01:05:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692691513; cv=none; d=google.com; s=arc-20160816; b=Z2uLmXfKUrPFNzCHmP5xZz/0VakyViLieRORlTq97PJmY7KeoZhslY8VOEGOYYEPxo f4vTCwiXANL1hMRf9GpqtsLZS+Mrag4PqNYenAmG+ba1/wAgCYqXta9Wwu5+NxXaF81Y ibY0JOoaHxiLdWc40vVjpCYgDAK2v/tJI6uJ3HeN8GZdLdEA48A6iCIXN+d2wf7cLxUo pBRy+y+9TvhGzlCrs+RzIqdel8FVyknbOeRBnRH8TzVjRb8sfQEDu4MsVfrJSHmtVJss xwzZFPtGY/RXf/4rktSlz9P2V17vVRtRhI/hThRoqvcY3K9rCvRi53XsHGoMs7mf50lq RwJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=q3aol7h0auBuZyc5p4amAga4B47JuiLDYEnzbFOZISQ=; fh=sGIGjVMeMNkwUeNFy8RNznGI5bzzhAUwvsFNKStEEzk=; b=iXMx4IstvCyUiovFnlAbq/9ypR1p8Zit0i/1iwqfhYIDZDucjISTqfXLnmcvsPe6Mw h9VyUu8a59R+Nl/zp3KoCVs2LhnxM48YavLGlFckZFD6JwQ2UsFZHPvI0cMFwQogaWgC rd1c3kH+kyYsWGzqmt87MfD7L9ISMEITzfF2NXwri0tAHyYmx/J2+iaKdA75S6meoPL3 Rr4hlf9QeYdRfHncyld0agxFBacb1xfGiaeEDSEfmvoezt8Vf0AP0Qfr2g2RvMsSdpft D0mwME862pTQjBj5OTKoOXXMp0xR/1oC9jw/af5hdDhEzOfh9rWWIR5NbF2MD2rRmIfv qyMg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s3-20020a63d043000000b0055beccef366si8722967pgi.727.2023.08.22.01.05.00; Tue, 22 Aug 2023 01:05:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232328AbjHVCjB (ORCPT + 99 others); Mon, 21 Aug 2023 22:39:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232272AbjHVCia (ORCPT ); Mon, 21 Aug 2023 22:38:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB88A186 for ; Mon, 21 Aug 2023 19:38:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CD37564BF1 for ; Tue, 22 Aug 2023 02:38:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3BEAEC433C7; Tue, 22 Aug 2023 02:38:26 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.96) (envelope-from ) id 1qYHI2-001bbS-0z; Mon, 21 Aug 2023 22:38:42 -0400 Message-ID: <20230822023842.120843765@goodmis.org> User-Agent: quilt/0.66 Date: Mon, 21 Aug 2023 22:38:08 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Andrew Morton , Sven Schnelle Subject: [for-linus][PATCH 5/8] tracing/synthetic: Allocate one additional element for size References: <20230822023803.605698724@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1774915696611569451 X-GMAIL-MSGID: 1774915696611569451 From: Sven Schnelle While debugging another issue I noticed that the stack trace contains one invalid entry at the end: -0 [008] d..4. 26.484201: wake_lat: pid=0 delta=2629976084 000000009cc24024 stack=STACK: => __schedule+0xac6/0x1a98 => schedule+0x126/0x2c0 => schedule_timeout+0x150/0x2c0 => kcompactd+0x9ca/0xc20 => kthread+0x2f6/0x3d8 => __ret_from_fork+0x8a/0xe8 => 0x6b6b6b6b6b6b6b6b This is because the code failed to add the one element containing the number of entries to field_size. Link: https://lkml.kernel.org/r/20230816154928.4171614-4-svens@linux.ibm.com Cc: Masami Hiramatsu Fixes: 00cf3d672a9d ("tracing: Allow synthetic events to pass around stacktraces") Signed-off-by: Sven Schnelle Signed-off-by: Steven Rostedt (Google) --- kernel/trace/trace_events_synth.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/trace/trace_events_synth.c b/kernel/trace/trace_events_synth.c index 80a2a832f857..9897d0bfcab7 100644 --- a/kernel/trace/trace_events_synth.c +++ b/kernel/trace/trace_events_synth.c @@ -528,7 +528,8 @@ static notrace void trace_event_raw_event_synth(void *__data, str_val = (char *)(long)var_ref_vals[val_idx]; if (event->dynamic_fields[i]->is_stack) { - len = *((unsigned long *)str_val); + /* reserve one extra element for size */ + len = *((unsigned long *)str_val) + 1; len *= sizeof(unsigned long); } else { len = fetch_store_strlen((unsigned long)str_val);