From patchwork Fri Aug 18 13:55:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 136200 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b82d:0:b0:3f2:4152:657d with SMTP id z13csp2197342vqi; Sat, 19 Aug 2023 14:11:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGUJDAIr8RDdbzf8mBvoVSQWuWk2eyK2S2E3mnzSdClo1nGtXT41Mq/wcco04Wvu5XW0CEL X-Received: by 2002:a05:6a20:1046:b0:137:a9d7:de12 with SMTP id gt6-20020a056a20104600b00137a9d7de12mr1994836pzc.59.1692479491606; Sat, 19 Aug 2023 14:11:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692479491; cv=none; d=google.com; s=arc-20160816; b=zSeeyaGn9ZRnlAbq+/lsKlPkH3s/XylCNnscUHlA54HFKFR/6swvch6/x64rJuxRgH 5AkFa244hRU0vvz4C6dNdXSxVi2a6DqEFRDPLNv0e0/mGRN+hisk1NpCRQJDCmyM/oqC XlT0EO4C8dov5oVb6VDD/Fa6OtTFkxDEEWIdKexCR3MOJPhqvBbGHRUa+zD4fBRFXI5H TIsG0DZlZLLz1NHESAv5oYE+TVQDFZO3k0Lz4d1ndmg4nkVcVWi2CDbCsSfv/2x+TQ0j FaAYnb3omBOPnrX8lAG0omgq5xbjWT1g+Qt8jZGuxhO1CxYZCk3KLfJXLXfpiNqQcwy4 mQjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=tnlBg8i71ZZF5vC/PdEFa3UhFBHInI/WTs75Cw2jAu0=; fh=lDmV8Sd1F/+YN7SAJMhiNeuXtuY1q4f+HDQTcTlEJCI=; b=lohGbEaG/Tw1q0CspEx+Ex3xjcD9CknLL5DEWxjTIxmVEF1NuN4n1l8FDY0xGtdK0x TvSiCxwaRuoGF0tjzd9JWwoB+ucoMiFG4gcHEVKyWx55oKMiBE1fLRiFCJeQ1y9iGmyZ cQ7lRx5tyItbiOMtEmLJGalUco2aIe0tf4OyYt8AdWUewYVwQ4+B3xhcXFAgoK119ZwJ RAfKqn2r+1TJsf6fvWC3dHLb30i5NpiF8ut+hbmvKyCC/J2sTkG0uzjaTYjnOIhYoZjo C7k0vd96ZmpWsixGYz3dz3cStZ9KEuO/CBq8cX+xQ4+bjEGU4tZmeHfNZcFUyMtjCl8g vAlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=SVGMKfEN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id z4-20020a170903408400b001bf669d9706si947830plc.448.2023.08.19.14.11.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Aug 2023 14:11:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=SVGMKfEN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id CA729CBE93; Sat, 19 Aug 2023 01:44:30 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377503AbjHRN4K (ORCPT + 99 others); Fri, 18 Aug 2023 09:56:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377536AbjHRNzx (ORCPT ); Fri, 18 Aug 2023 09:55:53 -0400 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1B383C34; Fri, 18 Aug 2023 06:55:28 -0700 (PDT) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-3fe426b8583so9162125e9.2; Fri, 18 Aug 2023 06:55:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692366927; x=1692971727; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=tnlBg8i71ZZF5vC/PdEFa3UhFBHInI/WTs75Cw2jAu0=; b=SVGMKfENLrPZL4ySpDmshwozLBWz3qQUL/LzznRTsBZjvY+YbU1cGhyUR69IYuZe+9 Ro7x0sDMEGgCbzgdjCyholFdTLsdFOK88RU+6dlvOPWRH+tOyzrWHOj9pKPOtNuS3NLt xUux0MLnL66Q9efYYE3HWpJXE9wGQHwcHyJseiEt/njdVYG5zmX3pCDTdKcGo6qxFlvy UpFbRUcTbgNq6IDgzPxk4L1hKUol/5tuvTtuPfvwzJl/hZpE9RFgXONlynPCG+Nl63Xb uxOcILp1gbwHefZoHugaHU0y2cNIhSzlzt2B6yOOGsSCLTJqUkm3DoCCTszWObkzC7en s1dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692366927; x=1692971727; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tnlBg8i71ZZF5vC/PdEFa3UhFBHInI/WTs75Cw2jAu0=; b=eW8YTmE+N+sxDzrZ69hOkLvMq1YYI4PgtJkIVqEk7XxTwZL0/6zqCq7sn3Fb1xSnNI d168LA3il57epTbfb07iLZnigrcv/mvj2eEf1xEmwneS6xsnTv62Ue4iD/kAzxQXHx8O 935YBfLq2V4FWTmsNV+qbVq5dkfiaChgFGKBha0dVBTofMF/gnKGbyfltrv1T3AmEH4n fHOiLuPurGmhNb6Kr4LkS9Si0jJaMM9YWTPz0aouyCrwO+USuRmO2B9ih9TDmQ3G/xIR +y9y6WF7fjg3F/YENaAfCP5mpiWyLImGWGarPoLXcA7GHEhIte1rfzpHNip50+LME6ep 9wxg== X-Gm-Message-State: AOJu0Yz2AuBRFTu7dEo3exTpr0rvlwRNk0dlYkKQuMA6RNNXReyydtI3 VqAQxKfz2OND+4x+TNk81g0= X-Received: by 2002:a7b:c7c8:0:b0:3fe:2e0d:b715 with SMTP id z8-20020a7bc7c8000000b003fe2e0db715mr2306544wmk.18.1692366927240; Fri, 18 Aug 2023 06:55:27 -0700 (PDT) Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net. [80.193.200.194]) by smtp.gmail.com with ESMTPSA id t24-20020a1c7718000000b003feae747ff2sm6436557wmi.35.2023.08.18.06.55.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Aug 2023 06:55:26 -0700 (PDT) From: Colin Ian King To: Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] btrfs: remove redundant initialization of variable dirty Date: Fri, 18 Aug 2023 14:55:25 +0100 Message-Id: <20230818135525.1206140-1-colin.i.king@gmail.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1774693375529973955 X-GMAIL-MSGID: 1774693375529973955 The variable dirty is initialized with a value that is never read, it is being re-assigned later on. Remove the redundant initialization. Cleans up clang scan build warning: fs/btrfs/inode.c:5965:7: warning: Value stored to 'dirty' during its initialization is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King --- fs/btrfs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 7d11dbd74956..6441c0053355 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -5962,7 +5962,7 @@ static int btrfs_dirty_inode(struct btrfs_inode *inode) static int btrfs_update_time(struct inode *inode, int flags) { struct btrfs_root *root = BTRFS_I(inode)->root; - bool dirty = flags & ~S_VERSION; + bool dirty; if (btrfs_root_readonly(root)) return -EROFS;