From patchwork Fri Oct 6 15:07:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Tretter X-Patchwork-Id: 149295 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a888:0:b0:403:3b70:6f57 with SMTP id x8csp396820vqo; Fri, 6 Oct 2023 08:07:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE79+HmYsLF9WkcTUEZwuKRysOzNtjcGsSZzKuVXUXYmkBZjz/CnUrlBwB5ny3DWxT26K69 X-Received: by 2002:a05:6a00:139d:b0:68f:b5cb:cecd with SMTP id t29-20020a056a00139d00b0068fb5cbcecdmr10042227pfg.16.1696604875928; Fri, 06 Oct 2023 08:07:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696604875; cv=none; d=google.com; s=arc-20160816; b=c2OP9KS9csRn45+CkaGE6IkqVLAFR8E61Vec83v651bxgoCirNTG/azkNjRqlk2Jli /MS16EsvI7uHgnBvOuWOvCbpf/hEs/+mqFiF9grJ9gOFSjepDz+hFhIJ2ZkYuXBXPLjB VynSL6jyHkcOfIQUhmiDfZJUV4+Z7RExK4sLPluT+c+wHqq1d7y1ikK7uNRlh2t1vfAT zfG/qyEJCZgakv+mHAKToyToIJCxTcm8ZQj3oFiypRI2sPKSEp1LYwe/nO5zlNshmqu6 /MkRb4R03WiEAHdlDAtXj3/i2UNqYypB4XmmoyYheZcUXypaoI2DxoLW/MHyE/Q1XyqH OzXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from; bh=ChS4Xhrycb6U7gJJhyz0PfHDhKfy1VIsPfM+y8bVYss=; fh=tysWfEZ76Pug+BlQldbkXEC1+E9LgPZYVh1J2Q1B8hU=; b=CxfYXqCL5Fgr8dabm1ptxQ7lVEo6UnEK1OvkRQBw5FnFKW99Tn+0rRyi9FKiisphb8 CvU5j2T4PM1pMq0cjJAo1NIvLu69YTlpwudMrIx6y1EOxGPn1AQOke2QL7p2avADCJ8j cup5GUNzawdPUhxRuF3ZG+gVzdxFFZxSOnQqCCkcNJr9mOqDb7wQlHONPeZr2gPKZLie eKMsumjuGFXFiQc4LL3eCrbtLzW2DiJGggsZMb2+6mX7rzGUTcEy5DTtymykIWCBQjHL GVD4vDOHJFIa85svmpbHoigMdslJpM+587JHTlGqcqsALK6mhvSZ//dQGclbSKmJLC5F 13SA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id cr6-20020a056a000f0600b00694d034452csi1623801pfb.105.2023.10.06.08.07.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 08:07:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 372CA80A9E0E; Fri, 6 Oct 2023 08:07:44 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232732AbjJFPHR (ORCPT + 18 others); Fri, 6 Oct 2023 11:07:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232659AbjJFPHK (ORCPT ); Fri, 6 Oct 2023 11:07:10 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 975348F for ; Fri, 6 Oct 2023 08:07:08 -0700 (PDT) Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1qomPy-00051v-D3; Fri, 06 Oct 2023 17:07:06 +0200 From: Michael Tretter Date: Fri, 06 Oct 2023 17:07:07 +0200 Subject: [PATCH v2 5/5] drm/bridge: samsung-dsim: calculate porches in Hz MIME-Version: 1.0 Message-Id: <20230818-samsung-dsim-v2-5-846603df0e0a@pengutronix.de> References: <20230818-samsung-dsim-v2-0-846603df0e0a@pengutronix.de> In-Reply-To: <20230818-samsung-dsim-v2-0-846603df0e0a@pengutronix.de> To: Inki Dae , Jagan Teki , Marek Szyprowski , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Michael Tretter , Adam Ford , Frieder Schrempf , Marco Felsch X-Mailer: b4 0.12.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:1101:1d::54 X-SA-Exim-Mail-From: m.tretter@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=2.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 06 Oct 2023 08:07:44 -0700 (PDT) X-Spam-Level: ** X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779019154456652642 X-GMAIL-MSGID: 1779019154456652642 Calculating the byte_clk in kHz is imprecise for a hs_clock of 55687500 Hz, which may be used with a pixel clock of 74.25 MHz with mode 1920x1080-30. Fix the calculation by using HZ instead of kHZ. This requires to change the type to u64 to prevent overflows of the integer type. Reviewed-by: Adam Ford #imx8mm-beacon Tested-by: Adam Ford #imx8mm-beacon Tested-by: Frieder Schrempf # Kontron BL i.MX8MM + Waveshare 10.1inch HDMI LCD (E) Reviewed-by: Marco Felsch Signed-off-by: Michael Tretter --- Changes in v2: None --- drivers/gpu/drm/bridge/samsung-dsim.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index 714e1e833606..63a0d8dbe37c 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -986,10 +986,12 @@ static void samsung_dsim_set_display_mode(struct samsung_dsim *dsi) u32 reg; if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO) { - int byte_clk_khz = dsi->hs_clock / 1000 / 8; - int hfp = DIV_ROUND_UP((m->hsync_start - m->hdisplay) * byte_clk_khz, m->clock); - int hbp = DIV_ROUND_UP((m->htotal - m->hsync_end) * byte_clk_khz, m->clock); - int hsa = DIV_ROUND_UP((m->hsync_end - m->hsync_start) * byte_clk_khz, m->clock); + u64 byte_clk = dsi->hs_clock / 8; + u64 pix_clk = m->clock * 1000; + + int hfp = DIV64_U64_ROUND_UP((m->hsync_start - m->hdisplay) * byte_clk, pix_clk); + int hbp = DIV64_U64_ROUND_UP((m->htotal - m->hsync_end) * byte_clk, pix_clk); + int hsa = DIV64_U64_ROUND_UP((m->hsync_end - m->hsync_start) * byte_clk, pix_clk); /* remove packet overhead when possible */ hfp = max(hfp - 6, 0);