From patchwork Fri Oct 6 15:07:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Tretter X-Patchwork-Id: 149291 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a888:0:b0:403:3b70:6f57 with SMTP id x8csp396386vqo; Fri, 6 Oct 2023 08:07:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEkj3Kzb8zYRvDnBBYxFi2si6x5bEPgKKuKLxS+SMnOlZmek10Sw048iqzsXnpXRoPoLuYZ X-Received: by 2002:a05:6358:938f:b0:144:9cef:cd28 with SMTP id h15-20020a056358938f00b001449cefcd28mr8977570rwb.7.1696604841911; Fri, 06 Oct 2023 08:07:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696604841; cv=none; d=google.com; s=arc-20160816; b=qERo5bOKSqd7nRdayu87Uq/1a0nYuiYC5xnVwwaA6EGpKcCemp2qvA9/Xv9f4tZFjA Ll1kkHC2IPcYQOuui6AEocC+trT3jkdv14UKyZWUhkTc1ObXMpi9sNySWCpbCna1ZuwP yoeW3VmkFPk1Xh+YnhFjUzFlPAtx12VmByOmgHFqBDDIi4b8XPzSRchWQJm4pk3/xo4a WjWrEyV+pfnyx1O1uz6aUKzKma9J7dxELfTDpnGin8z2gOq5mEUn4VmXpIr3/4MKX5Ls IfFLOGJaZy08ORojZsCL5Bt7TQWE1GpT99w67VA88hTvKmUA5+7YSblSh9A/w8fKrC0V BU7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from; bh=AAWQ1SfhKtuJzFFJ0mKrtfuMj+B6zEZ66eiUHHnFjFw=; fh=tysWfEZ76Pug+BlQldbkXEC1+E9LgPZYVh1J2Q1B8hU=; b=C3FNUJHB6eqns2eoJUx6i1PSft66/CJxE6gOqmLIKcG9sfsUEyoQDEZ6w3dCKVE3K/ 0VP+DaEBw9FCq+YH+3vK4SZBCSWE3fCPo4W4temWgXsi+0MgIIdJ9xH81ax6jxu6Dvrx LO+Wv/ahvBiafAmkkxON57c+rPbuAjd64nv4e+SboQT6aXthj4M9WAfdNe2JZwOnRmU/ HnJV5IsX0wMMQNyQqgeiwz0K7zT2KbKVH8yJhxCBc/Km0701F+ev2o5ji1RnGWG6YFEC ZIH6aIz9mVYdrMApYMLzzXI/XSXP4FdvRRefHRBOrwB8nwcdAACLOPl6gWtTl29UljPp t+YQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id q65-20020a632a44000000b005776040b2a6si3927395pgq.187.2023.10.06.08.07.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 08:07:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 30B35831922F; Fri, 6 Oct 2023 08:07:21 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232678AbjJFPHP (ORCPT + 18 others); Fri, 6 Oct 2023 11:07:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232677AbjJFPHK (ORCPT ); Fri, 6 Oct 2023 11:07:10 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B179DE for ; Fri, 6 Oct 2023 08:07:08 -0700 (PDT) Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1qomPy-00051v-Ac; Fri, 06 Oct 2023 17:07:06 +0200 From: Michael Tretter Date: Fri, 06 Oct 2023 17:07:06 +0200 Subject: [PATCH v2 4/5] drm/bridge: samsung-dsim: adjust porches by rounding up MIME-Version: 1.0 Message-Id: <20230818-samsung-dsim-v2-4-846603df0e0a@pengutronix.de> References: <20230818-samsung-dsim-v2-0-846603df0e0a@pengutronix.de> In-Reply-To: <20230818-samsung-dsim-v2-0-846603df0e0a@pengutronix.de> To: Inki Dae , Jagan Teki , Marek Szyprowski , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Michael Tretter , Adam Ford , Frieder Schrempf , Marco Felsch X-Mailer: b4 0.12.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:1101:1d::54 X-SA-Exim-Mail-From: m.tretter@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 06 Oct 2023 08:07:21 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779019118662318119 X-GMAIL-MSGID: 1779019118662318119 Rounding the porches up instead of down fixes the samsung-dsim at some more resolutions and refresh rates: The following resolutions are working with rounded-up porches, but don't work when the porches are rounded down: 1920x1080-59.94 1920x1080-30.00 1920x1080-29.97 1920x1080-25.00 1680x1050-59.88 1280x1024-75.02 1200x960-59.99 1280x720-50.00 1024x768-75.03 1024x768-60.00 640x480-60.00 640x480-59.94 Reviewed-by: Adam Ford #imx8mm-beacon Tested-by: Adam Ford #imx8mm-beacon Tested-by: Frieder Schrempf # Kontron BL i.MX8MM + Waveshare 10.1inch HDMI LCD (E) Reviewed-by: Marco Felsch Signed-off-by: Michael Tretter --- Changes in v2: - Rephrase commit message --- drivers/gpu/drm/bridge/samsung-dsim.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index 16c8326d921b..714e1e833606 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -987,9 +987,9 @@ static void samsung_dsim_set_display_mode(struct samsung_dsim *dsi) if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO) { int byte_clk_khz = dsi->hs_clock / 1000 / 8; - int hfp = (m->hsync_start - m->hdisplay) * byte_clk_khz / m->clock; - int hbp = (m->htotal - m->hsync_end) * byte_clk_khz / m->clock; - int hsa = (m->hsync_end - m->hsync_start) * byte_clk_khz / m->clock; + int hfp = DIV_ROUND_UP((m->hsync_start - m->hdisplay) * byte_clk_khz, m->clock); + int hbp = DIV_ROUND_UP((m->htotal - m->hsync_end) * byte_clk_khz, m->clock); + int hsa = DIV_ROUND_UP((m->hsync_end - m->hsync_start) * byte_clk_khz, m->clock); /* remove packet overhead when possible */ hfp = max(hfp - 6, 0);