From patchwork Mon Aug 28 15:59:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Tretter X-Patchwork-Id: 137057 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a7d1:0:b0:3f2:4152:657d with SMTP id p17csp3468443vqm; Mon, 28 Aug 2023 10:11:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEiAfRAuHT8vuJJ9qWoRj13PfTmdmgTQROffTjmJf2fxMGaOadEsYcM9D4ijVnDGg4Oedjn X-Received: by 2002:a05:6870:6387:b0:1bb:8333:ab8a with SMTP id t7-20020a056870638700b001bb8333ab8amr13758187oap.4.1693242706376; Mon, 28 Aug 2023 10:11:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693242706; cv=none; d=google.com; s=arc-20160816; b=hfRQTgnblraOot5BvLuy0dpy9nrPD/gQTanAu4PIF6BdPMwYklv+jYyrrD67zI9BJU G1Ml2OnsyMSImYFNCEKESuJZCFG5xY6InfHLTGxaN8GcGBHjIIflxYtWB9PEBEVhJBjx hymhchd+fBgb412E3MgG8gLmPcja/bQdZnk1OD17qsvi1qebSUc8G9/fPrzv6pM9NpBC Ts4EHqFaOski3rdRqsQtGdkdK0rOq7crIrjQOwGM/Zu7i+Pe3FTaQGnUvr/W/K3sysdD YkRnoCcRRwE+/VqCfa3LyHjwizkbfASD2NPfffYqZrKeTYgh/Se0njcpYXrTxMj2uEN4 hK2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from; bh=RH+TeAqTA1DOSx/GfLi7JQLQNPFy+XqKVP41rugU6eA=; fh=pKDXkxIseImAYs4+ZQjMc4DXEQVqgI/B2AVAWtKoC1k=; b=uOLxHb91+jXv3Pmqei5QNX3Pb+aaW3XKn7UvP1wYjlt7ZQHvOjLwhw7q9X+3jXwwGF IOAylm3Z6LOKQq4Wi0X6RUhxAjxsjWIY1qxayZWmpoC5O1vrTLvsDBReZly/ZfJiHbcB Xij9n8G8Z/+tNRD6RIaeTPL16gMM3okfXDgEhIahKcwGOiQGlnVek8zY9tQx5PfJ6wY/ jfRLUim0PojqsDnhyU+K4Cr2cuqhfqMWVDWg5anzSmxJ+CEk5CY9DUNK2AjB4SzaUSb4 rOR/2teTOHwHqGODdxdEPRgo/xzUF6EsIVzns1Pg0CIafPV9co/zYvALTN83vBaJgLmp pRFA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 11-20020a63020b000000b0054fdf58c23esi7915959pgc.680.2023.08.28.10.11.21; Mon, 28 Aug 2023 10:11:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232584AbjH1P7w (ORCPT + 99 others); Mon, 28 Aug 2023 11:59:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232596AbjH1P7W (ORCPT ); Mon, 28 Aug 2023 11:59:22 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BCCA123 for ; Mon, 28 Aug 2023 08:59:19 -0700 (PDT) Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1qaee1-0005pk-FX; Mon, 28 Aug 2023 17:59:13 +0200 From: Michael Tretter Date: Mon, 28 Aug 2023 17:59:10 +0200 Subject: [PATCH 5/5] drm/bridge: samsung-dsim: calculate porches in Hz MIME-Version: 1.0 Message-Id: <20230818-samsung-dsim-v1-5-b39716db6b7a@pengutronix.de> References: <20230818-samsung-dsim-v1-0-b39716db6b7a@pengutronix.de> In-Reply-To: <20230818-samsung-dsim-v1-0-b39716db6b7a@pengutronix.de> To: Inki Dae , Jagan Teki , Marek Szyprowski , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Michael Tretter X-Mailer: b4 0.12.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:1101:1d::54 X-SA-Exim-Mail-From: m.tretter@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1775493663919242977 X-GMAIL-MSGID: 1775493663919242977 Calculating the byte_clk in kHz is imprecise for a hs_clock of 55687500 Hz, which may be used with a pixel clock of 74.25 MHz with mode 1920x1080-30. Fix the calculation by using HZ instead of kHZ. This requires to change the type to u64 to prevent overflows of the integer type. Signed-off-by: Michael Tretter --- drivers/gpu/drm/bridge/samsung-dsim.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index 459be953be55..eb7aca2b9ab7 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -973,10 +973,12 @@ static void samsung_dsim_set_display_mode(struct samsung_dsim *dsi) u32 reg; if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO) { - int byte_clk_khz = dsi->hs_clock / 1000 / 8; - int hfp = DIV_ROUND_UP((m->hsync_start - m->hdisplay) * byte_clk_khz, m->clock); - int hbp = DIV_ROUND_UP((m->htotal - m->hsync_end) * byte_clk_khz, m->clock); - int hsa = DIV_ROUND_UP((m->hsync_end - m->hsync_start) * byte_clk_khz, m->clock); + u64 byte_clk = dsi->hs_clock / 8; + u64 pix_clk = m->clock * 1000; + + int hfp = DIV64_U64_ROUND_UP((m->hsync_start - m->hdisplay) * byte_clk, pix_clk); + int hbp = DIV64_U64_ROUND_UP((m->htotal - m->hsync_end) * byte_clk, pix_clk); + int hsa = DIV64_U64_ROUND_UP((m->hsync_end - m->hsync_start) * byte_clk, pix_clk); /* remove packet overhead when possible */ hfp = max(hfp - 6, 0);