From patchwork Thu Aug 17 18:20:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Almeida?= X-Patchwork-Id: 136066 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b82d:0:b0:3f2:4152:657d with SMTP id z13csp1669221vqi; Fri, 18 Aug 2023 13:59:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEuMpqKiZD3ADhqnNtif59ayFCTLcBfRPImcxsVopk8SrpL6GvEuFWiRLJIiQ1j8x1XZ4Hy X-Received: by 2002:a05:6a20:938d:b0:130:d5a:e40e with SMTP id x13-20020a056a20938d00b001300d5ae40emr272915pzh.7.1692392367622; Fri, 18 Aug 2023 13:59:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692392367; cv=none; d=google.com; s=arc-20160816; b=TQuq9yQ55I1OqLhcRZjNkdY5+vXP/abubDnAtbu4G6DNOmR/J4zoBRDrlz5vp03R/E Gnu6FgC5bOTvGrPfVZGDVuugqwvCVBH682sUHaSzK59pekEonPiCZV/W9Ipg+4lfc8E5 t1uZ9BKihRDElb58TTMims0oZXoATdo3JeAK3SSBcfti0wimXKnjUsNeGcGb09CDJKjc HD/ZNu64o0iKQtnZpp9y7HdHtMTBR25nrsD06eb1XmCqbbxNbQQUvbiXxabPo1DSIEr2 M6BCHtMuslHSPzy6YTwhLPSRSPUNyVyljISUye3iknYnVg8goYuQzkzUNRoVnSHOL7UZ lL9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Mrs3vloTYZU5576RzrOHkfzzCoM/F6rfj/ZXqR1qTD8=; fh=akTS0Wq8jEms5e4CIjRZ2klQmCylMzrjhYuxow3r01E=; b=hGLObdkKe2BmTCNR45tH2i2gPCNfqv1xRmgP7Of6An80B88EK3/7cT2InTTIWRmHMo z/CA8iZXW/kmDAMBj5I4K38AgeiBVZpTv/sPwxGXjoYRTMFEObqU6UtOZJhCzg+NN+F0 BvtFwU9RhaSmZin6JrlYfzU2L5FCS6p9oxm5kxqOs+FrThZNF3NGKGjExkKmwmCbmPtA 4k6uz6nXg3GCzDzPk5HWF8P2O8icmylLMnLOy/yRMMpqT2BhWzwPNe5Wl+kE19OPv6wY U+iL8Smp7zPIMo2XVC1BZE2vmXp+2F+hLYlazYvAg10kyvVtOfrZts78dXA0+Agn9TZi dmpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@igalia.com header.s=20170329 header.b=eieaTgIc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a63-20020a639042000000b00565660b78bcsi1969223pge.79.2023.08.18.13.59.13; Fri, 18 Aug 2023 13:59:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@igalia.com header.s=20170329 header.b=eieaTgIc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353418AbjHQSna (ORCPT + 99 others); Thu, 17 Aug 2023 14:43:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354506AbjHQSnR (ORCPT ); Thu, 17 Aug 2023 14:43:17 -0400 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D8D030D6 for ; Thu, 17 Aug 2023 11:43:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Mrs3vloTYZU5576RzrOHkfzzCoM/F6rfj/ZXqR1qTD8=; b=eieaTgIcBmA7Hp/wSyY49dhf29 0uVeGzMglxGKDgrcQnea2NVmNPkLQto6iDeLXEeBWMZWpqkYgamIrX/c8VWfPHJYosyjeAxrf5ckm uTfVvAwLJj/nchLsOSGBBBe1LnQTIrdox4ZG6cLg2FU3vGs888movhaDVDpNyo9UXgkrMossRmRe9 2w81kqVZvkOu6AKhA6v7l7mvos9ccgiYKGp12LYEkhtzOE3+GXW/0/9rpPGjp9cdjLnV42fnCd6tw oQk2uzM62xWn6sxeGkDtmubJRzZJEK4zps0+D6GLi2vV1b0uPrPdd05QcVjKmZdoetOT7/ryaI6pr awjvL4NA==; Received: from [191.193.179.209] (helo=steammachine.lan) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1qWhcC-0021I9-Pq; Thu, 17 Aug 2023 20:21:01 +0200 From: =?utf-8?q?Andr=C3=A9_Almeida?= To: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: kernel-dev@igalia.com, alexander.deucher@amd.com, christian.koenig@amd.com, pierre-eric.pelloux-prayer@amd.com, =?utf-8?b?J01hcmVrIE9sxaHDoWsn?= , Samuel Pitoiset , Bas Nieuwenhuizen , =?utf-8?q?Timur_Krist=C3=B3f?= , Shashank Sharma , =?utf-8?q?Andr=C3=A9_Almeida?= Subject: [PATCH v5 1/5] drm/amdgpu: Allocate coredump memory in a nonblocking way Date: Thu, 17 Aug 2023 15:20:46 -0300 Message-ID: <20230817182050.205925-2-andrealmeid@igalia.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230817182050.205925-1-andrealmeid@igalia.com> References: <20230817182050.205925-1-andrealmeid@igalia.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1774602018805512996 X-GMAIL-MSGID: 1774602018805512996 During a GPU reset, a normal memory reclaim could block to reclaim memory. Giving that coredump is a best effort mechanism, it shouldn't disturb the reset path. Change its memory allocation flag to a nonblocking one. Signed-off-by: André Almeida Reviewed-by: Christian König --- v5: no change --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index aa171db68639..bf4781551f88 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -4847,7 +4847,7 @@ static void amdgpu_reset_capture_coredumpm(struct amdgpu_device *adev) struct drm_device *dev = adev_to_drm(adev); ktime_get_ts64(&adev->reset_time); - dev_coredumpm(dev->dev, THIS_MODULE, adev, 0, GFP_KERNEL, + dev_coredumpm(dev->dev, THIS_MODULE, adev, 0, GFP_NOWAIT, amdgpu_devcoredump_read, amdgpu_devcoredump_free); } #endif