From patchwork Tue Aug 15 00:47:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vineet Gupta X-Patchwork-Id: 135680 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a888:0:b0:3f2:4152:657d with SMTP id x8csp559697vqo; Tue, 15 Aug 2023 09:53:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH5UJrXCy62g++XdicMpLFFhOEYSch32CAc9rsRIodgbbpolRu3WbN2C+YbN9/fRR9u5wk1 X-Received: by 2002:ac2:4e8f:0:b0:4fe:3724:fdb1 with SMTP id o15-20020ac24e8f000000b004fe3724fdb1mr7646624lfr.41.1692118385276; Tue, 15 Aug 2023 09:53:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692118385; cv=none; d=google.com; s=arc-20160816; b=P4UUjR4YkgxP8o5Ypuxgfmm5t/xPdASh9DBpKlQmKWjiydtr9izzd8jOdLNwQahiQb HqFUK+e91HWabMce7MfrM8Q8IgTr4c5NbPKTJ82mhiN5En0zqzls1EkJ7CuvPSBp+0Vj CfYyZbVxIusLgaE5CNvUpIrEzegS1aMClftTpNfiDT8+wywPcJBsNqPmySkpmX9Dp4An QQtSkE/Fb0HJqeeYETrMy8rkvySW0g+HzJRux5BJJLVvRgYlY13EnMhn9XkVMEoqBh2M GultgWHN0ZiWGYURS9eUyJLrZ7yPN6AAmw36W728aRXqX2/DcdVtYT9CwcNdO6+DiB6F ZzRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=k3gSRUQODwuXt/Gnv7HWRx6lryIeYtRLDVUYy0hKZUw=; fh=pU3/8cu9yvGtRhZz+04fy928CRCHy2kGYoR0fnliYkk=; b=xp1shFUvgTagxRPcDpfxSVFmf2Tm5arrGPAmLNeFuk/lhD2oSCUmx3knyfvqczt62T q8tG96OpkM9WDHvF808BTkF6rabIZM6d7jUy2PYjx4/ba/WG2qcNoSKiZtdrXMU+LfnE Meu6Jgs2+T1ZaIn2+yHEI3qyWYnD7ApPjQTVb6uNiMLaMtMMLcuCvVu1dFJyF3dXdfp3 4pWM1XjOYAataXMeR67PAODUumNMhcGCFmZOPpvIaaa0nWZZnSRGTUhXwh7gEZ5v3Ldp OYkkGioWhqLC+16TaMClHmUEUu1uKSNg4GAcXI/ykvDdRoI5Jg25/X9JzBHHlozSxYzR 1f8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kO8RZEOg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w15-20020aa7da4f000000b005257e415dd6si390039eds.482.2023.08.15.09.52.40; Tue, 15 Aug 2023 09:53:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kO8RZEOg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233678AbjHOAsa (ORCPT + 99 others); Mon, 14 Aug 2023 20:48:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233514AbjHOAsV (ORCPT ); Mon, 14 Aug 2023 20:48:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C2B31710 for ; Mon, 14 Aug 2023 17:48:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 366E764A88 for ; Tue, 15 Aug 2023 00:48:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C6D2AC433CA; Tue, 15 Aug 2023 00:48:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692060500; bh=zkG7tKNl0pma2wQFLKTamwokqNgfsNplt2WvHHW0PGA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kO8RZEOgp4rtCJQvp9wDXzhuhF7W3vI/goCzoA04uvMkG+BW64KEvcpWXKMlnfY72 jkhHSjgPy9uYEOCcFrDtkCbCn2Z6aSS0ghRRTfSrPAGN4GF0ilZ5K+kUmmJR5+etfZ Ius1ROSzMsZwSVd3AZVpmi+7vQl3Ejjtb7z3B/vgP3/t+UVWcMd7E1y1sB1Cd/UlNZ UQaeO7GTK9aqkt32A5/Xei8MX0D5AK0LJkypV+gUXCwv74P+opA8zGqmt3fID7t/xf yWVUgdv2UjxM03uEtOaS3JcAfIj40GKCirBj6lIOv7AYRYJeXz2dAhC1LeKXQ/ZmH3 YI4mQFHuPInIQ== From: Vineet Gupta To: linux-snps-arc@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Shahab Vahedi , Alexey Brodkin , Vineet Gupta Subject: [PATCH 04/20] ARCv2: memset: don't prefetch for len == 0 which happens a alot Date: Mon, 14 Aug 2023 17:47:57 -0700 Message-Id: <20230815004813.555115-5-vgupta@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230815004813.555115-1-vgupta@kernel.org> References: <20230815004813.555115-1-vgupta@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1774314727858158653 X-GMAIL-MSGID: 1774314727858158653 This avoids potential "bleeding" when size == 0 as cache line would be dirtied (and possibly fetched from other cores) and due to the same reaons more optimal too. Signed-off-by: Vineet Gupta --- arch/arc/lib/memset-archs.S | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arc/lib/memset-archs.S b/arch/arc/lib/memset-archs.S index d2e09fece5bc..d0a5cec4cdca 100644 --- a/arch/arc/lib/memset-archs.S +++ b/arch/arc/lib/memset-archs.S @@ -36,12 +36,13 @@ #endif ENTRY_CFI(memset) - PREFETCHW_INSTR r0, 0 ; Prefetch the first write location mov.f 0, r2 ;;; if size is zero jz.d [blink] mov r3, r0 ; don't clobber ret val + PREFETCHW_INSTR r0, 0 ; Prefetch the first write location + ;;; if length < 8 brls.d.nt r2, 8, .Lsmallchunk mov.f lp_count,r2