From patchwork Tue Aug 15 20:58:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Stitt X-Patchwork-Id: 136100 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b82d:0:b0:3f2:4152:657d with SMTP id z13csp1948203vqi; Sat, 19 Aug 2023 03:32:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGWah2Qf2P4ZhRISoyv2Ghb8GBd/WJ5A7B6+oVGOgZq7A4BOarfIQZXOzGiHdumvrfodkE+ X-Received: by 2002:a05:6830:18f1:b0:6b8:82ed:ea2e with SMTP id d17-20020a05683018f100b006b882edea2emr2151299otf.4.1692441170788; Sat, 19 Aug 2023 03:32:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692441170; cv=none; d=google.com; s=arc-20160816; b=qs4Y7Z6OJeGur93GnPdE6EUHKKYKvJOMMqMfkVAXth7eik/QEBXepggHTuipdOAQUx 2JBfDpUzSyD60UPuEnPNcKOOh/DsZOZQFx7rfy3xN2wNZwpQfJHuFXAFmBc8akiLjEQJ MWgnsqUd6tocvh0kifppYWHuFzyxmC/Dz02dwIJxTVSsSd3SXIVpYlE+j/a+RdmoJZZk OA4S8HhQbe5uKSsG2b7oSdJjoeQKFpLNlu9tGYMi/1M4rafLsTvjupv7w9MTFzg4IYr4 jAr44YXiCip8T2bJAqxZ1w92aE0Z3WSw9C7SFPj2ZGEpIOl5zBRxnNFb2jyz85wl5zD4 UMtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:mime-version:date :dkim-signature; bh=i43ino8+cQV5fs59YFTMpgpy3gd6Kvhnph8ypvpU1+E=; fh=EGECBxqE2MeItHqiKhSWaNXqDU3inwBx11GH/Pr+oiw=; b=ZvCGbNqRmfw8zRPVs+2Xuio0fJS/GCIuSdKmH/qRQtc6SG61msPxwt9wYKhzEDQAJc M01N18F5xJnFma+CTakn0W5G+0csNlGgH0Sj+BoazZJ/flD8AmqXAtSkXQVmyX3ob7Tw IgkeO+8s5490d+CuVWeO7WYsE/7w6DAVH873dgPhT56As4Kk0NQj+ETG9hc3Dt/rQZTf XDqjUXGmFClZ63yEZXje/lDbUgazhbkx+SnZudlr7xL2vSwHMVjRCKcNJ6bSjZ658iW8 +n/cWEiLNsKXB+TV7v1chr1F0fF+YwMIdyfpRNwlgRYG+4MAdkcVH8/m7Ld+KJmO6/Z0 noOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=OaxNZF0X; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id b17-20020a656691000000b005693cdd9a9csi3059247pgw.74.2023.08.19.03.32.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Aug 2023 03:32:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=OaxNZF0X; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 99AA44CD4C; Sat, 19 Aug 2023 01:31:30 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239624AbjHOU67 (ORCPT + 99 others); Tue, 15 Aug 2023 16:58:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239774AbjHOU6u (ORCPT ); Tue, 15 Aug 2023 16:58:50 -0400 Received: from mail-ot1-x349.google.com (mail-ot1-x349.google.com [IPv6:2607:f8b0:4864:20::349]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 741171B2 for ; Tue, 15 Aug 2023 13:58:49 -0700 (PDT) Received: by mail-ot1-x349.google.com with SMTP id 46e09a7af769-6b9c09823e7so5590632a34.1 for ; Tue, 15 Aug 2023 13:58:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1692133129; x=1692737929; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=i43ino8+cQV5fs59YFTMpgpy3gd6Kvhnph8ypvpU1+E=; b=OaxNZF0XeYWAxRvthJD35Tl9i7hNdMx3tQUmVK3WMKxUOPWVZGqtu8tPhOn+L5tulx xuSR6QwuQzjucbrKrku+UFgwmRL4KepxrquekQ9XHqbI9qnEr9712T3kQUag/EbT7vDe QKpZGn2ap+1vWwydxynUDL3mkCGS6wDvdjEhMHvAqZp847wBPjwKQhp5cZRrFsUmyZ83 L36Dlb6XMxbhYXcEZ0hmMRqvzFFXIdZieTZG9HOC7jXZerkC72IDSE9I8tFL7ile8CsV wep05GdDlBWhqmhhg387YEwJgwmZDYQO97zOyx/XphXe/2FcRkPN8ScnustwRB+2yLyC 6q+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692133129; x=1692737929; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=i43ino8+cQV5fs59YFTMpgpy3gd6Kvhnph8ypvpU1+E=; b=R5T4yPDT+tHO/25kq1v5eyDRetKpoR36HUfr85Znw1i1UqA4vtquhISZuRPmgPEvvt 5ggZGkc8ira9c4tMKk8BFUotFDn24oYz0Zvs7U/bYy5tPgHoPawjVo2KJxxtDs/n65Jr G2KFnK2NKtYTnVMC62HdHscHnKipFxTzYE+4VOcCLaNbRbKNUkJ2XQf6mAA0/GVhfCqU bnFy5noiI1eoXhlbGa+hUUNfgy2X8OmMfpg8xRL/t3BLSyig3O4A8e8rpIKTsLgDN570 snUK7DhdvRiWDMvo6nxAWrsD35O+Cy6LyTGXZmn4YkAGDlYVppwUYb0MqSOfkiZsICgR jLlw== X-Gm-Message-State: AOJu0YyWqYdzto7ZI7UP5+eqUiB37xqoJxqFSolxgZtaK6yMaUfD55Sj y0izyzeLPaxCtGP+qCIngIwPF8/Wl+gJMkEvrw== X-Received: from jstitt-linux1.c.googlers.com ([fda3:e722:ac3:cc00:2b:ff92:c0a8:23b5]) (user=justinstitt job=sendgmr) by 2002:a05:6870:8c34:b0:1bb:6791:cc68 with SMTP id ec52-20020a0568708c3400b001bb6791cc68mr216505oab.3.1692133128823; Tue, 15 Aug 2023 13:58:48 -0700 (PDT) Date: Tue, 15 Aug 2023 20:58:47 +0000 Mime-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAAfn22QC/x3NTQoCMQxA4asMWRtoOz8UryIitUk1CzOSDlUY5 u4Wl9/mvR0qm3CF87CDcZMqq3b40wD5mfTBKNQNwYXRRT9jW4WQTBpbxddGqEkJLX2wlcW7m5a MSx7nWKYw3WOCXnobF/n+L5frcfwAXHqUeXUAAAA= X-Developer-Key: i=justinstitt@google.com; a=ed25519; pk=tC3hNkJQTpNX/gLKxTNQKDmiQl6QjBNCGKJINqAdJsE= X-Developer-Signature: v=1; a=ed25519-sha256; t=1692133128; l=1875; i=justinstitt@google.com; s=20230717; h=from:subject:message-id; bh=y2JbzG62AXClW5TbICNapFpMx9TWmAr5KjVSEN24CHY=; b=ph2dAzVEzI/Hp2y1+thActuqF4avgbTqiwLRd0iD0lkfUbCpSWXtXOTntsjxLLcfcDGOL6GDD Zd6jcbvOxHWDmRwh4JoND6QutLqs/72t+7bRVE1J9SSS0NDidFEsL/U X-Mailer: b4 0.12.3 Message-ID: <20230815-void-drivers-mtd-nand-raw-vf610_nfc-v1-1-7cc65314c56c@google.com> Subject: [PATCH] mtd: rawnand: fix -Wvoid-pointer-to-enum-cast warning From: Justin Stitt To: Stefan Agner , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Nathan Chancellor , Nick Desaulniers , Tom Rix Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Justin Stitt X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1774653192850975542 X-GMAIL-MSGID: 1774653192850975542 When building with clang 18 I see the following warning: | drivers/mtd/nand/raw/vf610_nfc.c:853:17: warning: cast to smaller integer | type 'enum vf610_nfc_variant' from 'const void *' [-Wvoid-pointer-to-enum-cast] | 853 | nfc->variant = (enum vf610_nfc_variant)of_id->data; This is due to the fact that `of_id->data` is a void* while `enum vf610_nfc_variant` has the size of an int. This leads to truncation and possible data loss. Link: https://github.com/ClangBuiltLinux/linux/issues/1910 Reported-by: Nathan Chancellor Signed-off-by: Justin Stitt --- Note: There is likely no data loss actually occurring here due to the fact that `enum vf610_nfc_variant` only has a few fields which are not nearly large enough to cause data loss. This patch helps towards the goal of eventually enabling this warning. Also, should we use `unsigned long` here instead of `uintptr_t`? I've seen maintainers request both and I'm flipping a coin here. --- drivers/mtd/nand/raw/vf610_nfc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 2ccdd1b13c591d306f0401d98dedc4bdcd02b421 change-id: 20230815-void-drivers-mtd-nand-raw-vf610_nfc-6c358f424b8a Best regards, -- Justin Stitt diff --git a/drivers/mtd/nand/raw/vf610_nfc.c b/drivers/mtd/nand/raw/vf610_nfc.c index 86522048e271..11d996dc655d 100644 --- a/drivers/mtd/nand/raw/vf610_nfc.c +++ b/drivers/mtd/nand/raw/vf610_nfc.c @@ -850,7 +850,7 @@ static int vf610_nfc_probe(struct platform_device *pdev) goto err_disable_clk; } - nfc->variant = (enum vf610_nfc_variant)of_id->data; + nfc->variant = (uintptr_t)of_id->data; for_each_available_child_of_node(nfc->dev->of_node, child) { if (of_device_is_compatible(child, "fsl,vf610-nfc-nandcs")) {