[v2,2/6] dt-bindings: perf: Add Marvell PEM performance monitor unit
Commit Message
Add binding documentation for Marvell PEM performance monitor unit.
Signed-off-by: Linu Cherian <lcherian@marvell.com>
Signed-off-by: Gowthami Thiagarajan <gthiagarajan@marvell.com>
---
v1->v2
- Changed DT binding file name to match with compatible
- Added respective document in MAINTAINERS
.../perf/marvell,odyssey-pem-pmu.yaml | 38 +++++++++++++++++++
MAINTAINERS | 1 +
2 files changed, 39 insertions(+)
create mode 100644 Documentation/devicetree/bindings/perf/marvell,odyssey-pem-pmu.yaml
Comments
On 12/08/2023 16:25, Gowthami Thiagarajan wrote:
> Add binding documentation for Marvell PEM performance monitor unit.
>
> Signed-off-by: Linu Cherian <lcherian@marvell.com>
> Signed-off-by: Gowthami Thiagarajan <gthiagarajan@marvell.com>
> ---
>
> v1->v2
> - Changed DT binding file name to match with compatible
> - Added respective document in MAINTAINERS
>
> .../perf/marvell,odyssey-pem-pmu.yaml | 38 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 39 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/perf/marvell,odyssey-pem-pmu.yaml
>
> diff --git a/Documentation/devicetree/bindings/perf/marvell,odyssey-pem-pmu.yaml b/Documentation/devicetree/bindings/perf/marvell,odyssey-pem-pmu.yaml
> new file mode 100644
> index 000000000000..a761fc09565b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/perf/marvell,odyssey-pem-pmu.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/perf/marvell,odyssey-pem-pmu.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell PCIe interface performance monitor
> +
> +maintainers:
> + - Linu Cherian <lcherian@marvell.com>
> + - Gowthami Thiagarajan <gthiagarajan@marvell.com>
> +
> +properties:
> + compatible:
> + items:
Drop items, you have just enum.
> + - enum:
> + - marvell,odyssey-pem-pmu
Neither commit msg nor description in the binding (there is none!) helps
me to understand what is the SoC here. Remember: compatibles are
specific to SoCs, not families.
Best regards,
Krzysztof
new file mode 100644
@@ -0,0 +1,38 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/perf/marvell,odyssey-pem-pmu.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Marvell PCIe interface performance monitor
+
+maintainers:
+ - Linu Cherian <lcherian@marvell.com>
+ - Gowthami Thiagarajan <gthiagarajan@marvell.com>
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - marvell,odyssey-pem-pmu
+
+ reg:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ bus {
+ #address-cells = <2>;
+ #size-cells = <2>;
+
+ pmu@8e0000005000 {
+ compatible = "marvell,odyssey-pem-pmu";
+ reg = <0x8e00 0x00005000 0x0 0x3000>;
+ };
+ };
@@ -12582,6 +12582,7 @@ MARVELL PEM PMU DRIVER
M: Linu Cherian <lcherian@marvell.com>
M: Gowthami Thiagarajan <gthiagarajan@marvell.com>
S: Supported
+F: Documentation/devicetree/bindings/perf/marvell,odyssey-pem-pmu.yaml
F: drivers/perf/marvell_pem_pmu.c
MARVELL PRESTERA ETHERNET SWITCH DRIVER