Message ID | 20230812052947.22913-1-rdunlap@infradead.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b824:0:b0:3f2:4152:657d with SMTP id z4csp1545319vqi; Fri, 11 Aug 2023 23:12:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHhhrYe9EeC6DCefmkP6l4XoedvoSv2BvnBtwby+0Ar7tYeWheJ7NlzXJDsXZ6DM/Yrvmtg X-Received: by 2002:a05:6a20:b703:b0:140:ca4c:740a with SMTP id fg3-20020a056a20b70300b00140ca4c740amr4008770pzb.29.1691820722195; Fri, 11 Aug 2023 23:12:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691820722; cv=none; d=google.com; s=arc-20160816; b=gOLsausKL2+qblDw2ESVOlCjYmCTjNF1UMCZDscfS0lTW/5oX4+vZUfKHeDqTZiajB wfOtcgg1svnKQK+iVqp+7dFizLa0/JwmC72NoPLe/MC8PfKgHV78OR1tphbfGbszTv3G FWDKxYSzRTx3GxsNwxav7oqs8MnmT3RYA1PK659w70XFmQq6JeNkZTgQCzJenYwnayV+ VSxVfSsjkmDjZO5IsveN6XSKS3HaDKF3gv09p1Zvtt+nxs+sn6MBk2DCRfHtPDtx+2Gf 8SQff01VrK0Q10Mqbt+WG5tshW0k3x88uZt+AeMTDdSqgSvrjnIn51ld47a1WRaemH2m OzhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=g5NFUKgbQYz1dATIngsvfO0U1dhl0IZLO4aTbVVSTIg=; fh=GSakQVtZrjk4BJOidUgxtw2qI60EkF89hi71KvZVNYY=; b=Y3lEa7N+kRxmQgWSGiCl4QpjwDPH1k8xROUlnw8jmnzXXYNWFdwT1dKjtreDPgFMqy cAPznLihCqnuCpY11iqDPFCRsghRGMNpy8LFGpCQzq2uuHJ5ERmS+1q7zOEKR2ZSUYZg y5/llywtVAZ7Xk304xF0TiIdDCI7mL/txqQzaR1GbmOzyugQbmwnTMKTeuTwQynhOFLN OCUNSqpTYGUoLEWfoSdORme30c4cVg3jl5t1wdMeOpObQhBfpH2WIyzpFRRLWVdJ6jrO Z5xVt0iwCJuMfoLLwxm7tcxA9KjR03pck16FRjYXR60SkXO2z7pXk/BkD2Y7ehbAk0jP w3gA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=jO9TgWer; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bg26-20020a056a02011a00b0051b90567f99si4462678pgb.690.2023.08.11.23.11.47; Fri, 11 Aug 2023 23:12:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=jO9TgWer; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235234AbjHLF3w (ORCPT <rfc822;lanlanxiyiji@gmail.com> + 99 others); Sat, 12 Aug 2023 01:29:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229595AbjHLF3v (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 12 Aug 2023 01:29:51 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DCB22728; Fri, 11 Aug 2023 22:29:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=g5NFUKgbQYz1dATIngsvfO0U1dhl0IZLO4aTbVVSTIg=; b=jO9TgWeryajGwbsedVXMLlZz+2 9FGP9xqBmaMHODdzaU+0NIgdaRHh1ILlPo3YN20+6Je2QcDozgyIAgxmG0UW1bW5B7VnvYFFhrt6R GT3nTiZPmphmLhluO1CNJPNCfocsWk4obOsXW58QOka2dGi+89DWrOmk7zwjIZqeteUu+hX9wE7ky LnJYdN1/xF/E3rD7AwRW/BMz6MTi7jiTiwz8+M43+DMJuaAb7b1LoDu/YtL6CF31z0CuV9dWgXl+7 aaScFOVLgsCOfLZEaFKxDOtyrRvzHmwQ+tkVdLNMPVFAizdWZCB0VGL/luH71TwAhwUJCdZoNnbVs QUzhlSpQ==; Received: from [2601:1c2:980:9ec0::2764] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qUhCA-00Chm0-2O; Sat, 12 Aug 2023 05:29:50 +0000 From: Randy Dunlap <rdunlap@infradead.org> To: linux-kernel@vger.kernel.org Cc: Randy Dunlap <rdunlap@infradead.org>, kernel test robot <lkp@intel.com>, Krishnanand Prabhu <krishnanand.prabhu@intel.com>, Luca Coelho <luciano.coelho@intel.com>, Gregory Greenman <gregory.greenman@intel.com>, Johannes Berg <johannes.berg@intel.com>, Kalle Valo <kvalo@kernel.org>, linux-wireless@vger.kernel.org, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org Subject: [PATCH net] wifi: iwlwifi: mvm: add dependency for PTP clock Date: Fri, 11 Aug 2023 22:29:47 -0700 Message-ID: <20230812052947.22913-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1774002605468601554 X-GMAIL-MSGID: 1774002605468601554 |
Series |
[net] wifi: iwlwifi: mvm: add dependency for PTP clock
|
|
Commit Message
Randy Dunlap
Aug. 12, 2023, 5:29 a.m. UTC
When the code to use the PTP HW clock was added, it didn't update
the Kconfig entry for the PTP dependency, leading to build errors,
so update the Kconfig entry to depend on PTP_1588_CLOCK_OPTIONAL.
aarch64-linux-ld: drivers/net/wireless/intel/iwlwifi/mvm/ptp.o: in function `iwl_mvm_ptp_init':
drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:294: undefined reference to `ptp_clock_register'
drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:294:(.text+0xce8): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ptp_clock_register'
aarch64-linux-ld: drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:301: undefined reference to `ptp_clock_index'
drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:301:(.text+0xd18): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ptp_clock_index'
aarch64-linux-ld: drivers/net/wireless/intel/iwlwifi/mvm/ptp.o: in function `iwl_mvm_ptp_remove':
drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:315: undefined reference to `ptp_clock_index'
drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:315:(.text+0xe80): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ptp_clock_index'
aarch64-linux-ld: drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:319: undefined reference to `ptp_clock_unregister'
drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:319:(.text+0xeac): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ptp_clock_unregister'
Fixes: 1595ecce1cf3 ("wifi: iwlwifi: mvm: add support for PTP HW clock (PHC)")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/all/202308110447.4QSJHmFH-lkp@intel.com/
Cc: Krishnanand Prabhu <krishnanand.prabhu@intel.com>
Cc: Luca Coelho <luciano.coelho@intel.com>
Cc: Gregory Greenman <gregory.greenman@intel.com>
Cc: Johannes Berg <johannes.berg@intel.com>
Cc: Kalle Valo <kvalo@kernel.org>
Cc: linux-wireless@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org
---
drivers/net/wireless/intel/iwlwifi/Kconfig | 1 +
1 file changed, 1 insertion(+)
Comments
+ Richard Cochran On Fri, Aug 11, 2023 at 10:29:47PM -0700, Randy Dunlap wrote: > When the code to use the PTP HW clock was added, it didn't update > the Kconfig entry for the PTP dependency, leading to build errors, > so update the Kconfig entry to depend on PTP_1588_CLOCK_OPTIONAL. > > aarch64-linux-ld: drivers/net/wireless/intel/iwlwifi/mvm/ptp.o: in function `iwl_mvm_ptp_init': > drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:294: undefined reference to `ptp_clock_register' > drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:294:(.text+0xce8): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ptp_clock_register' > aarch64-linux-ld: drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:301: undefined reference to `ptp_clock_index' > drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:301:(.text+0xd18): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ptp_clock_index' > aarch64-linux-ld: drivers/net/wireless/intel/iwlwifi/mvm/ptp.o: in function `iwl_mvm_ptp_remove': > drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:315: undefined reference to `ptp_clock_index' > drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:315:(.text+0xe80): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ptp_clock_index' > aarch64-linux-ld: drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:319: undefined reference to `ptp_clock_unregister' > drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:319:(.text+0xeac): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ptp_clock_unregister' > > Fixes: 1595ecce1cf3 ("wifi: iwlwifi: mvm: add support for PTP HW clock (PHC)") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Reported-by: kernel test robot <lkp@intel.com> > Link: https://lore.kernel.org/all/202308110447.4QSJHmFH-lkp@intel.com/ > Cc: Krishnanand Prabhu <krishnanand.prabhu@intel.com> > Cc: Luca Coelho <luciano.coelho@intel.com> > Cc: Gregory Greenman <gregory.greenman@intel.com> > Cc: Johannes Berg <johannes.berg@intel.com> > Cc: Kalle Valo <kvalo@kernel.org> > Cc: linux-wireless@vger.kernel.org > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Eric Dumazet <edumazet@google.com> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Paolo Abeni <pabeni@redhat.com> > Cc: netdev@vger.kernel.org Reviewed-by: Simon Horman <horms@kernel.org> Tested-by: Simon Horman <horms@kernel.org> # build-tested > --- > drivers/net/wireless/intel/iwlwifi/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff -- a/drivers/net/wireless/intel/iwlwifi/Kconfig b/drivers/net/wireless/intel/iwlwifi/Kconfig > --- a/drivers/net/wireless/intel/iwlwifi/Kconfig > +++ b/drivers/net/wireless/intel/iwlwifi/Kconfig > @@ -66,6 +66,7 @@ config IWLMVM > tristate "Intel Wireless WiFi MVM Firmware support" > select WANT_DEV_COREDUMP > depends on MAC80211 > + depends on PTP_1588_CLOCK_OPTIONAL > help > This is the driver that supports the MVM firmware. The list > of the devices that use this firmware is available here: >
diff -- a/drivers/net/wireless/intel/iwlwifi/Kconfig b/drivers/net/wireless/intel/iwlwifi/Kconfig --- a/drivers/net/wireless/intel/iwlwifi/Kconfig +++ b/drivers/net/wireless/intel/iwlwifi/Kconfig @@ -66,6 +66,7 @@ config IWLMVM tristate "Intel Wireless WiFi MVM Firmware support" select WANT_DEV_COREDUMP depends on MAC80211 + depends on PTP_1588_CLOCK_OPTIONAL help This is the driver that supports the MVM firmware. The list of the devices that use this firmware is available here: