From patchwork Fri Aug 11 17:00:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frederic Weisbecker X-Patchwork-Id: 134626 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b824:0:b0:3f2:4152:657d with SMTP id z4csp1259684vqi; Fri, 11 Aug 2023 10:52:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFeHRdALWUYLZ67uGxxVo+QTqierO88z4gbcLCrv2Ua99gNzLB51u6ayT37icrnEJUi9Qnu X-Received: by 2002:aa7:c911:0:b0:523:364b:e6a9 with SMTP id b17-20020aa7c911000000b00523364be6a9mr2112119edt.38.1691776340835; Fri, 11 Aug 2023 10:52:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691776340; cv=none; d=google.com; s=arc-20160816; b=KlJIx++OKbkia25WUT6QxZPlR1a54HJAJJGyhyFpUs7XrXHSFasx9HzLB9OX7iUunp Hnij564rHqQF3EAGHU6HUD/MGeqK/QQ0Cj9WAhSdgV1wGr8PqPeo7LBqxcNd+uB9yH8D ubu44bwbY26AKQf5pCU1EP/zXlDHMtttrGG90VQtSfuHSXMfUt7G7OM3twNJZ7FPVYEl vrj3W/n/+nqkH+EIq17QZofbLegSoDfplVdQ5mYrDLpZuEkahS9lEBxeK3jiHWLlOWRc qZAUrF/B76z6FLHk+PxDsVlhJ2S78lyn1ND0U1LlC0TUcn4hqjYA6wziXsl8NVnarGuw nPXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=UwW1cMHX8vYlcia3JmzEH5ATHx/9nmzLSsas3qKjsfU=; fh=K1m6n+brToPLMsYko3rtXKxC+lCostu9M84onRqB7cU=; b=M2MXIjVkxGoMSgdzAcrStDvov8mcgmHsmNkEYk0JMAJqFqe2mKM3GCC+DqF8G+IfP6 qCszgSY8w6ufZFnA1OuSJf7HQ9O+WB5U420KWEcbQiWIsW1eF4f8BDsleNRwWXOjwHZj ZpxtGg/63xCdoWAXnuHDLhYiUcqOslj6nGf3mP9WOFMT1Sm62GadaA2YA0pDXB4JJNHg k42RrbeH+iiLFop8n+0AiCHy2ivaM5V+T1rq5QyW/rMJv1GWAV7SOjfgLFg+2fACdR3k CHXg5zpFBOz+lodDq/mbBkUJka5TvXTRvhgKeL7KkJrTxGny0Ley47okOhsMrNoqGPyq mq1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=A4PolbeR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d2-20020a50ea82000000b005233d031616si3965786edo.556.2023.08.11.10.51.56; Fri, 11 Aug 2023 10:52:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=A4PolbeR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236359AbjHKRBh (ORCPT + 99 others); Fri, 11 Aug 2023 13:01:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236208AbjHKRBQ (ORCPT ); Fri, 11 Aug 2023 13:01:16 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB52C30CF for ; Fri, 11 Aug 2023 10:01:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 61BBA645D4 for ; Fri, 11 Aug 2023 17:01:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30619C433BA; Fri, 11 Aug 2023 17:01:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691773270; bh=TVovZjwyix5rQdhW8ECdApx6w3lNWl+b+lPUjWG+UIw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=A4PolbeRtyjUDFVWk+7yFw7BYAFBwaI4HrMy6fwJNiTWTirl79pOSGigmrem5nhhh N2kc0CnhxTT5A+ddzcDvVN90XSyvLjVp0XdycOwkMO8WHTqGcOEiGtE2vjixmyjkdj v02fmOiWR09SWyMYyW6mksAtAZp31nh1M4vDoJFTAjK/GgO/J2+97rgUMnRuScK1f3 Ye0JvYUa80GerYbElkN0TchAmUmsvacjyoGg1nNFhmLQkFrem36wwm6EeE0lTzooOu CBm6UAIJXt3rHZnpoPtTrd35G1eB8egqnGgoK0bSYg+ujZiEX9AdpP1Tb+wcKGEFZn yulqZnvlHCM5w== From: Frederic Weisbecker To: LKML Cc: Frederic Weisbecker , Peter Zijlstra , "Rafael J . Wysocki" , Daniel Lezcano , Thomas Gleixner , Anna-Maria Behnsen Subject: [PATCH 07/10] cpuidle: Remove unnecessary current_clr_polling() on poll_idle() Date: Fri, 11 Aug 2023 19:00:46 +0200 Message-Id: <20230811170049.308866-8-frederic@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230811170049.308866-1-frederic@kernel.org> References: <20230811170049.308866-1-frederic@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773956068527572040 X-GMAIL-MSGID: 1773956068527572040 There is no point in clearing TIF_NR_POLLING and folding TIF_NEED_RESCHED upon poll_idle() exit because cpuidle_idle_call() is going to set again TIF_NR_POLLING anyway. Also if TIF_NEED_RESCHED is set, it will be folded and TIF_NR_POLLING will be cleared at the end of do_idle(). Signed-off-by: Frederic Weisbecker Acked-by: Rafael J. Wysocki --- drivers/cpuidle/poll_state.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/cpuidle/poll_state.c b/drivers/cpuidle/poll_state.c index 009f46f121ae..44a656464d06 100644 --- a/drivers/cpuidle/poll_state.c +++ b/drivers/cpuidle/poll_state.c @@ -48,8 +48,6 @@ static int __cpuidle poll_idle(struct cpuidle_device *dev, } raw_local_irq_disable(); - current_clr_polling(); - return index; }