From patchwork Fri Aug 11 17:00:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frederic Weisbecker X-Patchwork-Id: 134612 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b824:0:b0:3f2:4152:657d with SMTP id z4csp1253031vqi; Fri, 11 Aug 2023 10:38:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH2ZZ0rZyLqtDCbxy/EEYI2L0AhgYCY5rQXIXsd7dFrIFcsUPKNEMn1Gwxo/ipMAjn59hv4 X-Received: by 2002:a17:903:41c5:b0:1b5:64a4:bea0 with SMTP id u5-20020a17090341c500b001b564a4bea0mr3000360ple.10.1691775484154; Fri, 11 Aug 2023 10:38:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691775484; cv=none; d=google.com; s=arc-20160816; b=yfMgLBgtn2Ph4kz85Ag8XhDAi8BoqTcyimCHn0cSDb9xzGUW3T/C1g098tSMrJ66wj 5mxkwx4XKuOvmMNrzOmDx94Mol1l9E5qq0chXJ5ZvfsdwQZ/WpN/6NUko48tJhz7xOQy jZnSYuByR5k/8e3eRhFev2pEbhoG0rESAG5JhIM3gnCDQGv866/n3LrBP/6ak88qEC18 EUIpM+1xmOkAERcSKgpqj8oI08B14IpQ/peVvGoYmFPtcebOAP806Oi/Le62BAlmHo/J Je6pyPw/TyOluNgDYhnZ8nSkxTtECkURjtt8ykwkBftl2zK3PnhJMtIo1iNFcmB5JBOJ /uPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=4xeqmHl2t+YnJfov58NB3HrnsAyJLsX10R2Tffj5RqA=; fh=pQeWpAa0NFKPT5g/38wXju99oTS1bj4HpHnsse8R7XM=; b=fvYjalVCsbC6n6dVVm8G3DVxTPSBW9rGd6Gu4bb8eUtlpFni1gEwP+7cFvUXigRtd3 1mSBYfKQOqAlcx4d241hA2xvYW+lartMOoYa06rwTxIt+hhVIs9Du6jyv+s9Ypdl7jD4 sjux8CDySEORJXK0wqU0IxUbWuRpNR32VOWsruAxcP0G5BQNo/kveh9YsceF2JcUK7ZV k3SYatI0oB2rg8t15Sd5IOtO70GZkZAT4u5XtqNGqV3nBhSJxl4HlzNZVNmWbgiOsZqD qNPR/i19Jn/+PMIAALHICO99P+4f0B2IlHTvxcJH4NLVQGAvlopXqNWpQ8+3Uz0giG7Y cvPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NhgGjX14; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b10-20020a170903228a00b001bb993ef74dsi3673835plh.461.2023.08.11.10.37.45; Fri, 11 Aug 2023 10:38:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NhgGjX14; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236210AbjHKRBc (ORCPT + 99 others); Fri, 11 Aug 2023 13:01:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234617AbjHKRBP (ORCPT ); Fri, 11 Aug 2023 13:01:15 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C337B35A9 for ; Fri, 11 Aug 2023 10:01:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4C316645D4 for ; Fri, 11 Aug 2023 17:01:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC1BAC433C7; Fri, 11 Aug 2023 17:01:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691773268; bh=1NQPETUBxztpoNgtonFeGuuxCy+oiM7V1jas7MgPpLw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NhgGjX14Vfxa5mHU4CwZ2RvYwEyiALn1takLmpPnUFScmOqNOLb0xTxOhL1wecuIS dMQBaSRZK7lU0sYnl1m4AKEEZJsC+GDq86xovFbDEUqs2OoqKC5F0/tNP7MOzZQD8Z GTn92asL7geG3HT25qM9kIileTY0/BNd0CIotA8zwuKZ8G/VX6V3qXCWkZAi5H16ni scdvr1dq69gt2tSYU5VnJS/bPiV2FeaeH5yNcVqNZCWd9lWLK7JFpI6pdOYRNs6fG3 XUwWGuwqqyEnTInszoWbFfRtaWNeqjUM3iM0GnYPZQIcOfLhmJP9IrMCwx2LjTQbif od+SqAWYBmbaA== From: Frederic Weisbecker To: LKML Cc: Frederic Weisbecker , Marcelo Tosatti , Peter Zijlstra , "Rafael J . Wysocki" , Daniel Lezcano , Thomas Gleixner , Anna-Maria Behnsen Subject: [PATCH 06/10] cpuidle: Remove unnecessary current_clr_polling_and_test() from haltpoll Date: Fri, 11 Aug 2023 19:00:45 +0200 Message-Id: <20230811170049.308866-7-frederic@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230811170049.308866-1-frederic@kernel.org> References: <20230811170049.308866-1-frederic@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773955169976061660 X-GMAIL-MSGID: 1773955169976061660 When cpuidle drivers ->enter() callback are called, the TIF_NR_POLLING flag is cleared already and TIF_NEED_RESCHED checked by call_cpuidle(). Therefore calling current_clr_polling_and_test() is redundant here and further setting of TIF_NEED_RESCHED will result in an IPI and thus an idle loop exit. This call can be safely removed. Cc: Marcelo Tosatti Signed-off-by: Frederic Weisbecker Acked-by: Rafael J. Wysocki --- drivers/cpuidle/cpuidle-haltpoll.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/cpuidle/cpuidle-haltpoll.c b/drivers/cpuidle/cpuidle-haltpoll.c index e66df22f9695..b641bc535102 100644 --- a/drivers/cpuidle/cpuidle-haltpoll.c +++ b/drivers/cpuidle/cpuidle-haltpoll.c @@ -28,11 +28,8 @@ static enum cpuhp_state haltpoll_hp_state; static int default_enter_idle(struct cpuidle_device *dev, struct cpuidle_driver *drv, int index) { - if (current_clr_polling_and_test()) { - local_irq_enable(); - return index; - } arch_cpu_idle(); + return index; }