diff mbox series

[1/2] gpio: sim: simplify gpio_sim_device_config_live_store()

Message ID 20230811131427.40466-1-brgl@bgdev.pl
State New
Headers
Series [1/2] gpio: sim: simplify gpio_sim_device_config_live_store() |

Commit Message

Bartosz Golaszewski Aug. 11, 2023, 1:14 p.m. UTC 
  From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Simplify the logic when checking the current live value against the user
input.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
This is the same as what Andy suggested for gpio-consumer. Let's save a
line.

 drivers/gpio/gpio-sim.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Andy Shevchenko Aug. 11, 2023, 2:03 p.m. UTC | #1 
On Fri, Aug 11, 2023 at 03:14:26PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> Simplify the logic when checking the current live value against the user
> input.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> This is the same as what Andy suggested for gpio-consumer. Let's save a
> line.

Right.
Bartosz Golaszewski Aug. 12, 2023, 6:32 p.m. UTC | #2 
On Fri, Aug 11, 2023 at 3:14 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Simplify the logic when checking the current live value against the user
> input.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> This is the same as what Andy suggested for gpio-consumer. Let's save a
> line.
>
>  drivers/gpio/gpio-sim.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
> index dc4097dc0fbc..0177b41e0d72 100644
> --- a/drivers/gpio/gpio-sim.c
> +++ b/drivers/gpio/gpio-sim.c
> @@ -986,8 +986,7 @@ gpio_sim_device_config_live_store(struct config_item *item,
>
>         mutex_lock(&dev->lock);
>
> -       if ((!live && !gpio_sim_device_is_live_unlocked(dev)) ||
> -           (live && gpio_sim_device_is_live_unlocked(dev)))
> +       if (live == gpio_sim_device_is_live_unlocked(dev))
>                 ret = -EPERM;
>         else if (live)
>                 ret = gpio_sim_device_activate_unlocked(dev);
> --
> 2.39.2
>

Applied.

Bart
diff mbox series

Patch

diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
index dc4097dc0fbc..0177b41e0d72 100644
--- a/drivers/gpio/gpio-sim.c
+++ b/drivers/gpio/gpio-sim.c
@@ -986,8 +986,7 @@  gpio_sim_device_config_live_store(struct config_item *item,
 
 	mutex_lock(&dev->lock);
 
-	if ((!live && !gpio_sim_device_is_live_unlocked(dev)) ||
-	    (live && gpio_sim_device_is_live_unlocked(dev)))
+	if (live == gpio_sim_device_is_live_unlocked(dev))
 		ret = -EPERM;
 	else if (live)
 		ret = gpio_sim_device_activate_unlocked(dev);