Message ID | 20230811120220.31578-1-raag.jadav@intel.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b824:0:b0:3f2:4152:657d with SMTP id z4csp1100015vqi; Fri, 11 Aug 2023 06:36:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGlDlShHGlDE7mHYMvNjVNfJcQtZ4826iowMyw5ZEzyvdsGu8OPJDiiyZzN3P5b+6XzMShl X-Received: by 2002:a05:6a21:81a4:b0:126:a80d:4960 with SMTP id pd36-20020a056a2181a400b00126a80d4960mr2280568pzb.30.1691760994273; Fri, 11 Aug 2023 06:36:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691760994; cv=none; d=google.com; s=arc-20160816; b=D8X08aSExlSMepv5L3tmJ6FS+OInBK4RhimmWxA0cuWoMtv8pWg5rzJbJ6Viy4A4z8 v7dEXB88dwcaPnXpJg9dssBF01wUtDaxDLCj79qrHGjn4evGPzhglmZNqBKbGu8ODDUe c9xQKnMw7tVWjHJ0J8bP5ttUP5ZmWNUBqBITrLbdpw6eWysXt48SjtRWa/dGAJJ6zKXB 5Nl/1qjn/+qGc9D7q8XU3oJ17xDzC0XLPQUHrLTfW1EUDOG3jOLMfk6z+FHpFBFq5ZLh NI4r5aKp6b1b9xhH7lBEubcrio2aORA5OJOWy5vsN6rhrXGYcT3Y+c2wGSeCF2FpF0P7 OrOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=CMHuGzCTYdfvTYrn2AHOHTQDvhBgdjY6cSdF+j9kb1I=; fh=JJ3RMNyZnxIEGZTtTxfE8MbNEpNra5c0QZ3mXIR1cmg=; b=geAzmKOnTucFlHphHy28XHnHhETmbmTSAP7BAkpe9dlQpZTxpw/RS+T+gVD/GB5356 J2u6YKmM7TQzHjZDpXRPE0veppD74yx+Q2/icBBfrOMC2xoKvcPyFUGht51RUYsmxucK YqIFb7g6rUV/73AqAPt4u3NPfSDSG2hBiE3N8GGLXmDYrklg/fUqTFil6IBRkAIZkxom vIAOZ1O9TVQuXuOjj53+JHD90zx8h/Ke3cZooSogXEboosV4myv6qPN//vjgXMR8LpLo 7R8someHHnhZZKevhL7i7JRQkWO2KIsLzbAnVN3K3RANI/4/Yi1m3hPot5ziUXdk1W9b GyvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="QgmhZyq/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s78-20020a632c51000000b0054fd9f2dfebsi3616692pgs.704.2023.08.11.06.36.21; Fri, 11 Aug 2023 06:36:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="QgmhZyq/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234323AbjHKMCg (ORCPT <rfc822;shaohuahua6@gmail.com> + 99 others); Fri, 11 Aug 2023 08:02:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229683AbjHKMCe (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 11 Aug 2023 08:02:34 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 535AE273E; Fri, 11 Aug 2023 05:02:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691755354; x=1723291354; h=from:to:cc:subject:date:message-id; bh=B0O4hi7hQYoBUUzuAn//fKEUpIesDWRIrAPu2Jc+J+w=; b=QgmhZyq/G2Ew4KsGooG5O+DvswBWYvdrzE3fmWDSOP4iyxYNNSRHjKVp RayLQmumS7xa3vuSoq+Q0fa+gNn/0Y24sM/XXLnItZXqReD38pJf2kPGI n3D5/rjxSoDg22GT0b2rDqA0vXiui8u/zLd4nSmVVtK68C2PW9cK2EaTE K4TGhPnkuk4d+mMDNUcjWaogpm+gxHwStaCCPZCnd644l/8v4sb7RW4qK VEGvC+c3RWznKCWGBMmTXySURWfNTlSbgfjP0fyVeliKL+CrIaArGlgmH K2nHHrv6s5Ds+cwAVxSBNTBkXEzIF60i88cH4gaJdDz4QPZ/UXBdyX8e9 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10798"; a="438000649" X-IronPort-AV: E=Sophos;i="6.01,165,1684825200"; d="scan'208";a="438000649" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2023 05:02:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10798"; a="906420504" X-IronPort-AV: E=Sophos;i="6.01,165,1684825200"; d="scan'208";a="906420504" Received: from inlubt0316.iind.intel.com ([10.191.20.213]) by orsmga005.jf.intel.com with ESMTP; 11 Aug 2023 05:02:30 -0700 From: Raag Jadav <raag.jadav@intel.com> To: wim@linux-watchdog.org, linux@roeck-us.net, mika.westerberg@linux.intel.com, andriy.shevchenko@linux.intel.com Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, mallikarjunappa.sangannavar@intel.com, pandith.n@intel.com, Raag Jadav <raag.jadav@intel.com> Subject: [PATCH v1] watchdog: intel-mid_wdt: add MODULE_ALIAS() to allow auto-load Date: Fri, 11 Aug 2023 17:32:20 +0530 Message-Id: <20230811120220.31578-1-raag.jadav@intel.com> X-Mailer: git-send-email 2.17.1 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773939976157633772 X-GMAIL-MSGID: 1773939976157633772 |
Series |
[v1] watchdog: intel-mid_wdt: add MODULE_ALIAS() to allow auto-load
|
|
Commit Message
Raag Jadav
Aug. 11, 2023, 12:02 p.m. UTC
When built with CONFIG_INTEL_MID_WATCHDOG=m, currently the driver needs to be loaded manually, for the lack of module alias. This causes unintended resets in cases where watchdog timer is set-up by bootloader and the driver is not explicitly loaded. Add MODULE_ALIAS() to load the driver automatically at boot and avoid this issue. Fixes: 87a1ef8058d9 ("watchdog: add Intel MID watchdog driver support") Signed-off-by: Raag Jadav <raag.jadav@intel.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/watchdog/intel-mid_wdt.c | 1 + 1 file changed, 1 insertion(+)
Comments
On 8/11/23 05:02, Raag Jadav wrote: > When built with CONFIG_INTEL_MID_WATCHDOG=m, currently the driver > needs to be loaded manually, for the lack of module alias. > This causes unintended resets in cases where watchdog timer is > set-up by bootloader and the driver is not explicitly loaded. > Add MODULE_ALIAS() to load the driver automatically at boot and > avoid this issue. > > Fixes: 87a1ef8058d9 ("watchdog: add Intel MID watchdog driver support") > Signed-off-by: Raag Jadav <raag.jadav@intel.com> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/watchdog/intel-mid_wdt.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/watchdog/intel-mid_wdt.c b/drivers/watchdog/intel-mid_wdt.c > index 9b2173f765c8..fb7fae750181 100644 > --- a/drivers/watchdog/intel-mid_wdt.c > +++ b/drivers/watchdog/intel-mid_wdt.c > @@ -203,3 +203,4 @@ module_platform_driver(mid_wdt_driver); > MODULE_AUTHOR("David Cohen <david.a.cohen@linux.intel.com>"); > MODULE_DESCRIPTION("Watchdog Driver for Intel MID platform"); > MODULE_LICENSE("GPL"); > +MODULE_ALIAS("platform:intel_mid_wdt");
diff --git a/drivers/watchdog/intel-mid_wdt.c b/drivers/watchdog/intel-mid_wdt.c index 9b2173f765c8..fb7fae750181 100644 --- a/drivers/watchdog/intel-mid_wdt.c +++ b/drivers/watchdog/intel-mid_wdt.c @@ -203,3 +203,4 @@ module_platform_driver(mid_wdt_driver); MODULE_AUTHOR("David Cohen <david.a.cohen@linux.intel.com>"); MODULE_DESCRIPTION("Watchdog Driver for Intel MID platform"); MODULE_LICENSE("GPL"); +MODULE_ALIAS("platform:intel_mid_wdt");