Message ID | 20230811-topic-acv-v1-1-a85b6e94f46d@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b824:0:b0:3f2:4152:657d with SMTP id z4csp1152139vqi; Fri, 11 Aug 2023 07:54:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGtvzmh6ue0xgn1kZ0au+H7m+rQKxYzOynmKcWApg9qD7kL6AMs/+H8sFZ2qrtDgHnC8a59 X-Received: by 2002:a17:903:41c6:b0:1bc:2f17:c628 with SMTP id u6-20020a17090341c600b001bc2f17c628mr2659414ple.56.1691765697549; Fri, 11 Aug 2023 07:54:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691765697; cv=none; d=google.com; s=arc-20160816; b=YYwYEHCwpuLkRendCbb+gAlUOYnZRLocKCEAcxHtnZDahmP6UQa5XkoIq0nztLmx2X gtmh9bUREcCXWZZ2jlKBg4cGOl0oA1fJz/PIkua49b9BePcQTHKM9zakrq0n2X3qHpuZ BHwI7NFd9g4J5aVmga6ZTbg1/SiyuW9Ylk1U4Vs88NcNLD7Dd9TXjjnhHPwRXP06rVHh cRYhaGrTl3doC33+9SwKVUSwDMMm67bF4gAi1xiRnrPPbYCC7dxfyGvM60CgGsP3onwC 16SH9O5BIxCwUSWyH1fVQ5ZwdP+e3Sf4LgDoVrJyhZcm9ermTBKhUXsnJj/pzNaBiBXG oKqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=dbMy2EJg1/HfJ8Ke6dWMRUTNv1lsrcvmOYBylkeVnks=; fh=f93K69N9m4Ktv+43Ry2j8RBgoHaK1j4bqxyYpmRgI2M=; b=Hjb/vkegO7QWw6D+aR1UFuoGiK0yuvbJHkw3m7RqhjII6uAj42XaKl3jKi4sq3eA8M Zhl5WqLqeU/S6uiLZDdxQGt3djFyKiGpj/5sisD0JPU7sL6ZE2kXFOsgPlzVfnXkYRBL hso1nDWAq17/0s+TIJFbc+CpcG0kWGIthK/QkYy4Utzkgwv3WiVqy26XykowJWE3ZtDU VFUChaO8W/2Ca/n8rDoK1HTnaM0m9BRk0HJXyncV2tADwWcMUwwxhb1dbeLqcEJLFZtA G4oLA9eN5+U/lMl6DCazuu26+JDaFyUEsFBVHLCx1RMP+/7logZLbAP+XXci11bKKP2o Cy9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cyUqTseu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x6-20020a170902ec8600b001b02e044c87si3500592plg.320.2023.08.11.07.54.44; Fri, 11 Aug 2023 07:54:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cyUqTseu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235613AbjHKNEV (ORCPT <rfc822;shaohuahua6@gmail.com> + 99 others); Fri, 11 Aug 2023 09:04:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235141AbjHKNES (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 11 Aug 2023 09:04:18 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55F8F270C for <linux-kernel@vger.kernel.org>; Fri, 11 Aug 2023 06:04:17 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-4fe61ae020bso3055303e87.2 for <linux-kernel@vger.kernel.org>; Fri, 11 Aug 2023 06:04:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691759055; x=1692363855; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dbMy2EJg1/HfJ8Ke6dWMRUTNv1lsrcvmOYBylkeVnks=; b=cyUqTseuMNNavvl/Rf56R/12jMWk/KxToJhWT1aKCbVn8G12AU+iGbiX82IusyF9D1 45wMScJvXukq8y0ACKun8KVS4Zn3UXH+Uj4/OZ0wwQPteEVLaMj0ddWQvbpmkb5DHNje YjgJfOMVr3mEt3nPJTqawqA7eXjJEY186LgIej9dZ5NN+SgPoqIYrwtjYicXgzk7phCv uf7YhwMuy7IFfP8cIexrO4JImuYEjt/bAoUWqaNENTof+8iVn8pxDbW5f4tBVTqLEmmM e+AYLur+r3E+AqgN1JstXHnbvC6PuifjQ7JWFMU8Qbf7XIM0eKFbR3LbYBjUOzNDkznK KEGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691759055; x=1692363855; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dbMy2EJg1/HfJ8Ke6dWMRUTNv1lsrcvmOYBylkeVnks=; b=kEdjjX7GkJT/2SGSsSUMgeQIpAfN4sMuqZlSkcU/hc8yySZWyOhekho3kzFeXKDVrq jJqw6dKU86K2NK1zXdW+qn3jDdcIaJJ2mCcRkDY8fTXab6KX9u1avxSIFYQb2wdX1WPs ZMGLjIuUUqD8uh59XskVhUXK3JXdFq77VDlENulpjjajOwccHavHzGGZOavyIqKELeUO VNM4K+10kHWCjz7ZPHqDNblkLTmEpoml8Xfx3dkAm71W3Fxvc38JzsFT2YDEiF2WmBAm CLdFOameQvD1qtt6FAyB/I9KnBoVNg2rJtMcwML3YijzrFFzu6kvhUj19TCR1NdxPbjz JmzQ== X-Gm-Message-State: AOJu0YzlSYI8sq0L+6hElXDK/QX1NkVEyMb/KCTxKwWL6TyH0K+QyIYa Je/9f6keMAR6C1E7bsAVMCQnHJA9JEvFrzy1tGY= X-Received: by 2002:a05:6512:3695:b0:4fe:2efa:b847 with SMTP id d21-20020a056512369500b004fe2efab847mr1220902lfs.23.1691759055289; Fri, 11 Aug 2023 06:04:15 -0700 (PDT) Received: from [192.168.1.101] (abyj188.neoplus.adsl.tpnet.pl. [83.9.29.188]) by smtp.gmail.com with ESMTPSA id v20-20020a197414000000b004fe15a2f0f6sm722491lfe.62.2023.08.11.06.04.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Aug 2023 06:04:14 -0700 (PDT) From: Konrad Dybcio <konrad.dybcio@linaro.org> Date: Fri, 11 Aug 2023 15:04:08 +0200 Subject: [PATCH 01/11] interconnect: qcom: qdu1000: Set ACV enable_mask MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230811-topic-acv-v1-1-a85b6e94f46d@linaro.org> References: <20230811-topic-acv-v1-0-a85b6e94f46d@linaro.org> In-Reply-To: <20230811-topic-acv-v1-0-a85b6e94f46d@linaro.org> To: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Georgi Djakov <djakov@kernel.org>, Melody Olvera <quic_molvera@quicinc.com>, Odelu Kukatla <okukatla@codeaurora.org>, Richard Acayan <mailingradian@gmail.com>, David Dai <daidavid1@codeaurora.org>, Rob Herring <robh@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Luca Weiss <luca.weiss@fairphone.com>, Sibi Sankar <sibis@codeaurora.org>, Jonathan Marek <jonathan@marek.ca>, Vinod Koul <vkoul@kernel.org> Cc: Marijn Suijten <marijn.suijten@somainline.org>, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio <konrad.dybcio@linaro.org> X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1691759050; l=1290; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=DxgRmQ1OzR3nEWUhjrHYmNAELDVHgCeW41xvvvTsUgo=; b=Brnmp31zihvGRHdQEMbXAiTFp8/XbQXmNqHrn0BraTd4gfvMwpceabzhZjH4oCc5MgPNj+se8 AAVUbNkM7FDDZ2unVfhZqE2IO0P4bVYbxHyB/semsAqmH8VqxipCJKZ X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773944907828165264 X-GMAIL-MSGID: 1773944907828165264 |
Series |
Hook up ACV enable_mask for everybody
|
|
Commit Message
Konrad Dybcio
Aug. 11, 2023, 1:04 p.m. UTC
ACV expects an enable_mask corresponding to the APPS RSC, fill it in.
Fixes: 1f51339f7dd0 ("interconnect: qcom: Add QDU1000/QRU1000 interconnect driver")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
drivers/interconnect/qcom/bcm-voter.h | 2 ++
drivers/interconnect/qcom/qdu1000.c | 1 +
2 files changed, 3 insertions(+)
Comments
On Fri, Aug 11, 2023 at 03:04:08PM +0200, Konrad Dybcio wrote: > ACV expects an enable_mask corresponding to the APPS RSC, fill it in. > > Fixes: 1f51339f7dd0 ("interconnect: qcom: Add QDU1000/QRU1000 interconnect driver") > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > drivers/interconnect/qcom/bcm-voter.h | 2 ++ > drivers/interconnect/qcom/qdu1000.c | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/drivers/interconnect/qcom/bcm-voter.h b/drivers/interconnect/qcom/bcm-voter.h > index b4d36e349f3c..da92267877f9 100644 > --- a/drivers/interconnect/qcom/bcm-voter.h > +++ b/drivers/interconnect/qcom/bcm-voter.h > @@ -16,4 +16,6 @@ struct bcm_voter *of_bcm_voter_get(struct device *dev, const char *name); > void qcom_icc_bcm_voter_add(struct bcm_voter *voter, struct qcom_icc_bcm *bcm); > int qcom_icc_bcm_voter_commit(struct bcm_voter *voter); > > +#define ACV_RSC_APPS BIT(3) This isn't entirely common to all chips. It's been BIT(3) for most of history and is for all the chips in the series. But there upcoming chips where it'll be different. There are only a finite number of ACV bits available, so depending on the requirements they can be repurposed. We should probably just have the raw mask defined in the target files. > + #endif diff --git a/drivers/interconnect/qcom/qdu1000.c > b/drivers/interconnect/qcom/qdu1000.c index bf800dd7d4ba..c504bf348294 > 100644 --- a/drivers/interconnect/qcom/qdu1000.c > +++ b/drivers/interconnect/qcom/qdu1000.c > @@ -769,6 +769,7 @@ static struct qcom_icc_node xs_sys_tcu_cfg = { > > static struct qcom_icc_bcm bcm_acv = { > .name = "ACV", > + .enable_mask = ACV_RSC_APPS, > .num_nodes = 1, > .nodes = { &ebi }, > }; > > -- > 2.41.0 >
diff --git a/drivers/interconnect/qcom/bcm-voter.h b/drivers/interconnect/qcom/bcm-voter.h index b4d36e349f3c..da92267877f9 100644 --- a/drivers/interconnect/qcom/bcm-voter.h +++ b/drivers/interconnect/qcom/bcm-voter.h @@ -16,4 +16,6 @@ struct bcm_voter *of_bcm_voter_get(struct device *dev, const char *name); void qcom_icc_bcm_voter_add(struct bcm_voter *voter, struct qcom_icc_bcm *bcm); int qcom_icc_bcm_voter_commit(struct bcm_voter *voter); +#define ACV_RSC_APPS BIT(3) + #endif diff --git a/drivers/interconnect/qcom/qdu1000.c b/drivers/interconnect/qcom/qdu1000.c index bf800dd7d4ba..c504bf348294 100644 --- a/drivers/interconnect/qcom/qdu1000.c +++ b/drivers/interconnect/qcom/qdu1000.c @@ -769,6 +769,7 @@ static struct qcom_icc_node xs_sys_tcu_cfg = { static struct qcom_icc_bcm bcm_acv = { .name = "ACV", + .enable_mask = ACV_RSC_APPS, .num_nodes = 1, .nodes = { &ebi }, };