diff mbox series

[07/17] scsi: qlogicpti: mark qlogicpti_info() static

Message ID	20230810141947.1236730-8-arnd@kernel.org
State	New
Headers	Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; From: Arnd Bergmann <arnd@kernel.org> To: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, "James E.J. Bottomley" <jejb@linux.ibm.com>, "Martin K. Petersen" <martin.petersen@oracle.com> Cc: Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh@kernel.org>, Bart Van Assche <bvanassche@acm.org>, Jack Wang <jinpu.wang@ionos.com>, linux-scsi@vger.kernel.org Subject: [PATCH 07/17] scsi: qlogicpti: mark qlogicpti_info() static Date: Thu, 10 Aug 2023 16:19:25 +0200 Message-Id: <20230810141947.1236730-8-arnd@kernel.org> In-Reply-To: <20230810141947.1236730-1-arnd@kernel.org> References: <20230810141947.1236730-1-arnd@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	-Wmissing-prototype warning fixes \| [00/17] -Wmissing-prototype warning fixes [01/17,RESEND] jffs2: mark __jffs2_dbg_superblock_counts() static [02/17,RESEND] irq_work: consolidate arch_irq_work_raise prototypes [03/17,RESEND] ida: make 'ida_dump' static [04/17] pci: sysfs: move declarations to linux/pci.h [05/17] swim3: mark swim3_init() static [06/17] macintosh/ams: mark ams_init() static [07/17] scsi: qlogicpti: mark qlogicpti_info() static [08/17] microblaze: mark flush_dcache_folio() inline [09/17] parport: gsc: mark init function static [10/17] zorro: include zorro.h in names.c [11/17] scsi: gvp11: remove unused gvp11_setup() function [12/17] time: make sysfs_get_uname() function visible in header [13/17] stackleak: add declarations for global functions [14/17] kprobes: unify kprobes_exceptions_nofify() prototypes [15/17] arch: fix asm-offsets.c building with -Wmissing-prototypes [16/17,RFC] arch: turn -Wmissing-prototypes off conditionally [17/17,RFC] Makefile.extrawarn: turn on missing-prototypes again

Commit Message

Arnd Bergmann Aug. 10, 2023, 2:19 p.m. UTC

  From: Arnd Bergmann <arnd@arndb.de>

The qlogicpti_info() function is only used in this file and should
be static to avoid a warning:

drivers/scsi/qlogicpti.c:846:13: error: no previous prototype for 'qlogicpti_info' [-Werror=missing-prototypes]

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/scsi/qlogicpti.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jinpu Wang Aug. 10, 2023, 2:27 p.m. UTC | #1

On Thu, Aug 10, 2023 at 4:22 PM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The qlogicpti_info() function is only used in this file and should
> be static to avoid a warning:
>
> drivers/scsi/qlogicpti.c:846:13: error: no previous prototype for 'qlogicpti_info' [-Werror=missing-prototypes]
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
lgtm
Reviewed-by: Jack Wang <jinpu.wang@ionos.com>
> ---
>  drivers/scsi/qlogicpti.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qlogicpti.c b/drivers/scsi/qlogicpti.c
> index f88a5421c483f..3b95f7a6216fe 100644
> --- a/drivers/scsi/qlogicpti.c
> +++ b/drivers/scsi/qlogicpti.c
> @@ -843,7 +843,7 @@ static int qpti_map_queues(struct qlogicpti *qpti)
>         return 0;
>  }
>
> -const char *qlogicpti_info(struct Scsi_Host *host)
> +static const char *qlogicpti_info(struct Scsi_Host *host)
>  {
>         static char buf[80];
>         struct qlogicpti *qpti = (struct qlogicpti *) host->hostdata;
> --
> 2.39.2
>

diff mbox series

Patch

diff --git a/drivers/scsi/qlogicpti.c b/drivers/scsi/qlogicpti.c
index f88a5421c483f..3b95f7a6216fe 100644
--- a/drivers/scsi/qlogicpti.c
+++ b/drivers/scsi/qlogicpti.c
@@ -843,7 +843,7 @@  static int qpti_map_queues(struct qlogicpti *qpti)
 	return 0;
 }
 
-const char *qlogicpti_info(struct Scsi_Host *host)
+static const char *qlogicpti_info(struct Scsi_Host *host)
 {
 	static char buf[80];
 	struct qlogicpti *qpti = (struct qlogicpti *) host->hostdata;