From patchwork Thu Aug 10 13:15:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lu Jialin X-Patchwork-Id: 134009 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b824:0:b0:3f2:4152:657d with SMTP id z4csp455535vqi; Thu, 10 Aug 2023 07:21:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEyVDWpM+edeQoW/VcygC4G6caRSMDPFWsWMYUP6FEkwwyTEbXP6J1eZ2bEfHpz1n8sL588 X-Received: by 2002:aa7:8881:0:b0:686:2526:ee70 with SMTP id z1-20020aa78881000000b006862526ee70mr3400090pfe.14.1691677292522; Thu, 10 Aug 2023 07:21:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691677292; cv=none; d=google.com; s=arc-20160816; b=g2IcFzSlaoQVXxX+jM7yPFytdTQNsxtmvpN6A/QZizYS2WMkuDj4bjyph2P+yo/1es fyzfA9xHG/11prpmgDG5pO68CRYivJ33TigVxGt0aVw1NwGxdTXE4nB18rZz5j7xGIJm zYyf/tPBrt+CN5q4DvLqwmyD0FaOKOwXA4hrvbFqp3YrP+Vz9sXGAlDV+J1I0XuXl/FP Xlx/hMMsf5+ygj6rjY631XXBaRI18/nBdcl1JssKxqsiiinDir80kKfJ4ZPKCLAQYab7 1Wskv+UXl1iCv/MAlmFQOxiYbxZGfVaTDVF9cPB/Svpdv8OkeFHBuAjlN+t3jPQ9EAWo JG8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=WZ76gwOie6WLXdkbrw1HRq/CP2d9byN7ptDDfxPstwA=; fh=W2r1iZBITaPgmMWmplcLmQMVWTfdf6Q2BcOzkWga+Y0=; b=DY7dAbDp884ACr6gBtg96azkUPClzXJeMOiwZlEJp7ZT/yshf3xFiiue3HEu8XZMPe GqQKxDvhvLIS0eZafXIVmENM41sDtdOcQvhLJXskLUB//JCjy8TvO2DcKC+tcd/uWy8Z XvLVfrBJLRrfQW9bl2ctZtThohYNrSaVj2VVGTDkWXI6FbYcMtGdWLgh8xM6IXXemHej vwKzbdmYcTyTtqbSszHumuYiEgiOvK7J5MKZcZhEyd38yT/qMRVRscHKpIW13alvspBO kvmhrLNavbubtP7HLUFUSe6IbqUlw0cifrx9cfugkfiHywteleS6EZsAVqYlEbo4DlAg Jgww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p12-20020a056a0026cc00b0068717825fc9si1533068pfw.405.2023.08.10.07.21.18; Thu, 10 Aug 2023 07:21:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234845AbjHJNQ3 (ORCPT + 99 others); Thu, 10 Aug 2023 09:16:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229693AbjHJNQ2 (ORCPT ); Thu, 10 Aug 2023 09:16:28 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FC3226A2 for ; Thu, 10 Aug 2023 06:16:26 -0700 (PDT) Received: from kwepemm600003.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4RM6mQ0ZXFzCrLy; Thu, 10 Aug 2023 21:12:54 +0800 (CST) Received: from hulk-vt.huawei.com (10.67.174.118) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 10 Aug 2023 21:16:22 +0800 From: Lu Jialin To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider CC: Lu Jialin , Subject: [PATCH] psi: update psi irqtime when the irq delta is nozero Date: Thu, 10 Aug 2023 13:15:14 +0000 Message-ID: <20230810131514.910401-1-lujialin4@huawei.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.67.174.118] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773852208369213280 X-GMAIL-MSGID: 1773852208369213280 If update psi irqtime whether the irq delta is zero or not, the performance will be degradation when update_rq_clock_task works frequently. Therefore, just update psi irqtime whether the irq delta is nozero. performace test of times(libmicro): 1) without psi_account_irqtime in update_rq_clock_task [root@arm64_perf]# ./times -E -C 200 -L -S -W -N "times" -I 200 Running: times# ./../bin-arm64/times -E -C 200 -L -S -W -N times -I 200 prc thr usecs/call samples errors cnt/samp times 1 1 0.45210 188 0 500 2) psi_account_irqtime in update_rq_clock_task [root@arm64_perf]# ./times -E -C 200 -L -S -W -N "times" -I 200 Running: times# ./../bin-arm64/times -E -C 200 -L -S -W -N times -I 200 prc thr usecs/call samples errors cnt/samp times 1 1 0.49408 196 0 500 3) psi_account_irqtime in update_rq_clock_task when irq delta is nozero [root@arm64_perf]# ./times -E -C 200 -L -S -W -N "times" -I 200 Running: times# ./../bin-arm64/times -E -C 200 -L -S -W -N times -I 200 prc thr usecs/call samples errors cnt/samp times 1 1 0.45158 195 0 500 Signed-off-by: Lu Jialin Reviewed-by: Chengming Zhou --- kernel/sched/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index c52c2eba7c73..69c4f229d6d1 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -722,7 +722,8 @@ static void update_rq_clock_task(struct rq *rq, s64 delta) rq->prev_irq_time += irq_delta; delta -= irq_delta; - psi_account_irqtime(rq->curr, irq_delta); + if (irq_delta) + psi_account_irqtime(rq->curr, irq_delta); delayacct_irq(rq->curr, irq_delta); #endif #ifdef CONFIG_PARAVIRT_TIME_ACCOUNTING